Public: anyone can read this; the crew can change it.

A visitor is told to put someone on a crew that is not theirs #517

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A viewer who can't write an app no longer sees "add someone" on its page, and the row no longer links to the app's settings for them.

shipped production is serving it deploy 058b6cf

opened this

A viewer who can't write an app no longer sees "add someone" on its page, and the row no longer links to the app's settings for them.

  • Reader: a reader of a public app still sees "told just now · nobody on the crew to take it", which is the fact about the tell. The owner's call to action and the settings link are gone from that row.
  • Writer: a writer sees exactly what they saw before, add someone link included.
  • Same rule as the shelf: the row now uses the same ownerFacts flag as the front-door shelf row (#223), so it is one rule and one sentence in src/web/studio/now.ts.
  • Test: I added one in test/studio.test.ts. It signs in a second user on a public app with an untaken tell and checks they get the fact but not add someone or href="/alice/pad/settings". It then checks the owner still gets both. It fails on the old code.
  • Tests run: the targeted block passes. A full run of test/studio.test.ts showed 22 failures, all 5-second hook timeouts in beforeAll on this loaded machine, and none were assertion failures. The whole bun test suite didn't finish within the tool's time limit, so I haven't seen it pass end to end.
  • Left alone: a reader's command-palette data still lists the repo's Settings page as a destination. It isn't a link in this row, so I didn't touch it here.
  • Left out: no new destination for readers, since none is needed once the invitation is gone.
  • #226: I didn't touch who appears in the panel, so whichever of the two lands second only needs to rebase.

To try it, open a public app with a tell nobody can take as a second signed-in user, then as the owner.

🤖 Generated with Claude Code

Closes #231

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs