Who told and who shipped: a change shows the agent that wrote it but not the person whose words it answers, and lands under neither together #516

A pull now shows the person whose words it answers (toldBy) next to the agent that wrote it. This is on the pull page, the board's Landed card, the feed item and the merge commit.

The earlier deploy most likely failed because forge.json still held merge-conflict markers (======= and >>>>>>> origin/main) in its check block, so it was invalid JSON. I re-merged main and rebuilt forge.json from main's version, with test/told-by.test.ts added to the check. The change itself is unchanged from #431.

Checks

• Passing: test/told-by.test.ts passes, 5 of 5.
• Failing: in the other suites I ran (feed, feed-page, pulls, landing, studio, board-windows), 6 tests fail and 4 error. Most are 5-second timeouts or "socket closed" in studio tests, and one is a git "Unable to read current working directory" error; I did not trace them or rerun them on main to see if they also fail there. The sandbox also refuses user namespaces.
• Not run: tsc --noEmit can't find the bun types here, so I didn't run the typecheck. I also didn't run the full forge.json check. The forge's check will cover both.

What changed

• Source: toldBy(db, pull) in src/core/pulls.ts reads the issue named by Closes #N or Continues #N in the pull body. It returns that issue's author when they are a person, otherwise null. There is no new column.
• Pull page: shows "in answer to <person>", on both the studio change page and the dev pull page. Names go through userLink, so they are escaped.
• Board: the Landed card shows "told by <person>" beside the author.
• Feed: pull.opened and pull.merged read "(told by bob, by scout)", and "by scout" appears only when an agent wrote the pull.
• Merge commit: when an agent wrote the pull, it is the commit author and the merging person is the committer. The message ends with Requested-by: <issue author> and Co-authored-by: <merging person>.

- Requested-by is left out when no person is found. - Control characters and <> are stripped from names, so a name can't inject a trailer line.

Left out

• Pull list: the issue names four places, so it doesn't show the person.
• No closing line: the "first person message that started the run" fallback isn't built. Without Closes #N, toldBy returns null.
• Imported issues: a pull that closes an imported issue gets no "told by", since that author isn't a local account.
• Old commits: existing merge commits are not rewritten.

To try it: have a person open an issue, have an agent open a pull whose body says Closes #N, and merge it. Then run git log -1 --format=%B on the base branch.

🤖 Generated with Claude Code

Closes #415

I merged main into this branch and pushed it. I couldn't get a clean run of the full check here, so it isn't verified end to end.

The only conflict was in forge.json, in the check command's test list. I kept main's new test/fleet-ops.test.ts and my test/told-by.test.ts.

What I ran:

• My tests: test/told-by.test.ts passes (5 of 5).
• test/web-apps.test.ts: it printed no failures.
• test/studio.test.ts: several tests failed on 5-second timeouts, and one logged "not a git repository". I ran it while a full bun test was running in the background, so contention probably caused the timeouts. I didn't confirm that, and I didn't check whether main fails the same way here.
• Full bun test: it hit the 600-second limit, so I never saw a result.
• tsc: it failed with "Cannot find type definition file for 'bun'", so the typecheck half of the check didn't run here. The deploy's check will run it.

Nothing else changed beyond the merge.

I shortened check.run in forge.json from 1009 to 934 characters and pushed, which should clear the "longer than 1000 characters" failure. I haven't seen the forge's check pass yet.

The line had gone over the limit once test/told-by.test.ts was added. I also merged the latest main, which came in cleanly.

To get back under the limit, I replaced the four crew test files named one by one with the glob test/crew*.test.ts. The check now also runs three crew tests it didn't before: crew-interrupted, crew-loop and crew-totals. Those three pass (13 tests), and sh expands the glob.

I didn't re-run tsc or the other tests after the push. tsc was failing earlier in my sandbox because the bun type definitions weren't installed there, which is a problem with my environment, not the branch.

If you'd rather keep the file list exact, the alternative is to fold the told-by tests into an existing test file.

Operator: main moved under this branch (forge.json's check command was shortened, among others). Merge main into the branch, resolve the conflicts keeping this change's intent, run the check locally, and push.

I merged origin/main into this branch and pushed it. The merge conflicted only in forge.json, and I resolved it.

• Conflict: I took main's shortened check.run, which lists test files by name. I added told-by to the end of that list so this change's tests still run in the check.
• board.ts: src/web/pages/board.ts merged automatically.
• Tests: I ran the check's test runner on the told-by, crew, studio and web tests, and all 218 passed. I did not run the full check list.
• Type check: bun x tsc --noEmit failed here with TS2688: Cannot find type definition file for 'bun'. That is a missing type package in this sandbox, not an error in the code. I did not run it on main to confirm. The forge's own check will run the real type check on this push.

I merged main into the branch again and pushed it. Only forge.json conflicted.

• Conflict: I kept main's check.run, which now includes crew-parks, and kept told-by at the end so this change's tests still run in the check.
• Tests: I ran only test/told-by.test.ts here, and its 5 tests pass. I did not run the full check or the type check.