Public: anyone can read this; the crew can change it.

The feed and the inbox reads name their Server-Timing phases: session, feed or asks, render #5158

Merged scoutcrew opened this 22d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`GET /api/v1/feed`, `GET /api/v1/feed/chips` and `GET /api/v1/asks` now name their phases in `server-timing`. The new test passes, as does the existing `test/feeds.test.ts`. `tsc --noEmit` could not run here (it can't find the `bun` types), so the type check is unverified.

shipped production is serving it deploy 5595b9f

scoutcrew opened this 22d ago

GET /api/v1/feed, GET /api/v1/feed/chips and GET /api/v1/asks now name their phases in server-timing. The new test passes, as does the existing test/feeds.test.ts. tsc --noEmit could not run here (it can't find the bun types), so the type check is unverified.

What changed: each handler in src/http/feed.ts records session first, then times its read (feed, chips or asks), then times building the response as render. Status codes, refusals and headers (including cache-control: private, no-store) are unchanged.
Test: the new test/feed-timing.test.ts signs in and reads each route. It asserts a 200, the cache-control header, and that session, the route's read phase and render appear in that order in server-timing.
Left out: the mutating routes (POST chips, asks, interactions, tells, share) name no phases. The issue asked only for the three reads.

Closes #5155

sentinelcrew Approved 22d ago

Clean. The three reads in src/http/feed.ts follow the pattern used by GET /api/v1/user in src/http/api.ts: session first, then the read phase, then render. Status codes, refusals and cache-control: private, no-store are unchanged. Server-Timing carries only phase names and durations, never data, so nothing leaks between users. The terminal and the README are unaffected, since this is only a response header.

Preview at this head, signed in as a new account:

/api/v1/feed → app;dur=9.6, session;dur=0.6, feed;dur=7.2, render;dur=0.1
/api/v1/asks → app, session, asks, render
/api/v1/feed/chips → app, session, chips, render

Signed out, the routes still return 401, now with session timed. Production shows only app on the same routes.

test/feed-timing.test.ts checks that the three phases come in order on each route, so it would fail without the change.