Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:36a5qcqa3a is past its budget: trevato/forge: "test/og-route.test.ts > og cards > (unnamed)" failed on 3 pulls in the last hour — the lane's red, not … #5144
Check · Review · Land · Live done — Landed and live in production.
`test/og-route.test.ts` now allows 30 seconds per hook and test, up from bun's 5-second default. This is my diagnosis, not something I saw fail: I couldn't reproduce the failure here. The file passes in about a second locally (26 tests), and the check's log isn't in my sandbox.
shipped production is serving it deploy b070674
Fixes the flaky og-route setup (beforeAll creates three repos on disk and hit the 5s default on a loaded check machine) with setDefaultTimeout(30_000), the same pattern as releases-page, parent-link and apps-new tests. Minimal, test-only, no behaviour change, no dependency. Two things to do next: (1) if it still flakes, find why repo creation is slow (git init per repo) instead of raising the number again; (2) consider one shared helper or bunfig timeout so each file does not set its own.
The fix for this issue is already on the branch and pushed, so I made no new commit. This branch is one commit ahead of main: 2e455b04.
What changed. test/og-route.test.ts sets setDefaultTimeout(30_000). The beforeAll hook, which shows up as "(unnamed)", creates three repos on disk. It was hitting bun's 5 s default timeout whenever the check machine was loaded. That made the verdict depend on machine load rather than on the code.
Evidence. bun test test/og-route.test.ts passes here (26 tests, 0 failures, about 0.7 s). I did not reproduce the timeout, because this machine isn't loaded. I'm inferring the cause from the hook's name and the 5 s default.
What I left out. I did not make the setup itself cheaper, for example by creating one repo instead of three. Pulls that were red only on this test will go green on main's next check once this lands.
To try it. Run bun test test/og-route.test.ts.
test/og-route.test.tsnow allows 30 seconds per hook and test, up from bun's 5-second default. This is my diagnosis, not something I saw fail: I couldn't reproduce the failure here. The file passes in about a second locally (26 tests), and the check's log isn't in my sandbox.The "(unnamed)" failure is most likely the file's
beforeAll, which is unnamed. It creates three repos on disk and a pile of rows, and on a loaded check machine it can run past 5 seconds. When that happens the whole file goes red even though nothing in the code under test is wrong.I used
setDefaultTimeout(30_000), the same patternreleases-page,parent-linkandapps-newalready use. There are no other changes, and I chose not to touch the setup's logic. I didn't run the type check; the only change is a timeout call and an import.To try it, run
bun test test/og-route.test.ts.If the sentinel still lists the cause after this lands, the slowness is somewhere other than that setup, and the check's log will show where.
Closes #5141