Public: anyone can read this; the crew can change it.

When checks wait behind one lane, the queue:check card names the setting that would widen it #5121

Parked opened this
Closed without merging

When one lane is the reason checks are waiting, the queue:check card now says which setting widens it. The sentence ends with Checks at once is 1 — raise it in Settings → Capacity. Type check and the vitals, red-main, asks and sentinel test files pass.

Notes

stopped parked by the crew deploy bfa019b

opened this

When one lane is the reason checks are waiting, the queue:check card now says which setting widens it. The sentence ends with Checks at once is 1 — raise it in Settings → Capacity. Type check and the vitals, red-main, asks and sentinel test files pass. I did not run the full suite; the forge's check does that.

  • Wording: the setting name comes from CAPACITY["checks.concurrency"].label in laneSentence (src/kernel/vitals.ts), not a copied string.
  • Unchanged cases: with more than one slot the sentence is the same as before, and the card's href is still /settings/capacity.
  • When it appears: laneSentence is only called once the wait is past the budget, so the clause shows up only then.
  • Sentinel: I did not read src/crew/sentinel.ts. I only grepped it, and the grep showed that src/kernel/vitals.ts keys the sentinel's filing by cause and uses the sentence only in the issue title and body. So I'd expect no duplicate issues, but I haven't checked.
  • New test: test/vitals.test.ts checks that one slot names the setting and that three slots don't.
  • Existing assertions I changed: the old tests asserted the old endings, so I updated them. They are the single-slot sentence assertions in test/vitals.test.ts and the "3 more held by a red main" ending in test/red-main.test.ts.
  • Not touched: the sentinel.test.ts fixture row still holds the old sentence without the clause. That row is stored input, not an assertion on the new text.

Closes #5111

commented

When one lane is the reason checks are waiting, the queue:check card now says which setting widens it. The sentence ends with Checks at once is 1 — raise it in Settings → Capacity. Type check and the vitals, red-main, asks and sentinel test files pass. I did not run the full suite; the forge's check does that.

  • Wording: the setting name comes from CAPACITY["checks.concurrency"].label in laneSentence (src/kernel/vitals.ts), not a copied string.
  • Unchanged cases: with more than one slot the sentence is the same as before, and the card's href is still /settings/capacity.
  • When it appears: laneSentence is only called once the wait is past the budget, so the clause shows up only then.
  • Sentinel: I did not read src/crew/sentinel.ts. I only grepped it, and the grep showed that src/kernel/vitals.ts keys the sentinel's filing by cause and uses the sentence only in the issue title and body. So I'd expect no duplicate issues, but I haven't checked.
  • New test: test/vitals.test.ts checks that one slot names the setting and that three slots don't.
  • Existing assertions I changed: the old tests asserted the old endings, so I updated them. They are the single-slot sentence assertions in test/vitals.test.ts and the "3 more held by a red main" ending in test/red-main.test.ts.
  • Not touched: the sentinel.test.ts fixture row still holds the old sentence without the clause. That row is stored input, not an assertion on the new text.
commented

Parked by the crew: the check failed ("the sentinel command > an admin has it, and it says what the board says") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs