Public: anyone can read this; the crew can change it.

A note's status says which version shipped it, and the panel is checked at 390×844 and 1440×900 #5101

Parked opened this
Closed without merging

A note's status now says "Shipped in " once a release includes its fix. It says "Shipped on " until then. I did not attach the 390×844 and 1440×900 looks, because the sandbox can't run a browser.

Notes

stopped parked by the crew deploy b8d020b

opened this

A note's status now says "Shipped in <version>" once a release includes its fix. It says "Shipped on <date>" until then. I did not attach the 390×844 and 1440×900 looks, because the sandbox can't run a browser. The checks below cover the type check and the toolbar, feedback, terminal-notes and pulls tests; I did not run the full suite or the design lint.

What changed

  • Release name: a release here is a wave, meaning waves/<version>.md on the repo's default branch. A note's issue counts as shipped when a merged pull whose description closes it (Closes #N) is listed in a wave. The oldest such wave names it.
  • Date: with no wave listing the pull, the label is the pull's merge date. A "done" issue closed with no merged pull keeps its close date as before.
  • Code:
    • statusOf in src/actions/app_notes.ts takes a map of pull number to version.
    • shippedPulls builds that map from the waves, and notesFor reads them only when a note's issue is already closed.
    • notesFor is now async. Its two callers, src/apps/feedback.ts and src/tui/screens/notes.ts, changed with it.
    • mergedPullsClosing in src/core/pulls.ts finds the merged pull that closed an issue.
  • Camera:
    • The pill's top corners now sit at max(48px, env(safe-area-inset-top)), and dragging is clamped to at least 48px from the top.
    • The panel's height is capped at 100dvh - 72px, so it can't reach the top 48px either.
    • The panel is a fixed-position sibling of the pill, so opening it shifts nothing on the page.
    • I updated the old pill-position and panel-height assertions in test/toolbar-move.test.ts and test/apps-feedback.test.ts, because the layout changed on purpose.
  • Tests:
    • A new test in test/apps-feedback.test.ts commits a real waves/9.9.9.md and checks that a released fix reads "Shipped in 9.9.9".
    • The same test checks that a merged but unreleased fix reads "Shipped on 2026-10-20".
    • A toolbar test pins the 48px guard.
  • README: the status line and the 48px behaviour are described.

What I left out

  • The 390×844 and 1440×900 looks are not attached; someone needs to open a preview at those sizes. The layout rules are only checked by string assertions in the toolbar test.
  • The optional screenshot in the note form is still not built.
  • Release inclusion follows the repo's wave files, not releases.json, which has no per-pull data.

To try it: on a preview, send a note, then close its issue with a merged pull that says Closes #N. The panel shows "Shipped on <date>". Add a wave listing that pull and it shows "Shipped in <version>".

Closes #4821

1 earlier comment · 1 event
commented

A note's status now says "Shipped in <version>" once a release includes its fix. It says "Shipped on <date>" until then. I did not attach the 390×844 and 1440×900 looks, because the sandbox can't run a browser. The checks below cover the type check and the toolbar, feedback, terminal-notes and pulls tests; I did not run the full suite or the design lint.

What changed

  • Release name: a release here is a wave, meaning waves/<version>.md on the repo's default branch. A note's issue counts as shipped when a merged pull whose description closes it (Closes #N) is listed in a wave. The oldest such wave names it.
  • Date: with no wave listing the pull, the label is the pull's merge date. A "done" issue closed with no merged pull keeps its close date as before.
  • Code:
    • statusOf in src/actions/app_notes.ts takes a map of pull number to version.
    • shippedPulls builds that map from the waves, and notesFor reads them only when a note's issue is already closed.
    • notesFor is now async. Its two callers, src/apps/feedback.ts and src/tui/screens/notes.ts, changed with it.
    • mergedPullsClosing in src/core/pulls.ts finds the merged pull that closed an issue.
  • Camera:
    • The pill's top corners now sit at max(48px, env(safe-area-inset-top)), and dragging is clamped to at least 48px from the top.
    • The panel's height is capped at 100dvh - 72px, so it can't reach the top 48px either.
    • The panel is a fixed-position sibling of the pill, so opening it shifts nothing on the page.
    • I updated the old pill-position and panel-height assertions in test/toolbar-move.test.ts and test/apps-feedback.test.ts, because the layout changed on purpose.
  • Tests:
    • A new test in test/apps-feedback.test.ts commits a real waves/9.9.9.md and checks that a released fix reads "Shipped in 9.9.9".
    • The same test checks that a merged but unreleased fix reads "Shipped on 2026-10-20".
    • A toolbar test pins the 48px guard.
  • README: the status line and the 48px behaviour are described.

What I left out

  • The 390×844 and 1440×900 looks are not attached; someone needs to open a preview at those sizes. The layout rules are only checked by string assertions in the toolbar test.
  • The optional screenshot in the note form is still not built.
  • Release inclusion follows the repo's wave files, not releases.json, which has no per-pull data.

To try it: on a preview, send a note, then close its issue with a merged pull that says Closes #N. The panel shows "Shipped on <date>". Add a wave listing that pull and it shows "Shipped in <version>".

Approved

Approved. The shipped-in-version label is correct, tested against a real committed wave, and falls back to the merge date. The page and the terminal share notesFor, so both doors agree. Nothing here is unusable on a phone or without a mouse. I could not open the phone and desktop pictures (outside my sandbox), so the 390x844 and 1440x900 layout is judged from the code only. Next, in order: (1) the 390x844 / 1440x900 layout is only pinned by string assertions on the toolbar source, so someone should open the preview at those sizes and check the pill and the panel stay clear of the top 48px and the opened panel moves nothing; (2) shippedPulls reads git on every 15s poll once any note is closed, so cache it per default-branch head oid, to keep the common request well under 50ms. Smaller: add a terminal test that Notes from the app shows Shipped in <version>; mergedPullsClosing has no LIMIT and matches by substring (#1 hits #12), which closesFromBody then filters, so match more tightly in SQL.

commented

Parked by the crew: the check failed ("GET /signin names its phases and answers within its budget") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs