aa19339 · 3583163 · d51116f · 3d38279 · 15d973b · b5457bd
@@ -33,6 +33,7 @@
for a tunnel and a forge that sleeps.
| `account_role` | `{ username, role, usdPerMonth?, dryRun? }`: make a person a `member`, or a `guest` again, with an optional starter allowance (`usdPerMonth`, 0.01 to 10000, promoting only); planned first (`dryRun` is true unless `false`) | yes |
| `account_suspend` | `{ username, suspended }`: suspend a person's account, or unsuspend it with `false`; their sessions and tokens stop at once; the API's rules (not yourself, another admin or an agent; not the only owner of an organization); an admin token | yes |
| `account_verify` | `{ username }`: mark a person's email verified, as `POST …/admin/accounts/:username/verify` does; a person admin's, with an admin token | yes |
| `accounts` | `{ cursor?, limit? }`: the forge's accounts, newest first: `username`, `role`, `verified`, `suspended`, `created`, and `next` (a cursor, or null); `limit` 1-50 (default 20); a person admin's |  |
| `agent` | `{ action, username, … }`: `create` a crew agent, `update` its `model`, `brief` or `budgetUsd`, or `remove` it; an admin's, with an `admin` token, as `/api/v1/agents` | yes |
| `app_deploy` | `{ repo, env, action }`: `redeploy` or `stop` an app's `production` or a pull's `pull-N` preview; a writer's, queued as `POST …/app/:env/redeploy` and `…/stop` are; answers `{ queued, run }` or `{ stopped }` | yes |
| `app_env` | `{ repo, action, name?, value?, scope? }`: `list` an app's variable names and scopes, `set` one, or `unset` it, in `all` (default), `production` or `preview`; the API's rules and errors, an admin of the repository with an admin-scope token; a value is never read back | yes |
@@ -0,0 +1,45 @@
import { listAccounts } from "../../../actions/accounts.ts";
import { roleOf } from "../../../core/roles.ts";
import { getUserByName } from "../../../core/users.ts";
import { good, bad, type Tool } from "../shared.ts";
export const tool: Tool = {
  name: "accounts",
  doc: "`{ cursor?, limit? }`: the forge's accounts, newest first: `username`, `role`, `verified`, `suspended`, `created`, and `next` (a cursor, or null); `limit` 1-50 (default 20); a person admin's",
  description: "Accounts, newest first: role, verified, suspended. `cursor` pages.",
  inputSchema: {
    type: "object",
    properties: {
      cursor: { type: "string" },
      limit: { type: "integer", minimum: 1, maximum: 50 },
    },
  },
  writes: false,
  adminOnly: true,
  run(ctx, user, args) {
    const listed = listAccounts(ctx.app, user);
      
        sentinelcrew
        19d ago
        
      
      Low: adminOnly lists the tool to agent admins too, but listAccounts refuses them, so an agent admin is shown a tool it can never use. Nothing leaks, since the refusal is correct. Someday a personAdminOnly filter in shared.ts would close that gap.
    
    if (!listed.ok) return bad("forbidden", "the accounts are a forge admin's to list");
      
        sentinelcrew
        19d ago
        
      
      Low: this is the only line that refuses an agent with isAdmin, because adminOnly checks only user.isAdmin. A test with an admin agent's token, expecting forbidden, would pin it.
    
    const given = args["limit"];
    if (given !== undefined && (!Number.isInteger(given) || (given as number) < 1 || (given as number) > 50))
      return bad("invalid", "limit is a whole number from 1 to 50");
    const limit = (given as number | undefined) ?? 20;
    const from = args["cursor"] === undefined ? 0 : Number(args["cursor"]);
      
        sentinelcrew
        19d ago
        
      
      Low: cursor: "" reads as offset 0, and a numeric cursor (5) also passes although the schema says string. Suggested fix: typeof args.cursor === "string" && /^\d+$/.test(args.cursor), otherwise refuse as invalid.
    
    if (!Number.isInteger(from) || from < 0 || typeof args["cursor"] === "boolean")
      return bad("invalid", "that cursor was not issued here");
    const page = listed.value.slice(from, from + limit);
    const next = from + limit < listed.value.length ? String(from + limit) : null;
    return good({
      items: page.map((a) => {
        const who = getUserByName(ctx.app.db, a.username);
        return {
          username: a.username,
          role: who === undefined ? "guest" : roleOf(ctx.app.db, who),
          verified: a.verified,
          suspended: a.suspendedAt !== null,
          created: a.createdAt,
        };
      }),
      next,
    });
  },
};
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "app_env",
  doc: "`{ repo, action, name?, value?, scope? }`: `list` an app's variable names and scopes, `set` one, or `unset` it, in `all` (default), `production` or `preview`; the API's rules and errors, an admin of the repository with an admin-scope token; a value is never read back",
  description:
    "An app's environment variables: list names, set or unset one by scope; values are write-only. Admin.",
    "An app's environment variables: list names, set or unset by scope; write-only. Admin.",
  inputSchema: {
    type: "object",
    properties: {
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "archive",
  doc: "`{ repo | repos, archived?, dryRun? }`: archive (true) or wake (false) a repository, by name; planned first (`dryRun` is true unless `false`); only the repository's admin with an admin token, never an agent. `repos` (at most 50) runs the fleet `archive` operation over them, answers each one's outcome and the `operation` id; `limb` with `action: \"undo\"`, that `operation` and any one of the repositories as `app` reverts it for a day",
  description:
    "Archive a repository or wake it (`archived` true/false); deletes nothing. Plans first; admin token.",
    "Archive or wake a repository (`archived`). Plans first; admin token.",
      
        sentinelcrew
        19d ago
        
      
      Nit: dropping "deletes nothing" loses the one phrase that tells an agent archiving is safe. Same with app_env: "values are write-only" became "write-only", which now reads as if the whole tool only writes. If bytes free up later, put both back.
    
  inputSchema: {
    type: "object",
    properties: {
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "asked",
  doc: "`{ repo?, show?, order? }`: what people asked the crew for, by default nothing merged yet and oldest first: who and when, the pulls that close it, the crew's last activity, waiting/building/shipped/closed, stale when not shipped in three days and flagged when stale with nothing built; repositories you can write",
  description:
    "What people asked the crew for where you write: by default nothing merged yet, oldest first.",
    "What people asked the crew for where you write: by default unmerged, oldest first.",
  inputSchema: {
    type: "object",
    properties: {
@@ -4,7 +4,7 @@
import { good, bad, type Tool } from "../shared.ts";
export const tool: Tool = {
  name: "asks_undecide",
  description:
    "Put a card the decider set aside back on your board, within a day. `id` is from `asks_decide`.",
    "Put a set-aside card back on your board, within a day. `id` from `asks_decide`.",
  inputSchema: {
    type: "object",
    properties: { id: { type: "string", maxLength: 80 } },
@@ -6,7 +6,7 @@
import { good, attachWords, bad, type Tool, str, APP_ARG, planRepo, isAnswer } f
export const tool: Tool = {
  name: "attach_look",
  description:
    "Attach a PNG or JPEG (base64 `image`, max 5 MB) to an open pull: `phone` or `desktop`, `says`.",
    "Attach a PNG or JPEG (base64 `image`, max 5 MB) to an open pull: `phone`/`desktop`, `says`.",
  inputSchema: {
    type: "object",
    properties: {
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "audit",
  doc: "who can do what, per app, read from its contract.json in git: yes, own or no per door, and whether outsiders may direct its crew (`crewOutsiders`)",
  description:
    "Who can do what in every app you can see, from each contract.json: resource × verb, yes, own or no.",
    "Who can do what in each app you see, from contract.json: resource × verb, yes, own or no.",
  inputSchema: {
    type: "object",
    properties: {
@@ -5,7 +5,7 @@
export const tool: Tool = {
  name: "board_write",
  doc: "`{ slug, board }` (person admins): write a whole board under a slug, made or replaced: `{ title, range, refresh, panels: [{ title, chart, query, w, h }] }`",
  description:
    "Write a whole board under a slug: {title, range, refresh, panels: [{title, chart, query, w, h}]}.",
    "Write a whole board under a slug: {title, range, refresh, panels}.",
  inputSchema: {
    type: "object",
    properties: {
@@ -11,7 +11,7 @@
export const tool: Tool = {
  name: "branches",
  doc: "`{ repo, name?, action?, from?, kind? }`: without `name`, lists the branches; `kind: \"tags\"` lists the tags instead (as GET `/api/v1/repos/:owner/:name/tags` does, newest first; no `name` or `action`); with `name` and `action` (`create` from `from`, or `delete`) it does what the branches page does: the default branch is never deleted, only a writer may act",
  description:
    "A repository's branches; `name` and `action` create (from `from`) or delete one, not the default.",
    "A repository's branches; `name`, `action` create (from `from`) or delete one, not the default.",
  inputSchema: {
    type: "object",
    properties: {
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "cloud_accounts",
  doc: "the forge's cloud accounts, each attached provider token with its use, verification, write permission and today's calls; a forge admin only (counted as a write so a `ro` token never lists them)",
  description:
    "Cloud accounts (forge admin): each provider token's use, verification, write permission, calls today.",
    "Cloud accounts (admin): each provider token's use, verification, write permission, calls today.",
  inputSchema: { type: "object", properties: {} },
  // A read, but marked a write so a `ro` token never lists the accounts; it
  // is a forge admin's and the audit rows name every vendor call.
@@ -5,7 +5,7 @@
export const tool: Tool = {
  name: "contribute",
  doc: "for any arriving agent: what this forge is, its bottleneck, open “help wanted” issues, how to propose",
  description:
    "For an arriving agent: what this forge is, its bottleneck, “help wanted” issues, how to propose.",
    "For an arriving agent: what this forge is, its bottleneck, help-wanted issues, how to propose.",
  inputSchema: { type: "object", properties: {} },
  writes: false,
  run: (ctx) => good(welcome(ctx.app)),
@@ -8,7 +8,7 @@
export const tool: Tool = {
  name: "converge",
  doc: "the fork's crew merges where both sides changed the same files; comes back as a pull",
  description:
    "Have a fork's crew merge the parent's updates where both changed the same files, as a pull.",
    "A fork's crew merges the parent's updates where both changed the same files, as a pull.",
  inputSchema: {
    type: "object",
    properties: { repo: REPO_ARG },
@@ -5,7 +5,7 @@
export const tool: Tool = {
  name: "edit",
  doc: "a new title or body for an issue or a pull: its author's, or a writer's; an agent edits only what it wrote",
  description:
    "Retitle or rewrite an issue or pull: yours, or any where you write; an agent edits only its own.",
    "Retitle or rewrite an issue or pull: yours, or where you write; an agent only its own.",
  inputSchema: {
    type: "object",
    properties: {
@@ -9,7 +9,7 @@
export const tool: Tool = {
  name: "following",
  doc: "where a fork stands against what it follows, and what the crew is doing about it",
  description:
    "Where a fork stands against what it follows: in step, behind, ahead, diverged; files to decide.",
    "Where a fork stands against what it follows: in step, behind, ahead, diverged.",
  inputSchema: {
    type: "object",
    properties: { repo: REPO_ARG },
@@ -5,7 +5,7 @@
export const tool: Tool = {
  name: "forges",
  doc: "an admin's list of the forges sent from here: name, address, whom for, apps, claimed or not, last activity",
  description:
    "The forges sent from here (admin): name, address, for, apps, claimed, spendTodayUsd, ceilingUsd.",
    "The forges sent from here (admin): name, address, apps, claimed, spendTodayUsd, ceilingUsd.",
  inputSchema: { type: "object", properties: {} },
  writes: false,
  async run(ctx, user) {
@@ -4,7 +4,7 @@
import { good, bad, type Tool, str } from "../shared.ts";
export const tool: Tool = {
  name: "here",
  description:
    "What you can do on a forge page, as who you are: each open action with its HTTP route and MCP tool.",
    "What you can do on a forge page: each open action with its HTTP route and MCP tool.",
  inputSchema: {
    type: "object",
    properties: { url: { type: "string", maxLength: 2000 } },
@@ -6,7 +6,7 @@
export const tool: Tool = {
  name: "hold",
  doc: "`{ app, pull, why?, release?, dryRun? }`: hold a pull so no rule reviews or lands it, or let it go; a person who can write, never an agent; plans unless `dryRun: false`",
  description:
    "Hold a pull (`why`) or let it go (`release: true`): while held nothing reviews or lands it. Writers.",
    "Hold a pull (`why`) or release it (`release: true`): held, nothing reviews or lands it. Writers.",
  inputSchema: {
    type: "object",
    properties: {
@@ -20,7 +20,7 @@
const notAdmin = (): Answer => bad("not_found", "no such app or repository, or y
export const tool: Tool = {
  name: "hooks",
  doc: "`{ repo, action, url, secret, kinds, id }`: `list`, `add` (`secret`, 16–200 characters, is required) or `remove` the repository's webhooks, as `…/hooks`; an admin-scope token on a repository you administer, and a secret is never shown",
  description: "List, add (`url`, `secret`, `kinds`) or remove (`id`) a repository's webhooks; admins only, a secret is never shown.",
  description: "List, add (`url`, `secret`, `kinds`) or remove (`id`) a repository's webhooks; admins; a secret is never shown.",
  inputSchema: {
    type: "object",
    properties: {
@@ -4,6 +4,7 @@
export { tool as access } from "./access.ts";
export { tool as account_role } from "./account_role.ts";
export { tool as account_suspend } from "./account_suspend.ts";
export { tool as account_verify } from "./account_verify.ts";
export { tool as accounts } from "./accounts.ts";
export { tool as agent } from "./agent.ts";
export { tool as app_deploy } from "./app_deploy.ts";
export { tool as app_env } from "./app_env.ts";
@@ -5,7 +5,7 @@
import { good, bad, type Tool, REPO_ARG, repoArg, issueArg, isAnswer } from "../
export const tool: Tool = {
  name: "issue_teams",
  description:
    "Name up to two crew teams (design, data-science, security, platform) to review an issue's pull.",
    "Name up to two crew teams (design, data-science, security, platform) to review the pull.",
  inputSchema: {
    type: "object",
    properties: {
@@ -7,7 +7,7 @@
export const tool: Tool = {
  name: "labels",
  doc: "`{ repo, number, labels }`: set an issue's or a pull's labels to exactly these (`[]` clears); only labels the repository has, by a writer",
  description:
    "Set an issue's or pull's labels to exactly these (none clears), from the repository's. Writers.",
    "Set an issue's or pull's labels to exactly these (none clears). Writers.",
  inputSchema: {
    type: "object",
    properties: {
@@ -6,7 +6,7 @@
import { good, bad, type Tool } from "../shared.ts";
export const tool: Tool = {
  name: "limits",
  description:
    "Every limit the forge's owner can hit, value and bounds. `key` and `value` (\"\" restores) plan.",
    "Every limit the owner can hit, value and bounds. `key`, `value` (\"\" restores) plan.",
  inputSchema: {
    type: "object",
    properties: {
@@ -7,7 +7,7 @@
export const tool: Tool = {
  name: "make_it_yours",
  doc: "`{ repo, name?, visibility?, dryRun? }`: a fork of an app you can see, as your own app, following the original; code and history copied, data and secrets not; private unless `visibility` is public (a public original only); at most 5 copies an account a day; plans unless `dryRun` is false",
  description:
    "Fork an app you can see: its code and history, following the original; nothing else is copied.",
    "Fork an app you can see: code and history, following the original.",
      
        sentinelcrew
        19d ago
        
      
      Low: the cut dropped "nothing else is copied". That clause is the part that tells an agent data and secrets stay behind. doc still says it, but tools/list is what an agent reads. Worth putting back if a later trim frees the bytes. The same goes for archive's "deletes nothing".
    
  inputSchema: {
    type: "object",
    properties: {
@@ -5,7 +5,7 @@
export const tool: Tool = {
  name: "prompts",
  doc: "`{ repo, action, kind?, token?, at?, id? }`: list, add, run or remove an app's prompt sources (Instagram), as the `…/prompts` API does; the token goes in once and is never shown; listed only for an admin-scope token, and only the repository's admin may use it",
  description:
    "An app's prompt sources (Instagram): list, add (`kind`, `token`, `at`), run or remove (`id`). Repository admin token.",
    "An app's prompt sources (Instagram): list, add (`kind`, `token`, `at`), run or remove (`id`). Admin token.",
  inputSchema: {
    type: "object",
    properties: {
@@ -12,7 +12,7 @@
export const tool: Tool = {
  name: "pull",
  doc: "`{ repo, number }`: a pull's title, state, head and base, and for an open pull whether it merges into the base's current head (`mergeable`) and the paths that stop it (`conflicts`), and `check: { state, baseOid }`: the latest check's state and the base tip it was merged with (empty when it merged nothing); `mergeable` and `conflicts` are the same fields as `GET …/pulls/:number`, `check` is `state` and `run.baseOid` from `GET …/pulls/:number/checks`; draws the `ui://forge/pull` card: `#N title`, state with check and conflicts while open, `head → base` linked to the pull, and the preview link when the pull has an environment",
  description:
    "Read a pull: title, state, head, base; open: `mergeable`, `conflicts`, `proposal`, `checkStale`, `check`.",
    "Read a pull: title, state, head, base; open: `mergeable`, `conflicts`, `proposal`, `check`.",
  inputSchema: {
    type: "object",
    properties: {
@@ -0,0 +1,94 @@
/** The `accounts` tool lists what GET /api/v1/admin/accounts lists, for an admin only. */
import { afterAll, beforeAll, describe, expect, test } from "bun:test";
import { mkdtemp, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { createApp, type App } from "../src/app.ts";
import { createToken } from "../src/core/tokens.ts";
import { createUser } from "../src/core/users.ts";
import { serve, type Servers } from "../src/http/server.ts";
describe("MCP accounts", () => {
  let dataDir: string;
  let app: App;
  let servers: Servers;
  let adminToken: string;
  let bobToken: string;
  let id = 1;
  const rpc = async (token: string, method: string, params: unknown) => {
    const res = await fetch(`${servers.url}/mcp`, {
      method: "POST",
      headers: {
        "content-type": "application/json",
        accept: "application/json, text/event-stream",
        authorization: `Bearer ${token}`,
      },
      body: JSON.stringify({ jsonrpc: "2.0", id: id++, method, params }),
    });
    return (await res.json()) as any;
  };
  const accounts = async (token: string, args: unknown = {}) => {
    const body = await rpc(token, "tools/call", { name: "accounts", arguments: args });
    if (body.error) return { refused: body.error.message as string };
    const text: string = body.result.content[0].text;
    return body.result.isError === true ? { error: text } : { value: JSON.parse(text) };
  };
  beforeAll(async () => {
    dataDir = await mkdtemp(join(tmpdir(), "forge-mcp-accounts-"));
    app = createApp({ dataDir, port: 0 });
    servers = await serve(app);
    const mk = async (username: string, adminIfFirst = false) => {
      const u = await createUser(app.db, {
        origin: "seed", trusted: true, username,
        email: `${username}@forge.local`, password: "a-good-passphrase", adminIfFirst,
      });
      if (!u.ok) throw new Error(u.error);
      return u.value;
    };
    const alice = await mk("alice", true);
    const bob = await mk("bob");
    await mk("carol");
    app.db.query("UPDATE user SET suspended_at = ?1 WHERE username = 'carol'").run(new Date().toISOString());
    adminToken = createToken(app.db, alice.id, "ro", "ro").token;
    bobToken = createToken(app.db, bob.id, "ro", "ro").token;
  }, 30_000);
  afterAll(async () => {
    servers.stop();
    app.close();
    await rm(dataDir, { recursive: true, force: true });
  });
  test("an admin lists three accounts and sees the suspended one marked", async () => {
    const r = await accounts(adminToken);
    const items = r.value.items;
    expect(items.map((i: any) => i.username).sort()).toEqual(["alice", "bob", "carol"]);
    const by = (n: string) => items.find((i: any) => i.username === n);
    expect(by("alice").role).toBe("admin");
    expect(by("carol").suspended).toBe(true);
    expect(by("bob").suspended).toBe(false);
    expect(typeof by("bob").verified).toBe("boolean");
    expect(JSON.stringify(r.value)).not.toContain("@forge.local");
  });
  test("limit pages with a cursor", async () => {
    const one = await accounts(adminToken, { limit: 2 });
    expect(one.value.items).toHaveLength(2);
    expect(one.value.next).not.toBeNull();
    const two = await accounts(adminToken, { limit: 2, cursor: one.value.next });
    expect(two.value.items).toHaveLength(1);
    expect(two.value.next).toBeNull();
    expect((await accounts(adminToken, { limit: 0 })).error).toBeDefined();
    expect((await accounts(adminToken, { cursor: "x" })).error).toBeDefined();
  });
  test("a non-admin is not listed the tool and is refused it", async () => {
    const list = await rpc(bobToken, "tools/list", {});
    expect(list.result.tools.map((t: any) => t.name)).not.toContain("accounts");
    const admin = await rpc(adminToken, "tools/list", {});
    expect(admin.result.tools.map((t: any) => t.name)).toContain("accounts");
    expect((await accounts(bobToken)).refused).toContain("no tool named accounts");
  });
});
@@ -208,6 +208,7 @@
describe("the forge over MCP", () => {
      "health",
      "audit",
      "model_grant",
      "accounts",
      "whoami_can",
      "mint_invite",
      "invites",
		@@ -33,6 +33,7 @@ for a tunnel and a forge that sleeps.
33	33	\| `account_role` \| `{ username, role, usdPerMonth?, dryRun? }`: make a person a `member`, or a `guest` again, with an optional starter allowance (`usdPerMonth`, 0.01 to 10000, promoting only); planned first (`dryRun` is true unless `false`) \| yes \|
34	34	\| `account_suspend` \| `{ username, suspended }`: suspend a person's account, or unsuspend it with `false`; their sessions and tokens stop at once; the API's rules (not yourself, another admin or an agent; not the only owner of an organization); an admin token \| yes \|
35	35	\| `account_verify` \| `{ username }`: mark a person's email verified, as `POST …/admin/accounts/:username/verify` does; a person admin's, with an admin token \| yes \|
	36	\| `accounts` \| `{ cursor?, limit? }`: the forge's accounts, newest first: `username`, `role`, `verified`, `suspended`, `created`, and `next` (a cursor, or null); `limit` 1-50 (default 20); a person admin's \| \|
36	37	\| `agent` \| `{ action, username, … }`: `create` a crew agent, `update` its `model`, `brief` or `budgetUsd`, or `remove` it; an admin's, with an `admin` token, as `/api/v1/agents` \| yes \|
37	38	\| `app_deploy` \| `{ repo, env, action }`: `redeploy` or `stop` an app's `production` or a pull's `pull-N` preview; a writer's, queued as `POST …/app/:env/redeploy` and `…/stop` are; answers `{ queued, run }` or `{ stopped }` \| yes \|
38	39	\| `app_env` \| `{ repo, action, name?, value?, scope? }`: `list` an app's variable names and scopes, `set` one, or `unset` it, in `all` (default), `production` or `preview`; the API's rules and errors, an admin of the repository with an admin-scope token; a value is never read back \| yes \|
		@@ -0,0 +1,45 @@
	1	import { listAccounts } from "../../../actions/accounts.ts";
	2	import { roleOf } from "../../../core/roles.ts";
	3	import { getUserByName } from "../../../core/users.ts";
	4	import { good, bad, type Tool } from "../shared.ts";
	5
	6	export const tool: Tool = {
	7	name: "accounts",
	8	doc: "`{ cursor?, limit? }`: the forge's accounts, newest first: `username`, `role`, `verified`, `suspended`, `created`, and `next` (a cursor, or null); `limit` 1-50 (default 20); a person admin's",
	9	description: "Accounts, newest first: role, verified, suspended. `cursor` pages.",
	10	inputSchema: {
	11	type: "object",
	12	properties: {
	13	cursor: { type: "string" },
	14	limit: { type: "integer", minimum: 1, maximum: 50 },
	15	},
	16	},
	17	writes: false,
	18	adminOnly: true,
	19	run(ctx, user, args) {
	20	const listed = listAccounts(ctx.app, user);
		sentinelcrew 19d ago Low: `adminOnly` lists the tool to agent admins too, but `listAccounts` refuses them, so an agent admin is shown a tool it can never use. Nothing leaks, since the refusal is correct. Someday a `personAdminOnly` filter in `shared.ts` would close that gap.
	21	if (!listed.ok) return bad("forbidden", "the accounts are a forge admin's to list");
		sentinelcrew 19d ago Low: this is the only line that refuses an agent with `isAdmin`, because `adminOnly` checks only `user.isAdmin`. A test with an admin agent's token, expecting `forbidden`, would pin it.
	22	const given = args["limit"];
	23	if (given !== undefined && (!Number.isInteger(given) \|\| (given as number) < 1 \|\| (given as number) > 50))
	24	return bad("invalid", "limit is a whole number from 1 to 50");
	25	const limit = (given as number \| undefined) ?? 20;
	26	const from = args["cursor"] === undefined ? 0 : Number(args["cursor"]);
		sentinelcrew 19d ago Low: `cursor: ""` reads as offset 0, and a numeric cursor (`5`) also passes although the schema says string. Suggested fix: `typeof args.cursor === "string" && /^\d+$/.test(args.cursor)`, otherwise refuse as invalid.
	27	if (!Number.isInteger(from) \|\| from < 0 \|\| typeof args["cursor"] === "boolean")
	28	return bad("invalid", "that cursor was not issued here");
	29	const page = listed.value.slice(from, from + limit);
	30	const next = from + limit < listed.value.length ? String(from + limit) : null;
	31	return good({
	32	items: page.map((a) => {
	33	const who = getUserByName(ctx.app.db, a.username);
	34	return {
	35	username: a.username,
	36	role: who === undefined ? "guest" : roleOf(ctx.app.db, who),
	37	verified: a.verified,
	38	suspended: a.suspendedAt !== null,
	39	created: a.createdAt,
	40	};
	41	}),
	42	next,
	43	});
	44	},
	45	};
		@@ -6,7 +6,7 @@ export const tool: Tool = {
6	6	name: "app_env",
7	7	doc: "`{ repo, action, name?, value?, scope? }`: `list` an app's variable names and scopes, `set` one, or `unset` it, in `all` (default), `production` or `preview`; the API's rules and errors, an admin of the repository with an admin-scope token; a value is never read back",
8	8	description:
9		"An app's environment variables: list names, set or unset one by scope; values are write-only. Admin.",
	9	"An app's environment variables: list names, set or unset by scope; write-only. Admin.",
10	10	inputSchema: {
11	11	type: "object",
12	12	properties: {
		@@ -6,7 +6,7 @@ export const tool: Tool = {
6	6	name: "archive",
7	7	doc: "`{ repo \| repos, archived?, dryRun? }`: archive (true) or wake (false) a repository, by name; planned first (`dryRun` is true unless `false`); only the repository's admin with an admin token, never an agent. `repos` (at most 50) runs the fleet `archive` operation over them, answers each one's outcome and the `operation` id; `limb` with `action: \"undo\"`, that `operation` and any one of the repositories as `app` reverts it for a day",
8	8	description:
9		"Archive a repository or wake it (`archived` true/false); deletes nothing. Plans first; admin token.",
	9	"Archive or wake a repository (`archived`). Plans first; admin token.",
		sentinelcrew 19d ago Nit: dropping "deletes nothing" loses the one phrase that tells an agent archiving is safe. Same with `app_env`: "values are write-only" became "write-only", which now reads as if the whole tool only writes. If bytes free up later, put both back.
10	10	inputSchema: {
11	11	type: "object",
12	12	properties: {
		@@ -6,7 +6,7 @@ export const tool: Tool = {
6	6	name: "asked",
7	7	doc: "`{ repo?, show?, order? }`: what people asked the crew for, by default nothing merged yet and oldest first: who and when, the pulls that close it, the crew's last activity, waiting/building/shipped/closed, stale when not shipped in three days and flagged when stale with nothing built; repositories you can write",
8	8	description:
9		"What people asked the crew for where you write: by default nothing merged yet, oldest first.",
	9	"What people asked the crew for where you write: by default unmerged, oldest first.",
10	10	inputSchema: {
11	11	type: "object",
12	12	properties: {
		@@ -4,7 +4,7 @@ import { good, bad, type Tool } from "../shared.ts";
4	4	export const tool: Tool = {
5	5	name: "asks_undecide",
6	6	description:
7		"Put a card the decider set aside back on your board, within a day. `id` is from `asks_decide`.",
	7	"Put a set-aside card back on your board, within a day. `id` from `asks_decide`.",
8	8	inputSchema: {
9	9	type: "object",
10	10	properties: { id: { type: "string", maxLength: 80 } },
		@@ -6,7 +6,7 @@ import { good, attachWords, bad, type Tool, str, APP_ARG, planRepo, isAnswer } f
6	6	export const tool: Tool = {
7	7	name: "attach_look",
8	8	description:
9		"Attach a PNG or JPEG (base64 `image`, max 5 MB) to an open pull: `phone` or `desktop`, `says`.",
	9	"Attach a PNG or JPEG (base64 `image`, max 5 MB) to an open pull: `phone`/`desktop`, `says`.",
10	10	inputSchema: {
11	11	type: "object",
12	12	properties: {
		@@ -6,7 +6,7 @@ export const tool: Tool = {
6	6	name: "audit",
7	7	doc: "who can do what, per app, read from its contract.json in git: yes, own or no per door, and whether outsiders may direct its crew (`crewOutsiders`)",
8	8	description:
9		"Who can do what in every app you can see, from each contract.json: resource × verb, yes, own or no.",
	9	"Who can do what in each app you see, from contract.json: resource × verb, yes, own or no.",
10	10	inputSchema: {
11	11	type: "object",
12	12	properties: {
		@@ -5,7 +5,7 @@ export const tool: Tool = {
5	5	name: "board_write",
6	6	doc: "`{ slug, board }` (person admins): write a whole board under a slug, made or replaced: `{ title, range, refresh, panels: [{ title, chart, query, w, h }] }`",
7	7	description:
8		"Write a whole board under a slug: {title, range, refresh, panels: [{title, chart, query, w, h}]}.",
	8	"Write a whole board under a slug: {title, range, refresh, panels}.",
9	9	inputSchema: {
10	10	type: "object",
11	11	properties: {
		@@ -11,7 +11,7 @@ export const tool: Tool = {
11	11	name: "branches",
12	12	doc: "`{ repo, name?, action?, from?, kind? }`: without `name`, lists the branches; `kind: \"tags\"` lists the tags instead (as GET `/api/v1/repos/:owner/:name/tags` does, newest first; no `name` or `action`); with `name` and `action` (`create` from `from`, or `delete`) it does what the branches page does: the default branch is never deleted, only a writer may act",
13	13	description:
14		"A repository's branches; `name` and `action` create (from `from`) or delete one, not the default.",
	14	"A repository's branches; `name`, `action` create (from `from`) or delete one, not the default.",
15	15	inputSchema: {
16	16	type: "object",
17	17	properties: {