Public: anyone can read this; the crew can change it.
.theme-option and .theme-apply leave the stylesheet and docs/DESIGN.md §5d #4806
This deletes the .theme-option and .theme-apply rules from src/web/style/components.ts and takes both names out of the style/components.ts class list in docs/DESIGN.md §5d. The markup had already dropped both classes, and test/web.test.ts checks that they don't come back. Also removed: .tick.
stopped closed without shipping deploy 9ea0f66
Held
holds this, : steward tick: red on its own merge with main (the queue gated it alone and it failed); held so the queue lands the rest - rebase, fix, push, then the hold comes off
No rule sends it to review or lands it until it is released. A person can still ship it.
7 earlier comments
Steward tick: this pull is red on its own merge with current main (gated alone, failed) and was held out of the landing queue so the others can land. Rebase on main, fix the failing test, push - then the hold comes off.
This pull deletes the .theme-option and .theme-apply rules from src/web/style/components.ts and removes those two names from the style/components.ts class list in docs/DESIGN.md §5d. It also removes .tick. The only rule that styled .tick was .theme-option .tick, and no markup uses the class, so design-lint asks for it to come out of §5d. test/web.test.ts already fails if theme-option or theme-apply comes back.
Since the review:
- Merged current main (
0fe073ab) with no conflicts. On the earlier steward hold: the pull's own check passed onc45ddc5bagainst baseaae9cb76, and I couldn't reproduce a failure on the merge with main. After this merge, design-lint and the type check are clean, and the web and design-lint tests pass (56 pass, 0 fail). A broader local run of the design-related tests also passed (67 pass, 0 fail). If the gate still fails, the forge's log will name the test. - Renamed the section comment above
.swatchfrom "theme switcher" to say what it styles: the colour chip beside each theme in the menu's picker..swatchis still used, insrc/web/layout.ts:136.
Thumb-sized rows on a 360px phone: nothing needed changing. Each theme row in the picker is a §5 <label class="check"> inside a fieldset.field. On touch screens .check already gets a 44px minimum height and a 24px radio (src/web/style/components.ts:119-123). The deleted rules didn't size those rows, so removing them doesn't make the rows smaller. I didn't check this on a phone.
To try: open the menu on the preview and pick a theme. The rows look as before, and with JavaScript off, Apply still posts to /theme.
🤖 Generated with Claude Code
Closes #4701
The full gate on land was red; the pull is open again. Red tests:
- the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings
- the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings [1528.60ms] [shard 108]
This pull deletes the .theme-option and .theme-apply rules from src/web/style/components.ts and removes both names from the style/components.ts class list in docs/DESIGN.md §5d. It also removes .tick: the only rule that styled it was .theme-option .tick, no markup uses it, and design-lint asks for it to come out of §5d. test/web.test.ts fails if theme-option or theme-apply comes back. The section comment above .swatch now says what that class styles: the colour chip beside each theme in the menu's picker.
On the red gate (test/pull-timing.test.ts, "the Files page of a 40-file diff… stay under their ceilings"): I see no code change to make. I didn't change the test, and I disagree that this pull caused the failure:
- Nothing in the pull can slow that page. It only deletes CSS rules and one line of docs. The stylesheet is a separate, hashed and cached file loaded with
<link rel="stylesheet">(src/web/layout.ts:628), so the Files page never runs any of the deleted code while it renders. - The test is close to its limit on this machine. On the branch after merging current main (
12fd6fca), it failed once in 9 local runs: the repeat median was 105 ms against a 100 ms ceiling. The other 8 runs passed, and 4 runs of main's own files passed. - The load adjustment can miss contention. The test measures how busy the machine is once, before its eight page views, so a parallel shard that starts during those views isn't accounted for.
I merged current main and pushed so the gate runs again. If the test keeps failing other pulls, it needs its own issue: either measure load next to each view, or leave more margin above the 100 ms repeat ceiling.
On the 360px phone question: each theme row is a §5 <label class="check">. On touch screens .check gets a 44px minimum height and a 24px radio (src/web/style/components.ts:119-123), so the rows stay thumb-sized without any of the removed rules. I didn't check this on a phone.
To try: open the menu on the preview and pick a theme. The rows look as they did before, and with JavaScript off, Apply still posts to /theme.
🤖 Generated with Claude Code
Closes #4701
Steward tick: this pull is red on its own merge with current main (gated alone, failed) and was held out of the landing queue so the others can land. Rebase on main, fix the failing test, push - then the hold comes off.
This pull deletes the .theme-option and .theme-apply rules from src/web/style/components.ts and removes both names from the style/components.ts class list in docs/DESIGN.md §5d. It also removes .tick: the only rule that styled it was .theme-option .tick, no markup uses it, and design-lint asks for it to come out of §5d. test/web.test.ts fails if theme-option or theme-apply comes back. The section comment above .swatch now names the colour chip beside each theme in the menu's picker.
On the steward hold: I didn't change any code for this hold.
- The branch is current with main: it already contains main's head,
12fd6fca, so there was nothing to rebase. - Its own check passed: the check on
93216684, run against base12fd6fca, passed (277 s). The hold came 11 minutes later and doesn't name the test that failed, and I can't read the gated run's log. - The likely cause is the timing test from the last report: the Files-page test in
test/pull-timing.test.ts. Its stylesheet argument still holds: the CSS is a separate cached asset (src/web/layout.ts:628), so nothing deleted here runs during that page's render. - Local results: design-lint is clean, and
bun test test/design-lint.test.ts test/web.test.ts test/pull-timing.test.tspasses (59 pass, 0 fail).
I left that test unchanged because it guards #4215's 100 ms bar, and loosening it belongs in its own change, not a CSS cleanup. I opened #5000 for it. The test measures how busy the machine is once, before its eight page views, so load that starts partway through isn't accounted for. If the gate's log names a different test, send it and I'll fix that.
To try: open the menu on the preview and pick a theme. The rows look as they did before. On a phone they keep §5 .check's 44px touch target, and with JavaScript off, Apply still posts to /theme.
🤖 Generated with Claude Code
Closes #4701
Declined: already done on main in be351e09 Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5wfwn5168tg06s85aaf90w1 Left open: someone has spoken on this pull.
Closed by the crew: superseded, its change is already on main in be351e09.
This deletes the
.theme-optionand.theme-applyrules fromsrc/web/style/components.tsand takes both names out of thestyle/components.tsclass list in docs/DESIGN.md §5d. The markup had already dropped both classes, andtest/web.test.tschecks that they don't come back.Also removed:
.tick. It is the one thing deleted beyond what the issue lists. The only rule that styled it was.theme-option .tick, and no markup uses the class anywhere. Once that rule went,bun scripts/design-lint.tsfailed with ".tick: no stylesheet defines it any more — strike it from docs/DESIGN.md §5d", so it comes out of §5d as well.Left alone:
.swatchstays, with its "theme switcher" section comment above it.docs/design/baseline.jsonneeded no change: it names none of these classes.Checks:
grep -rn 'theme-option\|theme-apply' src/finds nothing.bun scripts/design-lint.tsis clean.bun test test/design-lint.test.ts test/web.test.ts: 56 pass, 0 fail.grep -n '^<<<<<<<\|^>>>>>>>' src/web/stylefinds no conflict markers.🤖 Generated with Claude Code
Closes #4701