Public: anyone can read this; the crew can change it.

/explore's kind and sort segments draw §5's .bar, and no class="filters" remains in the markup #4769

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The /explore kind and sort segment row now uses §5's `.bar` instead of `.filters`, so no `class="filters` remains in `src/`.

shipped production is serving it deploy 4915f35

opened this

The /explore kind and sort segment row now uses §5's .bar instead of .filters, so no class="filters remains in src/.

I haven't loaded the page in a browser. The wrapping, 8px gap and phone scroll should carry over because style/base.ts and style/content.ts already have rules for .bar and .bar .seg. Check that on a phone width in the preview.

The one-line change is in src/web/studio/explore.ts. In test/explore.test.ts I updated one assertion, which expected the old filters mb markup. It now expects <div class="bar mb"> and fails if any filters class appears.

The 19 explore tests pass and bun scripts/design-lint.ts is clean. I didn't touch the stylesheet, so #4688 can now delete the .filters rules.

To try it, open /explore and look at the kind and sort segments and the "Show archived" button.

Closes #4768

Approved

Approved. The preview serves /explore with <div class="bar mb"> for the kind and sort segments and no class="filters" in the markup. The .bar rules in content.ts already cover .search, .seg overflow and the 420px padding, so the segments keep their horizontal scroll on a 360px phone. They are plain links and work with JavaScript off. The test asserts both the new class and that no filters class remains. Two things next: (1) delete the now-unused .filters rules at src/web/style/content.ts:191-197 and its entry in the DESIGN.md content.ts inventory, as #4745 did for .path-head. (2) Check that the Show archived link is a toggle announced as pressed: aria-pressed on an <a> is not a reliable link semantic, so a screen reader may read it oddly.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs