Public: anyone can read this; the crew can change it.

.clone and .clone-text leave the stylesheet and docs/DESIGN.md §5d #4761

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The `.clone` and `.clone-text` rules are gone from the stylesheet and from docs/DESIGN.md §5d. No markup in `src/` used either class any more, so the page should look the same.

shipped production is serving it deploy 4915f35

masoncrew opened this 23d ago

The .clone and .clone-text rules are gone from the stylesheet and from docs/DESIGN.md §5d. No markup in src/ used either class any more, so the page should look the same.

src/web/style/components.ts: removed the whole "clone strip" block (.clone, .clone > .clone-text and its scrollbar rule). The toast rule .toast code, .toast .clone { … } is now just .toast code { … }.
docs/DESIGN.md §5d: took .clone and .clone-text out of the class list for style/components.ts. Nothing else in the file changed.
docs/design/baseline.json: left alone, because neither class appears in it.

Checks:

Searching src/ for .clone and clone-text finds no class uses. What it still finds is unrelated, such as response.clone() and git.clone(...) calls and the clone-https copy-field ids.
bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts passes (15 tests).
The branch is rebased on current main, and grep -rn '^<<<<<<<\|^>>>>>>>' src/web/style finds no conflict markers.

To try it, open any repository page and check that the About rail's clone address still renders the same.

🤖 Generated with Claude Code

Closes #4705

masoncrew commented 23d ago

The .clone and .clone-text rules are gone from the stylesheet and from docs/DESIGN.md §5d. No markup in src/ used either class any more, so the page should look the same.

src/web/style/components.ts: removed the whole "clone strip" block (.clone, .clone > .clone-text and its scrollbar rule). The toast rule .toast code, .toast .clone { … } is now just .toast code { … }.
docs/DESIGN.md §5d: took .clone and .clone-text out of the class list for style/components.ts. Nothing else in the file changed.
docs/design/baseline.json: left alone, because neither class appears in it.

Checks:

Searching src/ for .clone and clone-text finds no class uses. What it still finds is unrelated, such as response.clone() and git.clone(...) calls and the clone-https copy-field ids.
bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts passes (15 tests).
The branch is rebased on current main, and grep -rn '^<<<<<<<\|^>>>>>>>' src/web/style finds no conflict markers.

To try it, open any repository page and check that the About rail's clone address still renders the same.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Approved. I searched src/ for class uses of clone and clone-text, in markup, template strings and client scripts. The only hits left are the removed CSS rules and unrelated code (response.clone(), git.clone, a keyword list). So the removal changes no rendering. The preview answers 200 and its HTML has no clone class. The DESIGN.md §5d list matches the stylesheet, and the toast rule is correctly cut down to .toast code. Two things I would do next: (1) add a lint check that every class named in DESIGN.md §5 is defined in the stylesheet, so the docs and CSS cannot drift apart again; (2) look for other dead classes in components.ts in the same way.