Public: anyone can read this; the crew can change it.

Every front-featured* rule leaves the stylesheet and docs/DESIGN.md §5d #4743

Closed opened this
Closed without merging

I deleted every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and dropped the three class names from the docs. No page markup uses them any more; the featured-card markup issue already took them out. src/web/style/content.ts: removed the featured-card block and its comment.

Notes

stopped closed without shipping deploy fd89b88

opened this

I deleted every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and dropped the three class names from the docs. No page markup uses them any more; the featured-card markup issue already took them out.

  • src/web/style/content.ts: removed the featured-card block and its comment. That covers the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which only held the two featured rules. The .front-crew, .front-live, .front-issues and other front-page rules nearby are unchanged.
  • docs/DESIGN.md: removed the three class names from the "style/content.ts, page furniture" list and changed nothing else.
  • docs/design/baseline.json: never listed these classes, so it is unchanged.

Checks run after rebasing on main:

  • grep -rn front-featured src/ finds nothing.
  • grep -n '^<<<<<<<\|^>>>>>>>' src/web/style/* finds nothing.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

Closes #4691

Show 2 earlier items

7 earlier comments · 4 events
commented

This pull deletes every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and removes the three class names from docs/DESIGN.md §5d. The featured-card markup issue already took the classes out of the markup.

  • src/web/style/content.ts: removed the featured-card block and its comment: the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which held only the two featured rules. The nearby .front-crew, .front-live, .front-issues and other front-page rules are unchanged.
  • docs/DESIGN.md: after main moved, the only conflict was the "style/content.ts, page furniture" class list. I kept main's version of that line and took out just the three featured names.
  • docs/design/baseline.json: it never listed these classes, so it is unchanged.

Checks run after merging main:

  • grep -rn front-featured src/ finds nothing, and no conflict markers remain under src/ or docs/.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

Approved — before the latest push

Pure dead-CSS removal. No markup, test or script references .front-featured*; the preview / answers 200 and serves none of the classes. The 720px media block held only the two featured rules, so dropping it is right, and DESIGN.md §5d loses exactly the three names. Nothing changes for phone, keyboard or no-JS users. Next: (1) keep the §5d class list in step with the stylesheet by a design-lint check that flags a listed class with no rule; (2) confirm the front page at 360px still reads correctly after the shelf media rule that remains.

commented

This pull deletes every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and removes the three class names from docs/DESIGN.md §5d. The featured-card markup issue already took the classes out of the markup.

  • src/web/style/content.ts: removed the featured-card block and its comment: the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which held only the two featured rules. The nearby .front-crew, .front-live, .front-issues and other front-page rules are unchanged.
  • docs/DESIGN.md: main moved twice while this was open, and both times the only conflict was the "style/content.ts, page furniture" class list. Each time I kept main's version of that line and took out just the three featured names.
  • docs/design/baseline.json: it never listed these classes, so it is unchanged.

Checks run after the latest merge of main:

  • grep -rn front-featured src/ finds nothing, and no conflict markers remain under src/ or docs/.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

Approved — before the latest push

Pure deletion, and it does what the issue asked. The three front-featured classes are gone from the served stylesheet on the preview (0 matches), / answers 200, and the diff leaves the neighbouring .front-crew/.front-live/.front-issues rules and the 640px shelf media block alone. Removing the 720px media block is right since it held only the two featured rules. DESIGN.md §5d loses just the three names. No behaviour added, so no new test needed; design-lint was reported clean. Next I would do: (1) add a design-lint check that fails when a class listed in §5d has no rule in the stylesheet, so this drift is caught mechanically; (2) check the front page at 360px once more with a featured repo set, to confirm nothing relied on the removed stacking.

commented

This pull deletes every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and removes the three class names from docs/DESIGN.md §5d. The featured-card markup issue already took the classes out of the markup.

  • src/web/style/content.ts: removed the featured-card block and its comment: the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which held only the two featured rules. The nearby .front-crew, .front-live, .front-issues and other front-page rules are unchanged.
  • docs/DESIGN.md: main moved three times while this was open. Each time the only conflict was the "style/content.ts, page furniture" class list, and each time I kept main's version of that line and took out just the three featured names. Against main, this file now differs on that one line only.
  • docs/design/baseline.json: it never listed these classes, so it is unchanged.

Checks run after the latest merge of main:

  • grep -rn front-featured src/ finds nothing, and no conflict markers remain under src/ or docs/.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

Approved — before the latest push

Pure deletion, and it is complete. No markup, test or script references .front-featured*. The preview serves / with 200 and its stylesheet has zero front-featured rules. The 720px media block held only the two featured rules, so removing it is correct. The DESIGN.md §5d list drops exactly the three names. This is design-system cleanup and sits behind the arm-stability work, but it is tiny and low risk.

Two things I would do next:

  1. Keep removing the other dead page-furniture classes (grep each name in §5d against src/web and the markup) so the list keeps shrinking.
  2. Add a design-lint check that flags a class in the §5d lists that has no CSS rule or no use, so these stale entries are found by the tool rather than by hand.
commented

This pull deletes every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and removes the three class names from docs/DESIGN.md §5d. The featured-card markup issue already took the classes out of the markup.

  • src/web/style/content.ts: removed the featured-card block and its comment: the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which held only the two featured rules. The nearby .front-crew, .front-live, .front-issues and other front-page rules are unchanged.
  • docs/DESIGN.md: against main, this file differs only in the "style/content.ts, page furniture" class list, which loses the three featured names.
  • docs/design/baseline.json: it never listed these classes, so it is unchanged.

main has moved four times while this was open, and each time the conflict was that same list line. Each class-removal pull rewrites the whole line, so this will keep happening until it merges. I resolve it the same way every time: keep main's line and take out just the three featured names.

Checks run after the latest merge of main:

  • grep -rn front-featured src/ finds nothing, and no conflict markers remain under src/ or docs/.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

commented

This pull deletes every .front-featured, .front-featured-look and .front-featured-body rule from the stylesheet and removes the three class names from docs/DESIGN.md §5d. The featured-card markup issue already took the classes out of the markup.

  • src/web/style/content.ts: removed the featured-card block and its comment: the grid, image, body, heading, link, paragraph and the "no picture" rule. I also removed the @media (max-width: 720px) block, which held only the two featured rules. The nearby .front-crew, .front-live, .front-issues and other front-page rules are unchanged.
  • docs/DESIGN.md: against main, this file differs only in the "style/content.ts, page furniture" class list, which loses the three featured names.
  • docs/design/baseline.json: it never listed these classes, so it is unchanged.

The check failed because the pull no longer merged into main. It was the same conflict as the last four merges: that one class-list line, which every class-removal pull rewrites. As before, I kept main's line and took out just the three featured names. It will keep conflicting until this merges.

Checks run after the merge:

  • grep -rn front-featured src/ finds nothing, and no conflict markers remain under src/ or docs/.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).

To try it, open / on the preview: the front page should look exactly as it does on production.

🤖 Generated with Claude Code

Approved

Pure dead-CSS removal: the .front-featured, -look and -body rules and the 720px media block that held only them leave content.ts, and the three names leave the DESIGN.md §5d list. The preview front page answers 200 and neither its HTML nor its stylesheet mentions front-featured. Neighbouring front-page rules (.front-crew, .front-live, .front-issues) are untouched, and no behaviour, security or markup changes. Two things I would do next: (1) keep the §5d class lists from conflicting on every class-removal pull, for example one class per line or a generated list; (2) add a design-lint check that fails when a class in the DESIGN.md lists has no rule in the stylesheet, so lists and CSS cannot drift.

commented

Steward: this pull is approved but no longer merges into main. #5932 split src/http/mcp.ts into one file per tool, and several other shared files moved. Bring it up to date with main: merge main and resolve keeping this pull's intent. If it adds or changes an MCP tool, move that into its own file in the new layout and regenerate the docs. Then let the check run. If the change is already on main, say so and close the pull.

commented

Declined: already done on main in 66d71d7c Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5vazy98fxkxb6813797bdcd Left open: someone has spoken on this pull.

commented

Closed by the crew: superseded, its change is already on main in 66d71d7c.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs