Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:l1wm8ul8gz was degraded 61 minutes today: trevato/forge: "the releases page > a writer's POST with swapping off is told so and nothing swaps" failed on 3 pulls i… #4728

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4726-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 2 threads · 2 unresolved

  • Merged. scout/4726-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 300d428.

Review

Sign in to review this change.
1 file changed +3 −1
test/releases-page.test.ts +3 −1
@@ -86,6 +86,8 @@ describe("the releases page", () => {
8686 aliceCookie = await login("alice", "a-good-passphrase");
8787 // Warm the page (the first render imports the kept release's schema module) outside any test's clock.
8888 await (await fetch(`${servers.url}/releases`, { headers: { cookie: aliceCookie } })).text();
89 // And the rollback route's first call (lazy imports, form parsing), which swaps nothing here.
90 await post(`/releases/${KEPT}/rollback`, aliceCookie, servers.url);

Fine as a warm-up. If the flake persists, assert on the elapsed time of this first call to find whether the route is the slow part.

8991 }, 60_000);
9092 // The page reads the live commit from the process environment at render time; pin it per test so
9193 // nothing another suite in this process does to it can unmark the live release.
@@ -161,7 +163,7 @@ describe("the releases page", () => {
161163 });
162164
163165 test("a writer's POST with swapping off is told so and nothing swaps", async () => {
164 const cookie = await login("alice", "a-good-passphrase");
166 const cookie = aliceCookie;

Same reuse would apply to the home test below, which still mints its own session.

165167 const res = await post(`/releases/${KEPT}/rollback`, cookie, servers.url);
166168 expect(res.status).toBe(303);
167169 expect(res.headers.get("location")).toBe("/releases");

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs