Public: anyone can read this; the crew can change it.

A commit's head and body draw §5 components on the commit and report pages #4723

Parked opened this
Closed without merging

The commit and report pages now draw their head and message body with §5 components, and the leftover design-lint failure is cleared. I ran the design lint, test/design-lint.test.ts and test/commit-page-timing.test.ts, and all pass.

Notes

stopped parked by the crew deploy 1486a67

opened this

The commit and report pages now draw their head and message body with §5 components, and the leftover design-lint failure is cleared. I ran the design lint, test/design-lint.test.ts and test/commit-page-timing.test.ts, and all pass. I did not run the whole suite, and bun x tsc --noEmit printed nothing in the one run that executed it, which was before the final edit.

  • Already on the branch: The pull #4648 attempt had already pushed the code change. src/web/pages/commits.ts and src/web/pages/reports.ts draw the head with card-head and the message body with .prose[data-text="message"]. No commit-head or commit-body class is left in src. The test in test/commit-page-timing.test.ts fetches a commit page, asserts those two classes are gone and that the card-head is present, and checks that the body wraps.
  • What this push adds: The one remaining failure was in bun test test/design-lint.test.ts. docs/DESIGN.md §5d still listed .commit-body and .commit-head, which no stylesheet defines any more. I struck them. I also struck .wall-cells, which was failing the same lint and is not from this change. Without that, the test stays red. The diff is one line in docs/DESIGN.md.
  • Left out: I didn't touch the tests the issue says are planned separately. I didn't add a screenshot, so the "looks the same by eye" item is not covered. docs/design/baseline.json needed no change.
  • Check by hand: Open any commit page on the preview and confirm the head and message look as before.

Closes #4585

2 earlier comments · 1 event
commented

The commit and report pages now draw their head and message body with §5 components, and the leftover design-lint failure is cleared. I ran the design lint, test/design-lint.test.ts and test/commit-page-timing.test.ts, and all pass. I did not run the whole suite, and bun x tsc --noEmit printed nothing in the one run that executed it, which was before the final edit.

  • Already on the branch: The pull #4648 attempt had already pushed the code change. src/web/pages/commits.ts and src/web/pages/reports.ts draw the head with card-head and the message body with .prose[data-text="message"]. No commit-head or commit-body class is left in src. The test in test/commit-page-timing.test.ts fetches a commit page, asserts those two classes are gone and that the card-head is present, and checks that the body wraps.
  • What this push adds: The one remaining failure was in bun test test/design-lint.test.ts. docs/DESIGN.md §5d still listed .commit-body and .commit-head, which no stylesheet defines any more. I struck them. I also struck .wall-cells, which was failing the same lint and is not from this change. Without that, the test stays red. The diff is one line in docs/DESIGN.md.
  • Left out: I didn't touch the tests the issue says are planned separately. I didn't add a screenshot, so the "looks the same by eye" item is not covered. docs/design/baseline.json needed no change.
  • Check by hand: Open any commit page on the preview and confirm the head and message look as before.
the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

This pull changes one line in docs/DESIGN.md §5d. It strikes .commit-body, .commit-head and .wall-cells, because no stylesheet defines them any more and the design lint flagged them.

I couldn't find the failure the check reported. The log tail you sent shows only passing tests (283 pass, 0 fail in that shard), so the failing test was cut off. The branch has nothing new to push; git push says everything is up to date. The branch's upstream shows as "gone" in git status, so I can't confirm the forge has the latest commit. Here is what I ran locally:

  • bun x tsc --noEmit printed nothing.
  • bun scripts/design-lint.ts reports no colour, size or component added outside the system.
  • bun test test/design-lint.test.ts test/commit-page-timing.test.ts gives 19 pass, 0 fail.

I did not run the whole suite. If the next check fails again, please send the log from the failing test, not the end of the run.

The code change from the earlier #4648 attempt is already on the branch. src/web/pages/commits.ts and src/web/pages/reports.ts draw the head with card-head and the message body with .prose[data-text="message"]. test/commit-page-timing.test.ts asserts that those classes are used and the old ones are gone.

I didn't touch the tests the issue says are planned separately, and I didn't add a screenshot. To check by hand, open any commit page on the preview and confirm the head and message look as before.

Closes #4585

commented

Closed by the crew: main moved under it 2 times and the branch could not be brought up to date. Conflicting files: docs/DESIGN.md.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs