Public: anyone can read this; the crew can change it.

.origin-row, .origin-name, .origin-mark and .mirror-form leave the stylesheet #4722

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull removes the leftover stylesheet rules for `.origin-row`, `.origin-name`, `.origin-mark` and `.mirror-form`. No markup under `src/` uses these classes any more. Compared with `main`, only the two files the issue names change:

shipped production is serving it deploy 119f4d2

masoncrew opened this 23d ago

This pull removes the leftover stylesheet rules for .origin-row, .origin-name, .origin-mark and .mirror-form. No markup under src/ uses these classes any more. Compared with main, only the two files the issue names change:

src/web/style/content.ts: the three .origin-* rules, their "The origins settings page." comment, and the two .mirror-form rules are deleted.
docs/DESIGN.md §5d: the four names are taken out of the "page furniture" list for style/content.ts.

Why the previous pull went red: #4652 failed with "does not merge into main: docs/DESIGN.md", not on a test. While it was open, main removed .wall-cells from the same §5d line, so the two edits conflicted. This branch now merges current main, and that line is main's version with the four names removed.

Not changed: test/web-origins.test.ts still contains the four names at lines 341 and 367. Both are checks that the classes are absent from the origins card and the repos page, which is the form the issue asks for, so I left them as they are. docs/design/baseline.json has no entries, so there was no count to lower.

Checks run: bun scripts/design-lint.ts passes, and bun test test/design-lint.test.ts test/web-origins.test.ts passes (45 tests, none failing).

To try it: open /settings/origins and /settings/origins/<id>/repos on the preview; both should look the same as on production.

🤖 Generated with Claude Code

Closes #4599

masoncrew commented 23d ago

src/web/style/content.ts: the three .origin-* rules, their "The origins settings page." comment, and the two .mirror-form rules are deleted.
docs/DESIGN.md §5d: the four names are taken out of the "page furniture" list for style/content.ts.

Checks run: bun scripts/design-lint.ts passes, and bun test test/design-lint.test.ts test/web-origins.test.ts passes (45 tests, none failing).

To try it: open /settings/origins and /settings/origins/<id>/repos on the preview; both should look the same as on production.

🤖 Generated with Claude Code

Closes #4599

masoncrew commented 23d ago

This pull removes .origin-row, .origin-name, .origin-mark and .mirror-form from src/web/style/content.ts, along with their entries in the "page furniture" list in docs/DESIGN.md. The markup no longer uses any of these four classes (#4599), so how pages look and behave doesn't change.

Merge with main: the only conflict was that same "page furniture" line in docs/DESIGN.md. main had removed .stage-detail and .stage-dot from it (#4637), and this branch had removed the origin and mirror classes. The merged line keeps both removals; nothing else in the list changed.

Checks: after the merge, bun scripts/design-lint.ts passes, bun x tsc --noEmit is clean, and 90 tests pass with none failing (the design-audit, design-lint, design-map, origins, web-origins, web-origin-link and snapshot-mirror-page suites). No test was changed.

To try it: on the preview, open a repository's origins and mirror pages. They should look the same as on production.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

Dead CSS removal only. grep finds no use of .origin-row/.origin-name/.origin-mark/.mirror-form in src (only the absence checks in test/web-origins.test.ts), design-lint passes, and DESIGN.md §5d drops exactly those four names. No behaviour or look changes. Next: (1) keep sweeping the remaining unused names in the §5d lists the same way; (2) consider a test that fails when a DESIGN.md-listed class has no CSS rule or use, so these cannot linger.

masoncrew commented 23d ago

main is merged into the branch again; the pull still only takes out the .origin-row, .origin-name, .origin-mark and .mirror-form rules. The origins settings page draws these with §5's components instead.

The conflicts were in src/web/style/content.ts and docs/DESIGN.md. In both files, each side had deleted lines right next to the other side's deletions, and the merge keeps both. In the stylesheet, this branch's .mirror-form rules go, and so do the .steps rules that main removed in #4638. In DESIGN.md's page-furniture list, main's line is the base, so its removals from #4638 and #4713 (.steps, .dl-review, .rc-*) stay; the four classes this branch retires are then taken out of that line.

Compared with main, the pull now changes two things: four lines from the content stylesheet and four names from the DESIGN.md class inventory.

The design lint and the type check pass. 88 tests across seven suites also pass: the design audit, lint and map tests, the origins and web-origins tests, and the review-design test. The full suite was not run here; the forge's check runs it on this push.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

No markup under src/ uses .origin-row, .origin-name, .origin-mark or .mirror-form (only test/web-origins.test.ts mentions them, as absence checks, which is right). The change removes exactly those rules and their §5d inventory names, adds no dependency and no code path, and the preview answers. Two next steps: (1) keep the absence regex in test/web-origins.test.ts as the guard against the classes returning; (2) run the design audit over the other classes in the page-furniture list to find the next unused ones, since that list is meant only to shrink.

masoncrew commented 23d ago

This pull removes the .origin-row, .origin-name, .origin-mark and .mirror-form rules from src/web/style/content.ts. The origins settings page draws them with §5's components instead.

main is merged in again. The only conflict was the page-furniture line in docs/DESIGN.md: main had taken .path-head off it, and this branch had taken off its four classes. The merged line uses main's version minus this branch's four classes, so both removals stand.

Compared with main, the pull now changes two things: four rules removed from the content stylesheet and the four matching class names removed from the DESIGN.md list.

The design lint and the type check pass. 83 tests across the design-audit, design-lint, design-map, web-origins and origins suites also pass. The full suite was not run here; the forge's check runs it on this push.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

Approved. No markup under src/ uses .origin-row, .origin-name, .origin-mark or .mirror-form. The only hits on the base are the rules this pull deletes. The §5d inventory drops the same four names, and the preview answers 200. Nothing visual or behavioural changes, so no security, tty or test impact. Next: (1) keep test/web-origins.test.ts as the guard that the classes stay absent; (2) keep scanning content.ts for other dead rules, in the same small pulls.

masoncrew commented 23d ago

This pull removes the .origin-row, .origin-name, .origin-mark and .mirror-form rules from src/web/style/content.ts. The origins settings page draws them with §5's components instead.

main is merged in again. The only conflict was the page-furniture line in docs/DESIGN.md, which main had edited again. The merged line is main's version minus this branch's four classes. Comparing it with main's line shows only those four names differ.

Compared with main, the pull still changes two things: four rules removed from the content stylesheet and the four matching class names removed from the DESIGN.md list.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Pure dead-CSS removal. grep finds no src/ markup using .origin-row, .origin-name, .origin-mark or .mirror-form; the only hits are the rules and DESIGN.md names this pull deletes. DESIGN.md §5d is updated to match, no markup or behaviour changes, and the preview answers 200. No security, tty or dependency surface is touched. Next: (1) keep the web-origins absence checks so the classes cannot creep back; (2) continue the stylesheet inventory sweep with small pulls, behind the arm-stability work.