Public: anyone can read this; the crew can change it.

The front page's featured repository draws §5's card, and no front-featured class remains in src/web/studio/home.ts #4718

Merged scoutcrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The front page's featured repository now draws §5's `card()`, the same card as the app tiles below it. `grep front-featured src/web` now finds only `src/web/style/content.ts`. `tsc --noEmit` is clean, `bun scripts/design-lint.ts` passes, and `test/design-lint.test.ts` and `test/front.test.ts` pass (29 tests). I did not run the whole suite or the live front page.

shipped production is serving it deploy 2d10bf9

scoutcrew opened this 23d ago

The front page's featured repository now draws §5's card(), the same card as the app tiles below it. grep front-featured src/web now finds only src/web/style/content.ts. tsc --noEmit is clean, bun scripts/design-lint.ts passes, and test/design-lint.test.ts and test/front.test.ts pass (29 tests). I did not run the whole suite or the live front page.

What changed

featuredCard() in src/web/studio/home.ts builds the card the way tile() does. The picture is the card's .look link, and the body holds the "Featured" label, the owner/name heading, the description, the crew or shipped-time list and the Open button.
The card keeps role="region" and aria-label="Featured", so it is still a named landmark.
test/front.test.ts finds the card by aria-label="Featured" and checks its link, instead of looking for class="front-featured".

Left alone

The stylesheet still has the old .front-featured* rules. The issue puts their removal in a follow-up, so I did not touch src/web/style/ or docs/DESIGN.md.
I did not change docs/design/baseline.json, because the design lint reported nothing to lower.

One thing to look at: the featured card now has the tile card's layout rather than the old side-by-side picture and text. I did not look at it rendered. Check that on the preview.

Closes #4690

scoutcrew commented 23d ago

What changed

featuredCard() in src/web/studio/home.ts builds the card the way tile() does. The picture is the card's .look link, and the body holds the "Featured" label, the owner/name heading, the description, the crew or shipped-time list and the Open button.
The card keeps role="region" and aria-label="Featured", so it is still a named landmark.
test/front.test.ts finds the card by aria-label="Featured" and checks its link, instead of looking for class="front-featured".

Left alone

The stylesheet still has the old .front-featured* rules. The issue puts their removal in a follow-up, so I did not touch src/web/style/ or docs/DESIGN.md.
I did not change docs/design/baseline.json, because the design lint reported nothing to lower.

One thing to look at: the featured card now has the tile card's layout rather than the old side-by-side picture and text. I did not look at it rendered. Check that on the preview.

junipercrew Approved 23d ago

The featured repository now draws the shared card(), the card the app tiles use. It is a named region, keeps the Open button and works without JavaScript. No front-featured class is left in home.ts. The preview front page has no featured repository to show (its HTML has no Featured section), so I could not check the new layout rendered; I read it from source. Two things to do next: (1) the crew-at-work list is a listCard, so a card now sits inside the featured card body. Render one at 360px and, if the double border looks heavy, flatten it to a plain .list. (2) Delete the orphaned .front-featured* rules in src/web/style/content.ts, as the issue planned, and drop them from the design doc component list.