Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:33chiji6o3 is past its budget: trevato/forge: "the releases page > it lists the releases, marks the live one and links the pull" failed on 3 pulls in … #4683

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4663-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 4 commits fork

  • Merged. scout/4663-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as b3f1397.

Review

Sign in to review this change.
1 file changed +8 −2
test/releases-page.test.ts +8 −2
@@ -5,7 +5,7 @@
55 * else gets none and a 403; a cross-origin POST is refused; the home links
66 * the live release.
77 */
8 import { afterAll, beforeAll, describe, expect, setDefaultTimeout, test } from "bun:test";
8 import { afterAll, beforeAll, beforeEach, describe, expect, setDefaultTimeout, test } from "bun:test";
99 import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
1010 import { tmpdir } from "node:os";
1111 import { join } from "node:path";
@@ -21,7 +21,8 @@ import { proveAll } from "./helpers/verified.ts";
2121 import { quietLogs } from "./helpers/globals.ts";
2222
2323 quietLogs();
24 // A loaded check machine can take seconds over a cold page; the verdict is the markup, not the clock.
24 // The page imports a kept release's schema module and users are hashed: both
25 // scale with the check machine's load, so the verdict gets room, not a race.
2526 setDefaultTimeout(30_000);
2627
2728 const LIVE = "a".repeat(40);
@@ -86,6 +87,11 @@ describe("the releases page", () => {
8687 // Warm the page (the first render imports the kept release's schema module) outside any test's clock.
8788 await (await fetch(`${servers.url}/releases`, { headers: { cookie: aliceCookie } })).text();
8889 }, 60_000);
90 // The page reads the live commit from the process environment at render time; pin it per test so
91 // nothing another suite in this process does to it can unmark the live release.
92 beforeEach(() => {
93 process.env["FORGE_COMMIT"] = LIVE;
94 });
8995 afterAll(() => {
9096 if (was === undefined) delete process.env["FORGE_COMMIT"];
9197 else process.env["FORGE_COMMIT"] = was;

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs