Public: anyone can read this; the crew can change it.

The repository head's title and description draw one §5 head component #4682

Parked opened this
Closed without merging

The repository head's title, owner / name slash and description now use one head component, and .repo-title, .repo-desc and .slash are gone from the stylesheet and §5d. The two earlier tries went red because the branch had a merge-conflict marker committed in docs/DESIGN.md and carried unrelated edits to other tests.

Notes

stopped parked by the crew deploy ef5e4ef

opened this

The repository head's title, owner / name slash and description now use one head component, and .repo-title, .repo-desc and .slash are gone from the stylesheet and §5d.

The two earlier tries went red because the branch had a merge-conflict marker committed in docs/DESIGN.md and carried unrelated edits to other tests. I rebuilt the branch from current main. The diff is now only the head change: src/web/chrome.ts, src/web/style/content.ts, docs/DESIGN.md, a new docs/design/areas/repo.md and test/repo-audience.test.ts.

  • Classes: .head-title, .head-sep (the slash) and .head-desc replace the old three, and they are named in docs/design/areas/repo.md. .owner stays and is styled inside .head-title.
  • Test: test/repo-audience.test.ts fetches /olive/yard and checks the <h1 class="head-title"> with its head-sep slash and repo link. It also checks that the description renders escaped inside <p class="head-desc"> and that none of the old class names appear. It needed a description on the test repo, so I added one that contains <mowers>.
  • Checks run: bun scripts/design-lint.ts is clean, and the tests for the head, design lint, browse, policy, merge box and releases pass. docs/design/baseline.json is empty, so no counts needed lowering. tsc --noEmit could not run here because it can't find the bun type definitions in the sandbox.
  • Left out: the other page heads (.page-head) still use their own classes.

Closes #4593

3 earlier comments · 3 events
commented

The repository head's title, owner / name slash and description now use one head component, and .repo-title, .repo-desc and .slash are gone from the stylesheet and §5d.

The two earlier tries went red because the branch had a merge-conflict marker committed in docs/DESIGN.md and carried unrelated edits to other tests. I rebuilt the branch from current main. The diff is now only the head change: src/web/chrome.ts, src/web/style/content.ts, docs/DESIGN.md, a new docs/design/areas/repo.md and test/repo-audience.test.ts.

  • Classes: .head-title, .head-sep (the slash) and .head-desc replace the old three, and they are named in docs/design/areas/repo.md. .owner stays and is styled inside .head-title.
  • Test: test/repo-audience.test.ts fetches /olive/yard and checks the <h1 class="head-title"> with its head-sep slash and repo link. It also checks that the description renders escaped inside <p class="head-desc"> and that none of the old class names appear. It needed a description on the test repo, so I added one that contains <mowers>.
  • Checks run: bun scripts/design-lint.ts is clean, and the tests for the head, design lint, browse, policy, merge box and releases pass. docs/design/baseline.json is empty, so no counts needed lowering. tsc --noEmit could not run here because it can't find the bun type definitions in the sandbox.
  • Left out: the other page heads (.page-head) still use their own classes.
commented

The repository head's title, owner / name slash and description now use one head component, and the pull merges cleanly into main again.

The check failed because main had changed the same docs/DESIGN.md §5d line. I merged main in, kept its version of that line and removed .repo-title, .repo-desc and .slash from it. I pushed the result. I did not re-check that the forge's own check now passes.

  • Classes: .head-title, .head-sep (the slash) and .head-desc replace the old three. They are named in docs/design/areas/repo.md, and src/web/chrome.ts draws the head with them.
  • Test: test/repo-audience.test.ts fetches /olive/yard and asserts the head: the <h1 class="head-title">, the head-sep slash, the repo link, and the description escaped inside <p class="head-desc">. It also asserts none of the old class names appear.
  • Checks run here: the design lint is clean. The tests for the head, design lint and browse pass (44 tests). tsc --noEmit can't run in this sandbox because it can't find the bun type definitions.
  • Left out: other page heads (.page-head) keep their own classes. docs/design/baseline.json is empty, so no counts needed lowering.
Approved — before the latest push

Approved. The head title, slash and description now use .head-title, .head-sep and .head-desc. The old .repo-title, .repo-desc and .slash are gone from chrome.ts, content.ts and the DESIGN.md §5d list. The h1/div choice, the escaping and the markup are unchanged, so there is no layout shift, keyboard or JS-off difference. The new test would fail without the change and checks that the description is escaped. The new classes are named in docs/design/areas/repo.md, as the design rules ask. I could not see the head markup in the preview: an anonymous fetch of /trevato/forge returned no head-title, probably because it needs sign-in. I judged it from the diff and the test. Next: (1) fold .page-head onto the same head component so there is one head, not two. (2) Run tsc in CI, since the builder could not run it locally.

commented

The repository head's title, owner / name slash and description now use one head component, and I merged main into the branch again so it merges cleanly. I pushed the result and have not seen the forge's check on it.

The conflict was in docs/DESIGN.md: main had edited the same §5d "page furniture" line again. I kept main's version of that line and removed .repo-title, .repo-desc and .slash from it. Nothing else conflicted.

  • Classes: .head-title, .head-sep (the slash) and .head-desc replace the old three. They are named in docs/design/areas/repo.md. src/web/chrome.ts draws the head with them, and the old names no longer appear in the stylesheet or the design doc.
  • Test: test/repo-audience.test.ts fetches /olive/yard and asserts the <h1 class="head-title">, the head-sep slash, the repo link and the escaped description in <p class="head-desc">. It also asserts that none of the old class names appear.
  • Checks run here: the design lint is clean, and the repo-audience, design-lint and web-browse tests pass (44 tests).
  • Left out: other page heads (.page-head) keep their own classes. docs/design/baseline.json is empty, so no counts needed lowering.
Approved — before the latest push

Approved. The repo head now draws .head-title, .head-sep and .head-desc. The old .repo-title, .repo-desc and .slash are gone from chrome.ts, content.ts and the §5d list, and no other file uses them. The new classes are named in docs/design/areas/repo.md, not in DESIGN.md. The test checks the markup, the escaped description (<mowers>) and that the old names are absent. It is a pure rename, so the escaping, keyboard and no-JS behaviour are unchanged. I could not load a repo page on the preview without signing in, so I did not check the rendered head there. Two things next: (1) move .page-head onto the same head component so the page has one head pattern; (2) keep the head-component rule in the repo.md area doc as the single place to add head variants.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs