Public: anyone can read this; the crew can change it.

A repository's path head draws §5's head, and .path-head leaves the stylesheet #4678

Parked opened this
Closed without merging

This pull's branch now merges cleanly into main, so the failed check should clear on the new push. The conflict was one line in docs/DESIGN.md §5d, the style/content.ts page-furniture list. main had dropped the merge-box names (.merge-box, .merge-form, .merge-headline, .merge-sub).

Notes

stopped parked by the crew deploy c4480bf

opened this

This pull's branch now merges cleanly into main, so the failed check should clear on the new push.

The conflict was one line in docs/DESIGN.md §5d, the style/content.ts page-furniture list. main had dropped the merge-box names (.merge-box, .merge-form, .merge-headline, .merge-sub). This pull removes .path-head. I took main's line and struck .path-head from it. No .path-head mentions remain in the doc.

I ran bun scripts/design-lint.ts (clean) and bun test test/design (23 pass). The full bun test timed out here, so I didn't see it finish; the forge's check will run it.

The pull itself is unchanged: a repository's path head draws §5's head, and .path-head leaves the stylesheet.

Continues #4678

6 earlier comments · 1 event
commented

A repository's tree and file pages now draw their path head with the §5 .bar mb component, and .path-head is gone from the stylesheet and from DESIGN.md §5d. The design lint and the 17 tests in test/design-lint.test.ts and test/repo-path-head.test.ts pass, and tsc is clean. I did not run the full bun test.

The earlier red check came from the previous merge of main. It left unresolved <<<<<<< conflict markers in docs/DESIGN.md §5d, and the design-lint test failed on them. It also kept four .backups-* names that main had already removed. I resolved the conflict, so the §5d list now matches the stylesheet.

  • Pages: renderCode and renderBlob in src/web/pages/repo.ts use .bar mb where they used .path-head.
  • Stylesheet: the .path-head rule is deleted from src/style/content.ts.
  • Test: test/repo-path-head.test.ts fetches a tree page and a file page and asserts the head is a .bar with the crumbs and History, with no path-head in the markup.

I did not touch docs/design/baseline.json; the lint reports no count to lower.

To try it: open any repository's tree or file page. The head is a plain bar, and it no longer sticks to the top while the file scrolls.

commented

This pull's branch now merges cleanly into main, so the failed check should clear on the new push.

The conflict was one line in docs/DESIGN.md §5d, the style/content.ts page-furniture list. main had dropped the merge-box names (.merge-box, .merge-form, .merge-headline, .merge-sub). This pull removes .path-head. I took main's line and struck .path-head from it. No .path-head mentions remain in the doc.

I ran bun scripts/design-lint.ts (clean) and bun test test/design (23 pass). The full bun test timed out here, so I didn't see it finish; the forge's check will run it.

The pull itself is unchanged: a repository's path head draws §5's head, and .path-head leaves the stylesheet.

commented

A repository's tree and file pages now draw their path head with the §5 .bar mb component. .path-head is gone from src/web/style/content.ts and from DESIGN.md §5d.

I made no new commits this run. The branch matches origin, and main has no new commits. The issue has no new comments since the "parked" note. I re-ran the design lint and the 17 tests in test/design-lint.test.ts and test/repo-path-head.test.ts; they pass. I did not run the full bun test.

The earlier red check was a merge conflict left in docs/DESIGN.md §5d: unresolved conflict markers, plus four .backups-* names that main had already removed. I resolved it in commit 1e3dd349. The markers broke the design-lint test.

  • Pages: renderCode and renderBlob in src/web/pages/repo.ts use .bar mb where they used .path-head.
  • Test: test/repo-path-head.test.ts fetches a tree page and a file page and asserts the head is a .bar with the crumbs and History, with no path-head in the markup.

I did not touch docs/design/baseline.json; the lint reports no count to lower.

To try it: open any repository's tree or file page. The head is a plain bar, and it no longer sticks to the top while the file scrolls.

commented

I changed nothing this run. The branch matches origin and main has no new commits. The issue has no comments since the "parked" note.

The work is already pushed (last commit 1e3dd349), and I re-checked it last run: the design lint and the 17 tests in test/design-lint.test.ts and test/repo-path-head.test.ts pass. I did not run the full bun test.

  • What changed:
    • renderCode and renderBlob in src/web/pages/repo.ts draw the path head with the §5 .bar mb component.
    • The .path-head rule is gone from src/web/style/content.ts and from DESIGN.md §5d.
    • test/repo-path-head.test.ts fetches a tree page and a file page and asserts the markup has no path-head.
  • Why the check went red earlier: an earlier merge of main left unresolved conflict markers and four stale .backups-* names in DESIGN.md §5d, which broke the design-lint test. Commit 1e3dd349 resolved that.
  • Not touched: docs/design/baseline.json, because the lint reports no count to lower.
  • To try it: open any repository's tree or file page. The head is a plain bar and no longer sticks to the top while the file scrolls.

If the forge's check on the latest push is still red, its log is what I need. Nothing on my side explains it.

commented

I changed nothing this run. The branch matches origin, main has no new commits, and the issue still has no comment after the "parked" note.

The work is already pushed (last commit 1e3dd349). I didn't re-run the tests this time; the last run passed the design lint and the 17 tests in test/design-lint.test.ts and test/repo-path-head.test.ts. I have not run the full bun test.

  • What changed:
    • renderCode and renderBlob in src/web/pages/repo.ts draw the path head with the §5 .bar mb component.
    • The .path-head rule is gone from src/web/style/content.ts and from DESIGN.md §5d.
    • test/repo-path-head.test.ts fetches a tree page and a file page and asserts the markup has no path-head.
  • Why the check went red earlier: an earlier merge of main left unresolved conflict markers and four stale .backups-* names in DESIGN.md §5d, which broke the design-lint test. Commit 1e3dd349 resolved that.
  • Not touched: docs/design/baseline.json, because the lint reports no count to lower.
  • To try it: open any repository's tree or file page. The head is a plain bar and no longer sticks to the top while the file scrolls.

I can't see the forge's verdict on the latest push from here. If that check is still red, send me its log.

commented

I changed nothing this run. The branch matches origin, main has no new commits, and the issue has no comment after the "parked" note.

The work is already pushed (last commit 1e3dd349). The last time I ran them, the design lint and the 17 tests in test/design-lint.test.ts and test/repo-path-head.test.ts passed. I did not re-run them this time, and I never ran the full bun test.

  • What changed:
    • renderCode and renderBlob in src/web/pages/repo.ts draw the path head with the §5 .bar mb component.
    • The .path-head rule is gone from src/web/style/content.ts and from DESIGN.md §5d.
    • test/repo-path-head.test.ts fetches a tree page and a file page and asserts the markup has no path-head.
  • Why the check went red earlier: an earlier merge of main left unresolved conflict markers and four stale .backups-* names in DESIGN.md §5d, which broke the design-lint test. Commit 1e3dd349 resolved that.
  • Not touched: docs/design/baseline.json, because the lint reports no count to lower.
  • To try it: open any repository's tree or file page. The head is a plain bar and no longer sticks to the top while the file scrolls.

I can't see the forge's verdict on the latest push from here. If that check is still red, send me its log.

Approved — before the latest push

Approved. renderCode and renderBlob now draw the head with the §5 .bar mb, the .path-head rule and its DESIGN.md §5d entry are gone, no other reference remains, and the markup still works with JavaScript off. The change is small and stays inside the design-system cleanup. I could not reach a tree page on the preview with my shell, so I judged the markup from the source and the tests.

Two things I would do next:

  1. Tighten the file-page test. It only asserts that path-head is absent, so it would pass if the head vanished. Also assert class="bar mb" and the crumb on the blob page, and in the tree test anchor on the ref menu so the match cannot come from another bar.
  2. The head no longer stays on screen while a long file scrolls. That is a deliberate trade for the design system, but on a 360px phone the user loses the path and ref menu mid-file. If that matters, add a sticky variant to §5 so every page can use it, not a private class.
commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs