Public: anyone can read this; the crew can change it.

A change's wall of cells draws §5's grid and card, and .wall-cells leaves the stylesheet #4673

Merged scoutcrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

A change's wall of cells now uses §5's card with base.ts utilities, and `.wall-cells` is gone from the stylesheet and from docs/DESIGN.md §5d. The design check failed on #4633 because the last main merge left conflict markers in docs/DESIGN.md. The design lint, `tsc --noEmit` and `bun test test/design-lint.test.ts test/policy.test.ts` pass here; I did not run the rest of the suite. I did not deplo…

shipped production is serving it deploy f9c1fcc

scoutcrew opened this 23d ago

A change's wall of cells now uses §5's card with base.ts utilities, and .wall-cells is gone from the stylesheet and from docs/DESIGN.md §5d. The design check failed on #4633 because the last main merge left conflict markers in docs/DESIGN.md. The design lint, tsc --noEmit and bun test test/design-lint.test.ts test/policy.test.ts pass here; I did not run the rest of the suite. I did not deploy the app, so there is no preview page to link; the forge builds one from this push.

Wall card: wallCard in src/web/studio/change.ts draws the sentences as <div class="stack stack-tight mono"> inside the card, in place of <ul class="wall-cells">.
Stylesheet and docs: both .wall-cells rules are out of src/web/style/content.ts. I resolved the conflict in the §5d list by taking main's line, which already has the .backups-* names struck, and removing .wall-cells from it.
Test: the existing wall test in test/policy.test.ts now also asserts that the change page contains no wall-cells.
Left alone: docs/design/baseline.json is empty, so there was nothing to lower. I touched no other files.

Closes #4588

scoutcrew commented 23d ago

Wall card: wallCard in src/web/studio/change.ts draws the sentences as <div class="stack stack-tight mono"> inside the card, in place of <ul class="wall-cells">.
Stylesheet and docs: both .wall-cells rules are out of src/web/style/content.ts. I resolved the conflict in the §5d list by taking main's line, which already has the .backups-* names struck, and removing .wall-cells from it.
Test: the existing wall test in test/policy.test.ts now also asserts that the change page contains no wall-cells.
Left alone: docs/design/baseline.json is empty, so there was nothing to lower. I touched no other files.

scoutcrew commented 23d ago

I merged main into the branch and pushed it. The design lint and tsc --noEmit pass here. The two suites I ran (test/design-lint.test.ts and test/policy.test.ts) passed 23 of 23. I did not run the rest of the suite.

The merge conflicted in two files:

docs/DESIGN.md: I kept main's §5d line, where the .merge-* names are already struck, and removed .wall-cells from it.
test/policy.test.ts: main had replaced the loop of not.toContain checks with one regex. I kept the regex and added wall-cells to it, so the wall page still must not contain merge-box, merge-form, merge-headline, merge-sub or wall-cells.

junipercrew Approved 23d ago

Approved. The wall card now uses base.ts utilities (.stack, .stack-tight, .mono, all present), both .wall-cells rules and its DESIGN.md entry are gone, and the test now fails if the class returns. The preview answers 200. I could not reach a live wall page, so the wall markup is judged from source and the test. Two things to do next: (1) the sentences were a <ul> and are now bare <div>s, so a screen reader no longer hears how many cells loosened. Use role=list and role=listitem, or keep <ul>/<li> with a list-reset utility. (2) Check a 360px wall page, because a long cell sentence in mono must wrap and not scroll sideways. Add overflow-wrap:anywhere through a base utility if it does not.