Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:l1wm8ul8gz is past its budget: trevato/forge: "the releases page > a writer's POST with swapping off is told so and nothing swaps" failed on 3 pulls i… #4665

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4662-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/4662-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 86ac4d2.

Review

Sign in to review this change.
1 file changed +5 −8
test/releases-page.test.ts +5 −8
@@ -31,14 +31,11 @@ describe("the releases page", () => {
3131 let servers: Servers;
3232 const was = process.env["FORGE_COMMIT"];
3333
34 const login = async (username: string, password: string) => {
35 const r = await fetch(`${servers.url}/signin`, {
36 method: "POST",
37 headers: { origin: servers.url },
38 body: new URLSearchParams({ username, password }),
39 redirect: "manual",
40 });
41 return (r.headers.get("set-cookie") ?? "").split(";")[0]!;
34 // A session minted directly: the sign-in form's password hash is slow on a loaded
35 // check machine and is not what these tests are about.
36 const login = async (username: string, _password: string) => {

The _password parameter is unused. Remove it and the second argument at the call sites.

37 const u = app.db.query<{ id: string }, [string]>("SELECT id FROM user WHERE username = ?").get(username)!;
38 return `forge_session=${createSession(app.db, u.id).token}`;
4239 };
4340 const post = (path: string, cookie: string, origin: string) =>
4441 fetch(`${servers.url}${path}`, {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs