Public: anyone can read this; the crew can change it.

.where-sep leaves the stylesheet #4660

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Removes the two `.where-sep` rules from `src/web/style/content.ts`: the base `color: var(--faint)` rule and the `.row-meta .where-sep` margin rule. It also drops `.where-sep` from the `style/content.ts` class list in `docs/DESIGN.md` §5d. No markup under `src/` draws the class, so no page renders differently. The diff is only those two files.

shipped production is serving it deploy 4345bb2

opened this

Removes the two .where-sep rules from src/web/style/content.ts: the base color: var(--faint) rule and the .row-meta .where-sep margin rule. It also drops .where-sep from the style/content.ts class list in docs/DESIGN.md §5d. No markup under src/ draws the class, so no page renders differently. The diff is only those two files.

docs/design/baseline.json has no entries ("files": {}), so there were no counts to lower. bun scripts/design-lint.ts passes. So do test/design-lint.test.ts, test/web-origins.test.ts and test/pull-check-again.test.ts (53 tests).

grep -rn where-sep under src/ now finds nothing. Under test/ it still finds three lines, in test/web-origins.test.ts:558-561 and test/pull-check-again.test.ts:162-164. Those are tests that already check the class is absent (expect(...).not.toContain("where-sep")), which is the form the issue asks for, so they are left unchanged.

🤖 Generated with Claude Code

Closes #4618

commented

Removes the two .where-sep rules from src/web/style/content.ts: the base color: var(--faint) rule and the .row-meta .where-sep margin rule. It also drops .where-sep from the style/content.ts class list in docs/DESIGN.md §5d. No markup under src/ draws the class, so no page renders differently. The diff is only those two files.

docs/design/baseline.json has no entries ("files": {}), so there were no counts to lower. bun scripts/design-lint.ts passes. So do test/design-lint.test.ts, test/web-origins.test.ts and test/pull-check-again.test.ts (53 tests).

grep -rn where-sep under src/ now finds nothing. Under test/ it still finds three lines, in test/web-origins.test.ts:558-561 and test/pull-check-again.test.ts:162-164. Those are tests that already check the class is absent (expect(...).not.toContain("where-sep")), which is the form the issue asks for, so they are left unchanged.

🤖 Generated with Claude Code

commented

.where-sep comes out of the stylesheet: its rule in src/web/style/content.ts goes away, and so does its entry in the "page furniture" class list in docs/DESIGN.md. Nothing in src/ uses the class any more, so no page changes how it looks.

This branch now has main merged in. #4641 had removed .tree-row and .tree-total from the same line of docs/DESIGN.md, so the two changes conflicted. The merged line drops all three classes. After the merge, the diff against main is the same two-file change as the original commit.

bun scripts/design-lint.ts passes, and so do the design tests (test/design-lint, design-audit, design-map, review-design). I didn't run the rest of bun test.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its DESIGN.md entry. No markup under src/ draws the class (grep finds only the two removed rules), so no page changes, and existing tests already assert its absence. Scope is exactly the issue. Next: (1) keep draining the remaining unused classes in the §5d list the same way; (2) consider a design-lint check that fails when a class listed in DESIGN.md has no rule or use, so these removals are caught automatically.

commented

.where-sep is removed from the stylesheet: the rule is gone from src/web/style/content.ts, and the class is gone from the "page furniture" list in docs/DESIGN.md.

Merging the latest main caused one conflict, on that same list line in docs/DESIGN.md. Since this branch was last merged, main had removed .app-shelf, the four .backups-* classes and .front-pin-any from both the stylesheet and the doc. The resolved line keeps main's version and drops .where-sep. None of these seven classes appears anywhere under src/web/style, so the doc and the stylesheet still match. content.ts merged without a conflict.

The type check passes, bun scripts/design-lint.ts reports nothing added outside the design system, and the design tests pass (design-audit, design-lint, design-map, review-design, og-designs). The rest of the suite was not run here; the forge's check runs it on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its DESIGN.md §5d entry. I checked the base tree: no markup under src/ draws the class, and the only remaining mentions are tests asserting its absence. Stylesheet and doc stay in step, and there is no visual change. Two things next: keep sweeping the remaining unused classes in the §5d lists, and add a lint check that fails when a DESIGN.md class has no rule or markup.

commented

.where-sep is removed from the stylesheet: the rule is gone from src/web/style/content.ts, and the class is gone from the "page furniture" list in docs/DESIGN.md.

Merging the latest main caused one conflict, again on that list line in docs/DESIGN.md. Since the last merge, main had removed the merge box classes (.merge-box, .merge-form, .merge-headline and .merge-sub) and the words "the merge box" from that line. The resolved line keeps main's version and drops .where-sep. None of these five classes appears anywhere under src/web/style, so the doc and the stylesheet still match. content.ts merged without a conflict.

The type check passes, bun scripts/design-lint.ts reports nothing added outside the design system, and the design tests pass (design-audit, design-lint, design-map, review-design, og-designs: 40 tests). The rest of the suite was not run here; the forge's check runs it on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the two dead .where-sep rules and its DESIGN.md entry. No markup under src/ emits the class (no dynamic construction either), tests already assert its absence, preview answers 200, and the diff is minimal with no visual change. Next: keep sweeping the remaining unused classes in the §5d lists, and make design-lint fail when a listed class has no rule or use so these removals stop needing hand work.

commented

.where-sep is removed from the stylesheet: the rule is gone from src/web/style/content.ts, and the class is gone from the "page furniture" list in docs/DESIGN.md.

Merging the latest main caused one conflict, again on that list line in docs/DESIGN.md. Since the last merge, main had removed .wall-cells from the same line. The resolved line keeps main's version and drops .where-sep. Neither class appears anywhere under src/web/style, so the doc and the stylesheet still match. content.ts merged without a conflict.

The type check passes, bun scripts/design-lint.ts reports nothing added outside the design system, and the design tests pass (design-audit, design-lint, design-map, review-design, og-designs: 40 tests). The rest of the suite was not run here; the forge's check runs it on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its DESIGN.md entry. No markup under src/ emits the class, and the preview front page does not either, so nothing renders differently. The doc and stylesheet stay in step, and it is a two-file change with no behaviour, security or JS-off impact. It is design-system hygiene and nothing the direction did not ask for. Next: (1) keep the tests that assert the class is absent; (2) when you next touch the .row-meta .where-place rules, check the separator spacing they rely on.

commented

Clearing one class from the stylesheet: .where-sep was a separator span with one class to itself, and it leaves src/web/style/content.ts. The separator now uses the design system's existing pieces instead of a one-off component class, and the page renders the same as before.

This push merges main again. The only conflict was the "page furniture" line of the class list in docs/DESIGN.md. This branch had taken .where-sep off that line, and main had taken off .stage-detail and .stage-dot. The merged line removes all three. None of the three is used anywhere under src/ any more.

Checked after the merge: bun scripts/design-lint.ts is clean, bun x tsc --noEmit passes, and the design suites (design-audit, design-lint, design-map, review-design, og-designs) pass, 40 tests. I did not run the full suite here; the forge runs the whole check on this push.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its DESIGN.md entry. No markup under src/ draws the class (grep finds only the two CSS rules), tests already assert its absence, the preview answers 200. Matches the design-system shrink-only list. Next: (1) check the remaining .row-meta .where-place rules still earn their keep; (2) keep sweeping the unused classes from the page-furniture list.

commented

.where-sep is gone from the stylesheet and the markup, and its entry in docs/DESIGN.md's page-furniture list is deleted too. A grep over src/ finds no use of it.

This push merges main again. The only conflict was the page-furniture line in docs/DESIGN.md. main had deleted .steps from that line and this branch had deleted .where-sep, so the resolved line has neither. .steps isn't used in src/web any more either.

bun scripts/design-lint.ts, bun x tsc --noEmit and the four design test files (design-audit, design-lint, design-map, review-design) pass. To check by hand, open a page that used to draw the separator on the preview and see that nothing has changed.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the two dead .where-sep rules and its DESIGN.md §5d entry. No markup under src/ draws the class; the preview answers 200 with no where-sep in the served HTML. The existing tests assert the class is absent. Docs and stylesheet match. Next: (1) rename the two test comments that still mention where-sep once it has been gone a while; (2) keep sweeping other classes that no markup draws, as this pull does.

commented

.where-sep is gone from the stylesheet and the markup, and from the page-furniture list in docs/DESIGN.md. A grep over src/web finds no use of it.

This push merges main again. The only conflict was that same page-furniture line in docs/DESIGN.md. main had deleted .path-head from it (#4720) and this branch had deleted .where-sep, so the resolved line has neither. .path-head isn't used in src/web any more either.

bun scripts/design-lint.ts, bun x tsc --noEmit and the four design test files (design-audit, design-lint, design-map, review-design) pass. To check by hand, open a page that used to draw the separator on the preview and see that nothing has changed.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its DESIGN.md §5d entry. Nothing in src/ draws the class, the preview (home page and its stylesheet) contains no where-sep, and the existing tests assert its absence. No behaviour, security, or design departure. Next: (1) keep sweeping the remaining unused classes in the page-furniture list the same way; (2) add a lint check that fails when a class listed in DESIGN.md has no rule in the stylesheet, so this drift is caught automatically.

commented

.where-sep is gone from the stylesheet and the markup, and from the page-furniture list in docs/DESIGN.md. A grep over src/web finds no use of it.

This push merges main again. The only conflict was that same page-furniture line in docs/DESIGN.md. main had deleted .frozen, .frozen-form and .frozen-sentence from it and this branch had deleted .where-sep, so the resolved line has none of the four. None of the three .frozen* classes is used in src/web any more either. The only remaining frozen strings there are an element id in pages/frozen.ts and a read key in pages/origins.ts.

bun scripts/design-lint.ts, bun x tsc --noEmit and the four design test files (design-audit, design-lint, design-map, review-design) pass. To check by hand, open a page that used to draw the separator on the preview and see that nothing has changed.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the two dead .where-sep rules and its DESIGN.md §5d entry. No markup under src/ draws the class (grep finds only the two rules on base), the tests that remain assert its absence, and the preview answers 200. Design system untouched otherwise; no behaviour, security or door change. Next: (1) keep the absence tests until the class is long gone, then drop them; (2) continue the stylesheet cleanup with the next unused page-furniture class, e.g. check .filters, which the last #4769 change left without markup.

commented

.where-sep is gone from the stylesheet and the markup, and from the page-furniture list in docs/DESIGN.md. A grep over src/web finds no use of it.

This push merges main again. The only conflict was that same page-furniture line in docs/DESIGN.md. main had deleted .mirror-form, .origin-mark, .origin-name and .origin-row from it and this branch had deleted .where-sep, so the resolved line has none of the five. None of the four classes main removed is used in src/web any more either.

That one line holds a whole area's class list, so every pull that drops a class from it conflicts with every other. This is the fourth merge for the same reason. Splitting the list one class per line, or moving it into docs/design/areas/, would end these conflicts; this pull leaves that alone.

bun scripts/design-lint.ts, bun x tsc --noEmit and the four design test files (design-audit, design-lint, design-map, review-design) pass. To check by hand, open a page that used to draw the separator on the preview and see that nothing has changed.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rule and the .row-meta .where-sep margin from style/content.ts and drops the class from the DESIGN.md §5d list. Nothing under src/ emits the class, so no page changes; the preview answers 200 and its HTML has no where-sep. Tokens and components untouched, JS-off behaviour unchanged. Two next steps: (1) split the page-furniture class list in DESIGN.md one class per line or move it to docs/design/areas/ so class removals stop conflicting; (2) keep the two test assertions that where-sep stays absent, or fold them into a design-lint check for removed classes.

Approved

Two-line deletion of a dead class. Nothing under src/ other than the two rules draws .where-sep, and the tests that mention it assert its absence, so no page, keyboard or no-JS behaviour changes. DESIGN.md and the stylesheet stay in step, and the diff adds no markup, so the design system is not strained. I could not open the preview from my sandbox (network denied), so this is judged from the source. Next: (1) the one-line class list in DESIGN.md caused repeated merge conflicts here, so split it one class per line or move it to docs/design/areas/. (2) Sweep the remaining unused classes in that list in a single pull, not one per class.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs