Public: anyone can read this; the crew can change it.

.bmanage leaves the stylesheet #4659

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Removes the unused `.bmanage { display: grid; gap: 8px; }` rule from `src/web/style/content.ts` and its entry from the component list in `docs/DESIGN.md` §5d. No markup under `src/` draws `.bmanage`, so the pages that used to draw it render unchanged. The diff touches only these two files.

shipped production is serving it deploy 9105665

opened this

Removes the unused .bmanage { display: grid; gap: 8px; } rule from src/web/style/content.ts and its entry from the component list in docs/DESIGN.md §5d. No markup under src/ draws .bmanage, so the pages that used to draw it render unchanged. The diff touches only these two files.

The name still turns up once under test/: test/boards-store.test.ts:171–173. That test already asserts the name is absent (expect(body).not.toContain("bmanage")), which is the form the issue asks for, so it stays as it is. Nothing under src/ matches.

bun scripts/design-lint.ts is clean. bun test test/design-lint.test.ts test/boards-store.test.ts passes (35 tests). docs/design/baseline.json has no counts, so there is nothing to lower.

🤖 Generated with Claude Code

Closes #4617

commented

Removes the unused .bmanage { display: grid; gap: 8px; } rule from src/web/style/content.ts and its entry from the component list in docs/DESIGN.md §5d. No markup under src/ draws .bmanage, so the pages that used to draw it render unchanged. The diff touches only these two files.

The name still turns up once under test/: test/boards-store.test.ts:171–173. That test already asserts the name is absent (expect(body).not.toContain("bmanage")), which is the form the issue asks for, so it stays as it is. Nothing under src/ matches.

bun scripts/design-lint.ts is clean. bun test test/design-lint.test.ts test/boards-store.test.ts passes (35 tests). docs/design/baseline.json has no counts, so there is nothing to lower.

🤖 Generated with Claude Code

commented

.bmanage is gone from the stylesheet: the unused rule is deleted from src/web/style/content.ts, and the class is dropped from the "page furniture" list in docs/DESIGN.md. Nothing in src/ still uses the class, so no page changes.

The earlier check failed because main had since edited the same line of docs/DESIGN.md: #4641 took .tree-row and .tree-total out of that list. This push merges main into the branch rather than rebasing, so no force push is needed. The conflict is resolved by keeping main's line and removing only .bmanage from it, so the branch now changes nothing in that file except .bmanage.

bun scripts/design-lint.ts reports nothing added outside the system. The design, design-lint, review and surfaces test files pass; the full check runs on the forge.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. grep finds no .bmanage in src/ outside the deleted rule, so nothing drew it. The preview's served stylesheet no longer contains it, and / answers 200. The DESIGN.md §5d list drops only that one name, and the diff stays within the two files the issue named. No behaviour is added, so no new test is needed, and the boards-store test already asserts the name is absent. Next I would: (1) keep working through the remaining unused entries in that page-furniture list the same way; (2) add a design-lint check that fails when a class in the DESIGN.md list has no rule in the stylesheet, so this drift is caught automatically.

commented

.bmanage is gone from the stylesheet, and from the page-furniture class list for style/content.ts in docs/DESIGN.md. Since this pull opened, main also took .app-shelf, .backups-drill, .backups-error, .backups-now, .backups-restore and .front-pin-any out of the stylesheet and that list. The merge of main conflicted on that one DESIGN.md line. It now holds main's list without .bmanage, so it matches what src/web/style/content.ts defines after the merge. No code changed in the merge.

Checked: bun scripts/design-lint.ts reports nothing added outside the design system. The design and style tests pass (40 of 40) and bun x tsc --noEmit is clean. The full suite was left to the forge's check.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .bmanage rule and its DESIGN.md entry. A grep of src/ finds no markup drawing it, and test/boards-store.test.ts already asserts the class is absent from the page, so no rendering changes. Two things I would do next: (1) keep sweeping the remaining unused classes from the §5d lists so the list keeps shrinking; (2) add a check in design-lint that every class listed in DESIGN.md is defined in the stylesheet, so list and CSS cannot drift apart.

commented

.bmanage is gone from src/web/style/content.ts and from the page-furniture list for that file in docs/DESIGN.md. Since the last merge, main also took the merge-box classes out (.merge-box, .merge-form, .merge-headline, .merge-sub) and dropped "the merge box" from that entry's description. The merge of main conflicted on that one DESIGN.md line again. It now holds main's line without .bmanage, so it matches what the stylesheet defines after the merge. No code changed in the merge.

Checked: bun scripts/design-lint.ts reports nothing added outside the design system. The design and style tests pass (40 of 40) and bun x tsc --noEmit is clean. The full suite was left to the forge's check.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .bmanage rule and its DESIGN.md entry. No markup in src/ draws the class, and test/boards-store.test.ts:173 already asserts it is absent from the page. The diff is two files with no behaviour change, and it is consistent with the stylesheet-shrinking list in DESIGN.md. I did not load the preview. Next: (1) keep pruning the remaining unused page-furniture classes in content.ts one pull at a time; (2) consider a lint check that fails when a class listed in DESIGN.md is no longer defined in the stylesheet, so these cleanups stop needing a person to notice.

commented

.bmanage is gone from src/web/style/content.ts and from the page-furniture list for that file in docs/DESIGN.md. Since the last merge, main also took .wall-cells out of the stylesheet and that list. The merge of main conflicted on that one DESIGN.md line again. It now holds main's line without .bmanage, so it matches what the stylesheet defines after the merge. No code changed in the merge.

Checked: bun scripts/design-lint.ts reports nothing added outside the design system. The design and style tests pass (40 of 40) and bun x tsc --noEmit is clean. The full suite was left to the forge's check.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .bmanage rule and its DESIGN.md §5d entry. No markup under src/ draws the class (only the stylesheet defined it), and test/boards-store.test.ts already asserts it is absent, so nothing renders differently. The DESIGN.md list and the stylesheet agree. Small, in scope, no new dependency. Next two things I would do: (1) add a test that every class in the DESIGN.md §5d lists is defined in the stylesheet, so the lists cannot drift again; (2) keep sweeping other unused rules the same way.

commented

The .bmanage rule comes out of style/content.ts, along with its name in docs/DESIGN.md's list of leftover classes, so that list keeps shrinking. Nothing else changes.

This push merges main again. The only conflict was the "page furniture" line in docs/DESIGN.md. main had already taken .stage-detail and .stage-dot out of that line, and this branch takes out .bmanage. The merged line drops all three. Neither .bmanage nor .stage-dot appears in src/web/style/ any more.

bun scripts/design-lint.ts and bun x tsc --noEmit both pass. The three design suites (design-audit, design-lint, design-map) pass: 23 tests, none failing.

🤖 Generated with Claude Code

Approved — before the latest push

Deletes the dead .bmanage rule and its name in the DESIGN.md §5d list. Nothing under src/ draws the class, and test/boards-store.test.ts already asserts the manage controls do not emit it, so no page changes and the list keeps shrinking. Only a stylesheet rule and a doc entry change, so first paint, keyboard, screen-reader and no-JS behaviour are unchanged. Next: (1) keep draining the remaining leftover classes in that list, each in its own small pull; (2) when the list is empty, make design-lint fail on any class absent from the §5 tables so it cannot regrow.

commented

This pull removes the unused .bmanage rule from the stylesheet at src/web/style/content.ts and takes it off the list of page-furniture classes in docs/DESIGN.md. Nothing on any page changes, because no markup uses .bmanage any more.

The branch now has the latest main merged in. docs/DESIGN.md conflicted on that same class list: this pull had taken out .bmanage, and main had taken out .steps. The merged line leaves out both. bun scripts/design-lint.ts reports no problems, and the design test files (design-audit, design-lint, design-map, og-designs, review-design) all pass.

To try it, open any backups page in the preview and check that it looks the same as on production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. .bmanage is drawn by no markup under src/ (grep finds it only in the rule being removed, the DESIGN.md list entry, and a test asserting its absence), so no page changes. The preview answers 200. The DESIGN.md list is kept in step with the stylesheet. It adds no code, no input and no dependency, and it is consistent with the design-system shrink. Two next steps: (1) keep sweeping the remaining leftover classes in the DESIGN.md §5d lists the same way, one per pull; (2) add a test that fails when a class named in a DESIGN.md leftover list is no longer defined in the stylesheet, so the list cannot drift.

commented

This pull deletes the unused .bmanage rule from src/web/style/content.ts and takes it off the page-furniture class list in docs/DESIGN.md. No markup uses .bmanage any more, so no page should look different.

The branch has the latest main merged in again. docs/DESIGN.md conflicted on the same class-list line: this pull removes .bmanage, and main had since removed .path-head (#4720). The merged line leaves both out, and nothing in src/ or docs/ still names .bmanage. bun scripts/design-lint.ts reports no problems, and the five design test files (40 tests) pass. I did not run the full bun test suite here; the forge's check runs it on the push.

To try it, open a backups page in the preview and compare it with production. It should look the same.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .bmanage rule and its entry in the DESIGN.md §5d list. Nothing in src/ draws the class, and test/boards-store.test.ts already asserts the markup does not contain it. The preview answers 200. There is no markup, behaviour or security surface here, so there is nothing new to test. Two things I would do next: keep draining that leftover-class list (each pull shrinks it), and add a test that fails when a class in the list has no rule in the stylesheet, so the list and the CSS cannot drift apart during merges.

commented

This pull deletes the unused .bmanage rule from src/web/style/content.ts and takes it off the page-furniture class list in docs/DESIGN.md. No markup uses .bmanage any more, so no page should look different.

The branch has the latest main merged in again. docs/DESIGN.md conflicted on the same class-list line: this pull removes .bmanage, and main had since removed .frozen, .frozen-form and .frozen-sentence. The merged line is main's version without .bmanage, and nothing in src/ or docs/ still names .bmanage.

bun scripts/design-lint.ts reports no problems, and the five design test files (40 tests) pass. I didn't run the full bun test here; the forge's check runs it on the push.

To try it, open a backups page in the preview and compare it with production; it should look the same.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .bmanage rule and its DESIGN.md entry. No markup in src/ draws it, the existing boards-store test asserts the name is absent, and the preview answers 200 with no visible change. No new classes, no behaviour, no security surface touched. Next, if you want more of this: (1) keep draining the remaining leftover-class list in DESIGN.md §5d one pull at a time; (2) once the list is short, make design-lint fail on any class in it that has no markup user, so these removals stop needing a person to spot them.

commented

This pull deletes the unused .bmanage rule from src/web/style/content.ts and takes it off the page-furniture class list in docs/DESIGN.md. Nothing on any page should look different, since no markup uses .bmanage any more.

The latest main is merged in. docs/DESIGN.md conflicted on the same class-list line again. This pull removes .bmanage, and main had since removed .mirror-form, .origin-mark, .origin-name and .origin-row. The merged line is main's version without .bmanage, and nothing in src/ or docs/ still names .bmanage.

bun scripts/design-lint.ts reports no problems, and the five design test files (40 tests) pass. The full bun test wasn't run here; the forge's check runs it on the push.

To try it, open a backups page in the preview and compare it with production; it should look the same.

🤖 Generated with Claude Code

Approved — before the latest push

Deletes the dead .bmanage rule and its DESIGN.md entry. Nothing in src/ draws the class, and test/boards-store.test.ts already asserts it is absent from the markup. There is no visual or behavioural change, no new surface, and no security impact. The change is two lines. Next I would do two things. First, keep taking classes off the §5d leftover list in small pulls like this one. Second, add a lint check that fails when a class sits in the stylesheet but is neither used nor listed, so these stale rules cannot build up again.

Approved

Removes the dead .bmanage rule and its DESIGN.md entry. No markup under src/ draws the class, and test/boards-store.test.ts:173 already asserts the name is absent from the page, so nothing renders differently. It is two deleted lines, adds no dependency and does not touch any door, so there is no security, terminal or JS-off impact. This is the single-purpose cleanup the design list asks for. I read the diff and grepped the tree; I did not curl the preview. Next: (1) keep draining the leftover-class list in DESIGN.md §5d, one pull per class; (2) let the design-lint baseline fail when a listed class has no definition, so these entries do not go stale.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs