Public: anyone can read this; the crew can change it.

An app's domain DNS records draw §5's table, and .domain-records leaves the stylesheet #4655

Parked opened this
Closed without merging

An app's pending DNS records now render as a §5 .table, and .domain-records is gone from the stylesheet and §5d. bun scripts/design-lint.ts is clean, and the design-lint, app-domains and backups tests pass. I didn't get a type check: tsc couldn't find the bun types here, so I ran no type check at all.

Notes

stopped parked by the crew deploy f849840

opened this

An app's pending DNS records now render as a §5 .table, and .domain-records is gone from the stylesheet and §5d. bun scripts/design-lint.ts is clean, and the design-lint, app-domains and backups tests pass. I didn't get a type check: tsc couldn't find the bun types here, so I ran no type check at all. I didn't touch docs/design/baseline.json, since the lint reports no counts to lower.

  • Records table: recordsToPublish in src/web/pages/settings.ts draws a table.table[data-dense] inside .table-scroll, with Type, Name and Value columns. The value is still selectable and carries its title, and the per-record notes stay as .row-meta lines.
  • Test: test/app-domains.test.ts now asserts the table and the "Type" header, alongside the existing check that domain-records is absent.
  • Backups page: the restore command in src/web/pages/backups.ts was also using .domain-records. It now uses .run-log.
  • Second class removed: the backups-parts test forbids any backups-* class on that page, so I couldn't point the command at .backups-restore. That class had no other use, so I removed it from content.ts and §5d too.

The backups restore block now takes .run-log's styling instead of the old .backups-restore look. I didn't check how it renders.

🤖 Generated with Claude Code

Closes #4613

4 earlier comments · 1 event
commented

An app's pending DNS records now render as a §5 .table, and .domain-records is gone from the stylesheet and §5d. bun scripts/design-lint.ts is clean, and the design-lint, app-domains and backups tests pass. I didn't get a type check: tsc couldn't find the bun types here, so I ran no type check at all. I didn't touch docs/design/baseline.json, since the lint reports no counts to lower.

  • Records table: recordsToPublish in src/web/pages/settings.ts draws a table.table[data-dense] inside .table-scroll, with Type, Name and Value columns. The value is still selectable and carries its title, and the per-record notes stay as .row-meta lines.
  • Test: test/app-domains.test.ts now asserts the table and the "Type" header, alongside the existing check that domain-records is absent.
  • Backups page: the restore command in src/web/pages/backups.ts was also using .domain-records. It now uses .run-log.
  • Second class removed: the backups-parts test forbids any backups-* class on that page, so I couldn't point the command at .backups-restore. That class had no other use, so I removed it from content.ts and §5d too.

The backups restore block now takes .run-log's styling instead of the old .backups-restore look. I didn't check how it renders.

🤖 Generated with Claude Code

commented

The check failed because docs/DESIGN.md conflicted with main on the §5d page-furniture line. I merged origin/main into the branch and kept main's version of that line. I then removed .domain-records and .backups-restore from it again and pushed. I haven't seen the forge's re-run of the check.

After the merge, bun scripts/design-lint.ts is clean. The design-lint, app-domains and backups tests pass (40 tests, 0 fail). Neither class name appears any more in docs/DESIGN.md or src/web/style/content.ts.

The pull itself is unchanged:

  • An app's pending DNS records render as a §5 .table, with a test that asserts the table.
  • .domain-records is gone from the stylesheet and §5d.
  • The backups restore command now wears .run-log.
  • .backups-restore is gone from the stylesheet and §5d.

🤖 Generated with Claude Code

Changes requested — before the latest push

Fix first: the backups restore command must not wear .run-log. DESIGN.md §5 defines pre.run-log as a scrolling log pane that follows the tail. In content.ts it carries min-height: 12em, max-height: calc(100dvh - 300px) and 14px type. A one-line command now sits in a 12em-tall box, which is a visible layout change on /settings/backups that nobody checked (the builder said so). It also names the wrong component. Use a named component that fits a copyable command, or add a small documented one in docs/design/areas/backups.md. Do not reuse the log pane. Second, the records table is nested in a <span> inside a list row's meta. A table inside a span is invalid content model, and .row-meta styling may bleed into it. Render it as a block sibling in the row, or in a div.table-scroll. Third, .record-value { user-select: all } is scoped to .setting-list, so check that the Value cell still matches it. Otherwise the table itself, the removal of .domain-records, and the test are right.

commented

This pull now does what juniper asked: the records table is valid HTML, and the backups restore command no longer wears .run-log.

  • Restore command: I reverted the commit that put .run-log on it. It now uses a new .restore-command class, defined in content.ts and documented in the new docs/design/areas/backups.md. It has the old look: a wrapping, keyboard-scrollable <pre> that takes its height from its text, so the 12em box is gone. I didn't keep the old .backups-restore name because test/backups-parts.test.ts rejects any backups-* class. I also dropped .backups-restore from §5d of docs/DESIGN.md.
  • Records table: the wrapper is now <div class="table-scroll">. The row's .row-main is a <div> instead of a <span>, so no block element sits inside a span. The note lines stay .row-meta spans.
  • Value cell: the domains list is <ul class="list setting-list"> and the table sits inside it, so .setting-list .record-value { user-select: all } still matches. The existing test asserts that markup.

I ran the domains, backups and design tests and scripts/design-lint.ts, and they pass. I could not run tsc, because the bun type definitions were missing in this sandbox.

commented

I merged main into this branch and pushed it. The merge conflicted only in docs/DESIGN.md.

The conflict was one long line in §5 that lists the classes style/content.ts defines. I kept this branch's version of it. The two sides disagreed on five class names, and none of them appears anywhere in src after the merge:

  • Dropped from this side's list: .app-shelf, .front-pin-any and .front-weights.
  • Not taken from main's list: .backups-restore and .domain-records.

I did not run the full bun test. It was still going after about 15 minutes, so I stopped it. I ran the design audit, design lint, design map, domain drill, app-domains and backups-parts suites instead. All 50 tests pass. The forge's check will run the whole suite on this push.

I did not run bun scripts/design-lint.ts after the merge. The design-lint test file passed.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs