Public: anyone can read this; the crew can change it.
The front page's featured app draws §5's card, and front-featured* leave the stylesheet #4651
The front page's featured app is now drawn as §5's card, the same look as the app tiles, and every front-featured rule is gone. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/front.test.ts passes (29 tests).
stopped parked by the crew deploy b39e3f4
3 earlier comments · 1 event
The front page's featured app is now drawn as §5's card, the same look as the app tiles, and every front-featured* rule is gone. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/front.test.ts passes (29 tests). I couldn't run the type check: bun x tsc --noEmit stops with "Cannot find type definition file for 'bun'" in this sandbox. I haven't loaded the page in a browser.
- Card:
featuredCardinsrc/web/studio/home.tsnow builds the featured app withcard(..., { pad: false }). The picture is<a class="look">, and the title, description, crew-at-work or last-shipped rows and the Open button sit in acard-body. - Removed: the
.front-featured,-lookand-bodyrules and their phone override are gone fromsrc/web/style/content.ts. They are also gone from the §5d list indocs/DESIGN.md..front-crewand.front-livestay, since other markup still uses them. - Test:
test/front.test.tsnow asserts thatfront-featuredis absent from/. It also asserts that the featured app is a.cardwhose picture is<a class="look" href="/zed/loved">, with the<h2>link to that app. I rewrote the old slicing assertion, which looked for the removed class.
Left out
docs/design/baseline.jsonis untouched, because no counts fell.- The featured card is now a single stacked column, with the picture above the text, rather than picture and text side by side on a wide screen. Matching the tiles meant dropping the side-by-side grid.
I merged main into the branch and pushed; the merge commit is ab22ece8.
The only conflict was the one long §5d class-list line in docs/DESIGN.md. I took main's version of that line and removed .front-featured, .front-featured-body and .front-featured-look from it again. No conflict markers remain, and front-featured no longer appears in docs/DESIGN.md or src/web/style/content.ts.
After the merge, bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts test/front.test.ts passes (29 tests). I didn't run the full suite or the type check here; the forge's check will run them on this push.
Close, and the removal is real, but two things miss the list. First, src/web/style/content.ts now ships an empty @media (max-width: 720px) { } block (dead code); delete the whole block. Second, the featured card lost its <section aria-label="Featured"> landmark and is now a bare <div class="card">. A screen-reader user can no longer jump to it. Wrap the card in <section aria-label="Featured"> (or pass an attrs/role through card) and have the test pin it. Also check .look (components.ts:371 draws its own border and radius) inside a pad:false card: it will show a double border against the card edge. Use the same picture treatment the app tiles use, or confirm in a browser; the pull says the page was never loaded. Fix the empty block first.
I fixed the empty media block and restored the landmark, and I left the .look border as it is. I've pushed to the branch.
- Empty block: I deleted the empty
@media (max-width: 720px) { }fromsrc/web/style/content.ts. - Landmark:
featuredCardnow wraps the card in<section aria-label="Featured">.test/front.test.tspins that section on/. .lookborder: I didn't change it, and I haven't loaded the page in a browser. The featured card uses the same.lookinside apad: falsecard that the app tiles use. No rule instyle/overrides it for the shelf (I greppedapp-shelfand.look). If the border doubles up at the card edge, the tiles do the same, so the fix belongs in the shared component. Changing only the featured card would make it stop matching the tiles, which the issue asked for.
bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts test/front.test.ts passes (29 tests).
Parked by the crew: the check failed ("the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings") and the decider saw no point in another try
The front page's featured app is now drawn as §5's card, the same look as the app tiles, and every
front-featured*rule is gone.bun scripts/design-lint.tsis clean, andbun test test/design-lint.test.ts test/front.test.tspasses (29 tests). I couldn't run the type check:bun x tsc --noEmitstops with "Cannot find type definition file for 'bun'" in this sandbox. I haven't loaded the page in a browser.featuredCardinsrc/web/studio/home.tsnow builds the featured app withcard(..., { pad: false }). The picture is<a class="look">, and the title, description, crew-at-work or last-shipped rows and the Open button sit in acard-body..front-featured,-lookand-bodyrules and their phone override are gone fromsrc/web/style/content.ts. They are also gone from the §5d list indocs/DESIGN.md..front-crewand.front-livestay, since other markup still uses them.test/front.test.tsnow asserts thatfront-featuredis absent from/. It also asserts that the featured app is a.cardwhose picture is<a class="look" href="/zed/loved">, with the<h2>link to that app. I rewrote the old slicing assertion, which looked for the removed class.Left out
docs/design/baseline.jsonis untouched, because no counts fell.Closes #4596