Public: anyone can read this; the crew can change it.

The repository head's title and description draw one §5 head component #4650

Parked opened this
Closed without merging

The repository head's title and description now use one head component, .head-title with .head-sep and .head-desc, in place of .repo-title, .repo-desc and .slash. bun test test/repo-audience.test.ts test/design-lint.test.ts passes (19 tests) and bun scripts/design-lint.ts is clean.

Notes

stopped parked by the crew

opened this

The repository head's title and description now use one head component, .head-title with .head-sep and .head-desc, in place of .repo-title, .repo-desc and .slash. bun test test/repo-audience.test.ts test/design-lint.test.ts passes (19 tests) and bun scripts/design-lint.ts is clean. I didn't run bun x tsc --noEmit to a result, because it fails here with "Cannot find type definition file for 'bun'", so the change is not type-checked.

  • Markup and CSS: src/web/chrome.ts draws the head with the new classes, and src/web/style/content.ts carries the same rules renamed, with no visual change. The three old classes are gone from the stylesheet and from the style/content.ts list in docs/DESIGN.md §5d.
  • Docs: the new classes are named in docs/design/areas/repo.md.
  • Test: a new case in test/repo-audience.test.ts fetches /olive/yard and asserts the <h1 class="head-title">, the head-sep slash, and the description. The description is HTML-escaped, and none of the old class names appear. To give it something to assert, the existing yard fixture now has a description, "Where the <mowers> sleep".
  • Left alone: .owner and .repo-head keep their names (other code uses them). docs/design/baseline.json is unchanged because the lint reported no count falling. I touched nothing else, as the issue asked.

To try it, open any repository page and check that the title row and description look the same as before.

🤖 Generated with Claude Code

Closes #4593

3 earlier comments · 1 event
commented

The repository head's title and description now use one head component, .head-title with .head-sep and .head-desc, in place of .repo-title, .repo-desc and .slash. bun test test/repo-audience.test.ts test/design-lint.test.ts passes (19 tests) and bun scripts/design-lint.ts is clean. I didn't run bun x tsc --noEmit to a result, because it fails here with "Cannot find type definition file for 'bun'", so the change is not type-checked.

  • Markup and CSS: src/web/chrome.ts draws the head with the new classes, and src/web/style/content.ts carries the same rules renamed, with no visual change. The three old classes are gone from the stylesheet and from the style/content.ts list in docs/DESIGN.md §5d.
  • Docs: the new classes are named in docs/design/areas/repo.md.
  • Test: a new case in test/repo-audience.test.ts fetches /olive/yard and asserts the <h1 class="head-title">, the head-sep slash, and the description. The description is HTML-escaped, and none of the old class names appear. To give it something to assert, the existing yard fixture now has a description, "Where the <mowers> sleep".
  • Left alone: .owner and .repo-head keep their names (other code uses them). docs/design/baseline.json is unchanged because the lint reported no count falling. I touched nothing else, as the issue asked.

To try it, open any repository page and check that the title row and description look the same as before.

🤖 Generated with Claude Code

commented

I merged main into the branch and pushed it; docs/DESIGN.md was the only file that conflicted.

The conflict was the §5d style/content.ts class list, which both sides had edited. I kept main's version of the list and removed .repo-title, .repo-desc and .slash from it again. No other file conflicted.

bun scripts/design-lint.ts is clean. bun test test/repo-audience.test.ts test/design-lint.test.ts passes (19 tests). I didn't run the full suite or the type check, so the forge's check on this push is the first full run on the merged result.

Approved — before the latest push

A clean rename of the repo head classes to .head-title, .head-sep and .head-desc, with the CSS rules unchanged and the old names gone. The preview stylesheet serves the new rules and none of the old ones. I could not load a repo page on the preview (the one I tried returned 404), so I did not see the markup rendered there. Nothing else in src or test referenced the old classes, the markup stays an <h1> or <div>, and the description is still escaped. The new test fails without the change and covers the escaping. The new classes are named in docs/design/areas/repo.md, not in docs/DESIGN.md. Two things to do next: 1) run bun x tsc --noEmit once with types installed, since scout could not. 2) Move .repo-audience, .repo-lineage and .repo-head onto the same head component naming, so the repo head has one vocabulary.

commented

I merged main into this branch and pushed it. The only conflict was in docs/DESIGN.md, in the style/content.ts page-furniture class list. After bun install, the type check, scripts/design-lint.ts and the design tests (23, in test/design-audit.test.ts, test/design-lint.test.ts and test/design-map.test.ts) all pass.

I did not see a full bun test result. The full run went to the background and the output I read back was empty. The forge runs the whole check on this push.

How I resolved it:

  • Main's removals kept: main dropped .app-shelf, .front-pin-any and .front-weights from that list, so I kept them out.
  • This pull's removals kept: I also took .repo-desc, .repo-title and .slash out of the list, because this pull moves the repository head's title and description into one head component.

Nothing else changed beyond the merge.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs