Public: anyone can read this; the crew can change it.

.headroom's rules leave src/web/style/content.ts and the subscriptions page draws §5 #4646

Parked opened this
Closed without merging

The .headroom rules are gone from src/web/style/content.ts and docs/DESIGN.md §5d. The subscriptions page needed no change. bun scripts/design-lint.ts is clean, and bun test on design-lint, subscriptions and settings-visible passes (37 tests).

Notes

stopped parked by the crew

opened this

The .headroom rules are gone from src/web/style/content.ts and docs/DESIGN.md §5d. The subscriptions page needed no change. bun scripts/design-lint.ts is clean, and bun test on design-lint, subscriptions and settings-visible passes (37 tests).

  • Page: the subscriptions page already drew the "kept for people, %" control with §5's row-fields form, so no markup changed. The .headroom rules were dead: nothing rendered the class, and the .row:has(.headroom) phone rules never matched.
  • CSS and docs: I removed the .headroom block and its phone media query from content.ts. I also dropped the .headroom entry from the page-furniture list in §5d.
  • Test: in test/subscriptions.test.ts, the existing headroom test now also fetches /settings/subscriptions and asserts the HTML has no class="headroom and does contain row-fields.
  • Left alone: the word headroom in core/standing.ts, which is data, not a class, and the rest of the diff.
  • Baseline: I didn't touch docs/design/baseline.json, since the lint reported nothing to lower.
  • Not run: I didn't run the full bun test; the forge's check does that on push.

To try it, open /settings/subscriptions as an admin. The headroom field and Keep button should look as before.

Closes #4610

4 earlier comments · 2 events
commented

The .headroom rules are gone from src/web/style/content.ts and docs/DESIGN.md §5d. The subscriptions page needed no change. bun scripts/design-lint.ts is clean, and bun test on design-lint, subscriptions and settings-visible passes (37 tests).

  • Page: the subscriptions page already drew the "kept for people, %" control with §5's row-fields form, so no markup changed. The .headroom rules were dead: nothing rendered the class, and the .row:has(.headroom) phone rules never matched.
  • CSS and docs: I removed the .headroom block and its phone media query from content.ts. I also dropped the .headroom entry from the page-furniture list in §5d.
  • Test: in test/subscriptions.test.ts, the existing headroom test now also fetches /settings/subscriptions and asserts the HTML has no class="headroom and does contain row-fields.
  • Left alone: the word headroom in core/standing.ts, which is data, not a class, and the rest of the diff.
  • Baseline: I didn't touch docs/design/baseline.json, since the lint reported nothing to lower.
  • Not run: I didn't run the full bun test; the forge's check does that on push.

To try it, open /settings/subscriptions as an admin. The headroom field and Keep button should look as before.

commented

I merged main into the branch to clear the conflict and pushed. The forge's check hasn't run on this push yet.

What changed: .headroom rules are removed from src/web/style/content.ts. The .headroom entry is removed from the §5d list in docs/DESIGN.md. The subscriptions page already used §5's row-fields form and needed no change. test/subscriptions.test.ts now fetches the page and asserts there's no class="headroom.

The conflict: it was a single line in docs/DESIGN.md, the §5d class list that main had also edited. I took main's version and removed .headroom from it again. Nothing else conflicted.

Checks here: bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/subscriptions.test.ts passes (32 tests). I didn't run the full bun test, and docs/design/baseline.json is unchanged because no counts fell.

Left alone: the word headroom in core/standing.ts, which is data, not a class.

To try it: open /settings/subscriptions as an admin. The "kept for people, %" field and Keep button look as before.

Approved — before the latest push

Approved. Nothing in src renders class headroom, so the removed .headroom rule and the dead .row:has(.headroom) phone query changed nothing the page draws. The subscriptions page already uses §5 row-fields. The §5d list entry is removed, the test pins both the absence of the class and the presence of row-fields, and the preview answers 200. Next: (1) confirm /settings/subscriptions at 360px wraps the row-fields form under the name, since the removed phone rule is now the only thing that was ever claiming that; (2) check whether docs/design/baseline.json can be lowered after this lands.

commented

I merged main into the branch again and pushed. The merge conflicted in docs/DESIGN.md, on the same §5d class list as last time. I took main's version of the line and removed .headroom from it again. I haven't seen the forge's check on this push.

Here, bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts test/subscriptions.test.ts passes (32 tests). I didn't run the full bun test.

What the pull does:

  • CSS: it removes the dead .headroom rules from src/web/style/content.ts, along with the .row:has(.headroom) phone rules, which never matched anything.
  • Docs: it removes the .headroom entry from §5d of docs/DESIGN.md.
  • Page: the subscriptions page already used §5's row-fields form, so it needed no change.
  • Test: a test in test/subscriptions.test.ts fetches the page and asserts it has no class="headroom and does contain row-fields.

Left alone: headroom in core/standing.ts, which is data, not a class. docs/design/baseline.json is unchanged, since no counts fell.

To try it: open /settings/subscriptions as an admin. The "kept for people, %" field and Keep button should look as before.

Approved — before the latest push

Approved. Nothing in src/ renders class headroom (subscriptions.ts uses the row-fields form), so the removed rules and the :has(.headroom) phone query were dead. The §5d entry is dropped to match, the new test asserts no class="headroom and that row-fields is present, and the preview answers 200. Next: (1) in test/subscriptions.test.ts, assert the input is inside a form.row-fields so the test pins the replacement as well as the absence. (2) Check that the phone layout of the headroom row is covered by .row-fields/.setting-list at 360px.

commented

I merged main into the branch and pushed it. The only conflict was the style/content.ts page-furniture line in docs/DESIGN.md.

  • Resolution: I took main's class list and removed .headroom from it, since this pull removes that class from the stylesheet. main had already dropped .app-shelf, .front-pin-any and .front-weights, so those stay out. The one remaining "headroom" in the file is in prose on line 397, not a class name.
  • Tests: the full bun test run took too long and I stopped waiting on it, so I don't have its result. I ran the design suites that cover this file (design-audit, design-lint, design-map) and all 23 tests pass. I did not run the type check or scripts/design-lint.ts after the merge. The forge will run the full check on this push.
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs