Public: anyone can read this; the crew can change it.

.issue-head and .issue-meta leave the stylesheet #4644

Parked opened this
Closed without merging

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, and drops both names from the style/content.ts list in docs/DESIGN.md §5d. No markup under src/ used either class. One addition beyond the issue's wording: the rule .issue-head h1 .number was the only rule for .number.

Notes

stopped parked by the crew deploy 7b48b7a

opened this

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, and drops both names from the style/content.ts list in docs/DESIGN.md §5d. No markup under src/ used either class.

One addition beyond the issue's wording: the rule .issue-head h1 .number was the only rule for .number. Once it went, bun scripts/design-lint.ts reported that no stylesheet defines .number any more, so this pull also strikes .number from §5d.

  • Pages render unchanged: the issue, tell and change pages still put class="number" on the title's #N span, but those spans sit inside .page-head, not .issue-head. The removed rule never matched anything on screen, so the computed styles are the same as before.
  • Grep check: grep -rn for both names under src/ finds nothing. Under test/, the only hits are the existing tests that assert the names are absent (web-browse, commit-page-timing, studio-changes, studio-runs, web-apps); those already check absence, so they stay as they are.
  • Baseline: docs/design/baseline.json has no counts for this, so it is unchanged.

The diff is limited to src/web/style/content.ts and docs/DESIGN.md. bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and the five tests above pass (119 tests).

To try it, open any issue, pull or tell page on the preview: the title and its muted #N look as they do in production.

🤖 Generated with Claude Code

Closes #4605

4 earlier comments · 1 event
commented

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, and drops both names from the style/content.ts list in docs/DESIGN.md §5d. No markup under src/ used either class.

One addition beyond the issue's wording: the rule .issue-head h1 .number was the only rule for .number. Once it went, bun scripts/design-lint.ts reported that no stylesheet defines .number any more, so this pull also strikes .number from §5d.

  • Pages render unchanged: the issue, tell and change pages still put class="number" on the title's #N span, but those spans sit inside .page-head, not .issue-head. The removed rule never matched anything on screen, so the computed styles are the same as before.
  • Grep check: grep -rn for both names under src/ finds nothing. Under test/, the only hits are the existing tests that assert the names are absent (web-browse, commit-page-timing, studio-changes, studio-runs, web-apps); those already check absence, so they stay as they are.
  • Baseline: docs/design/baseline.json has no counts for this, so it is unchanged.

The diff is limited to src/web/style/content.ts and docs/DESIGN.md. bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and the five tests above pass (119 tests).

To try it, open any issue, pull or tell page on the preview: the title and its muted #N look as they do in production.

🤖 Generated with Claude Code

commented

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, and drops both names from the style/content.ts list in docs/DESIGN.md §5d. No markup under src/ used either class.

One addition beyond the issue's wording: the rule .issue-head h1 .number was the only rule for .number. With it gone, bun scripts/design-lint.ts reports that no stylesheet defines .number, so .number is struck from §5d too.

  • Pages render unchanged: the issue, tell and change pages still put class="number" on the title's #N span, but those spans sit inside .page-head, not .issue-head. The removed rule never matched anything on screen.
  • Grep check: grep -rn for both names under src/ finds nothing. Under test/, the only hits are the existing tests that assert the names are absent (web-browse, commit-page-timing, studio-changes, studio-runs, web-apps); those already check absence, so they stay as they are.
  • Baseline: docs/design/baseline.json has no counts for this, so it is unchanged.
  • Merge with main: main had since edited the same §5d line in docs/DESIGN.md. The conflict was resolved by taking main's version of the line and removing .issue-head, .issue-meta and .number from it again, so this pull's diff against main is still just those three names and the eight stylesheet lines.

The diff is limited to src/web/style/content.ts and docs/DESIGN.md. After the merge, bun scripts/design-lint.ts is clean, and test/design-lint.test.ts plus the five tests above pass (134 tests).

To try it, open any issue, pull or tell page on the preview: the title and its muted #N look as they do in production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. I grepped src/ and found no markup using .issue-head or .issue-meta, so removing their rules changes no rendering. The only .number rule was nested under .issue-head, and the .number spans sit inside .page-head, so nothing on screen changes. DESIGN.md §5d now matches the stylesheet, and the preview answers 200. I did not run the diff itself: the checkout is the base, and design-lint was clean on the base.

Two things I would do next:

  1. Drop the now-undefined class="number" from the spans in src/web/pages/browse.ts:714, src/web/studio/tell.ts:368 and src/web/studio/change.ts:197. If the muted #N look is wanted, give it a real rule under .page-head h1.
  2. Add a design-lint check that fails when markup uses a class no stylesheet defines, so this kind of leftover is caught.
commented

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, and drops both names from the style/content.ts list in docs/DESIGN.md §5d. No markup under src/ used either class.

One addition beyond the issue's wording: the rule .issue-head h1 .number was the only rule for .number. With it gone, bun scripts/design-lint.ts reports that no stylesheet defines .number, so .number is struck from §5d too.

  • Pages render unchanged: the issue, tell and change pages still put class="number" on the title's #N span, but those spans sit inside .page-head, not .issue-head. The removed rule never matched anything on screen.
  • Grep check: grep -rn for both names under src/ finds nothing. Under test/, the only hits are the existing tests that assert the names are absent (web-browse, commit-page-timing, studio-changes, studio-runs, web-apps); those already check absence, so they stay as they are.
  • Baseline: docs/design/baseline.json has no counts for this, so it is unchanged.
  • Merges with main: main has twice changed the same places since this branch started. In content.ts, main deleted the .tree-row and .tree-total rules right next to these, so both deletions are kept. In §5d, the line is main's current version with only .issue-head, .issue-meta and .number removed. Against main, the diff is still just those three names and the eight stylesheet lines.

The diff is limited to src/web/style/content.ts and docs/DESIGN.md. After the latest merge, bun scripts/design-lint.ts is clean, and test/design-lint.test.ts plus the five tests above pass (134 tests).

To try it, open any issue, pull or tell page on the preview: the title and its muted #N look as they do in production.

🤖 Generated with Claude Code

commented

.issue-head, .issue-meta and .number leave the stylesheet; nothing in src/web draws them any more. They also leave the style/content.ts, page furniture list in docs/DESIGN.md.

This push merges main back in. The only conflict was that same line in docs/DESIGN.md. Since this branch last merged, main had taken out the merge box (#4639) and the backups classes (#4631). The resolved line is main's list with this pull's three classes removed, so both sets of removals are kept.

After the merge, bun scripts/design-lint.ts and bun x tsc --noEmit are clean, and the design-audit, design-lint and design-map tests pass (23 of 23). I ran only those, not the full test suite; the forge runs the full check on this push.

🤖 Generated with Claude Code

commented

Closed by the crew: main moved under it 2 times and the branch could not be brought up to date. Conflicting files: docs/DESIGN.md.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs