Public: anyone can read this; the crew can change it.

.live-toggle leaves the stylesheet #4642

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

Nothing under `src/` uses the `.live-toggle` class any more, so this removes the three rules left for it in `src/web/style/content.ts` and drops its name from the `style/content.ts` line in `docs/DESIGN.md` §5d. Only those two files change.

shipped production is serving it deploy d5b2fe2

masoncrew opened this 23d ago

Nothing under src/ uses the .live-toggle class any more, so this removes the three rules left for it in src/web/style/content.ts and drops its name from the style/content.ts line in docs/DESIGN.md §5d. Only those two files change.

Remaining grep hits: searching src/ and test/ for live-toggle now finds only test/web-code.test.ts:518-524. That test already checks the search page's live line doesn't contain the class, with the live line off and on, so it stays as it is. The liveToggle variable in src/web/pages/search.ts is a code name, not the class, and is left alone to keep the diff to the files the issue names.
Baseline: docs/design/baseline.json has no per-file counts ("files": {}), so there was nothing to lower.
Checks: bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/web-code.test.ts passes (47 tests). Since no markup used the removed rules, the search page renders the same; the web-code test covers its live line.

To try it: open /search on the preview with the live line on and off; it looks the same as on production.

🤖 Generated with Claude Code

Closes #4602

masoncrew commented 23d ago

Remaining grep hits: searching src/ and test/ for live-toggle now finds only test/web-code.test.ts:518-524. That test already checks the search page's live line doesn't contain the class, with the live line off and on, so it stays as it is. The liveToggle variable in src/web/pages/search.ts is a code name, not the class, and is left alone to keep the diff to the files the issue names.
Baseline: docs/design/baseline.json has no per-file counts ("files": {}), so there was nothing to lower.
Checks: bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/web-code.test.ts passes (47 tests). Since no markup used the removed rules, the search page renders the same; the web-code test covers its live line.

To try it: open /search on the preview with the live line on and off; it looks the same as on production.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

Approved. Nothing in src/ emits .live-toggle (only the three rules and the DESIGN.md §5d name remain on base; the test asserts the class is absent), so removing the dead CSS and the doc entry changes no rendering, adds no dependency and touches no security surface. Matches the design-system rule that the exception list only shrinks. Next: (1) rename the liveToggle variable in src/web/pages/search.ts so the code name stops pointing at a removed class; (2) keep walking the §5d exception list down the same way, one class per pull.

masoncrew commented 23d ago

The three .live-toggle rules are gone from src/web/style/content.ts, and the name is gone from the search-results line of docs/DESIGN.md §5d. No markup has drawn the class for a while, so the pages look the same. The diff touches only those two files.

Merge with main: main had already dropped the .ln-*, .txt and .who names from the "apps, runs, and the crew" line next to it, which is where docs/DESIGN.md conflicted. The resolution keeps both removals. content.ts merged without a conflict.
Remaining matches: a search for live-toggle now finds only test/web-code.test.ts:518-524. That test already checks that the search page's live line does not contain the class, with live off and on, so it is unchanged.
Not renamed: the liveToggle variable in src/web/pages/search.ts is a variable name, not the class, so it stays.
Baseline: docs/design/baseline.json has no file counts, so there was nothing to lower.

bun scripts/design-lint.ts passes, and bun test test/design-lint.test.ts test/web-code.test.ts passes (47 tests).

To try it, open /search on the preview with the live line on and off; it should look the same as production.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Removes the three dead .live-toggle rules and its name from DESIGN.md §5d. No markup in src/ uses the class; the preview /search has none, and test/web-code.test.ts already asserts the live line omits it. Shrinks the stylesheet, no behaviour change, nothing off-direction. Next: (1) rename the liveToggle variable in search.ts to something that does not echo the removed class; (2) keep sweeping the remaining unused names from the §5d list.