Public: anyone can read this; the crew can change it.

.tree-row and .tree-total leave the stylesheet #4641

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The `.tree-row` and `.tree-total` rules are gone from the stylesheet and from the design doc. Since #4203, the repository tree listing draws its rows and its total line with §5's `.row`, `.row-trail` and `.card-foot`, so nothing used these four rules any more.

shipped production is serving it deploy bf488b2

opened this

The .tree-row and .tree-total rules are gone from the stylesheet and from the design doc. Since #4203, the repository tree listing draws its rows and its total line with §5's .row, .row-trail and .card-foot, so nothing used these four rules any more.

  • src/web/style/content.ts: the four rules for .tree-row and .tree-total are deleted.
  • docs/DESIGN.md: both names are removed from the style/content.ts class list in §5d.
  • docs/design/baseline.json: not changed. It is already empty, so there is no count to lower.
  • test/tree-listing.test.ts: not changed. It already asserts that the tree page's markup contains neither name, which is the form the issue allows. Because of that, grep -rn under test/ still finds both names on that test's two absence assertions; under src/ it finds nothing.

The tree page should render the same as before, since only rules that no markup matched were removed. I did not check it in a browser. test/tree-listing.test.ts still passes, so the tree listing's rows, links, sizes and total are all still there.

bun scripts/design-lint.ts is clean, and bun test passes on test/design-lint.test.ts, test/tree-listing.test.ts and the other design tests (design-audit, design-map, og-designs, review-design).

To try it: open any repository's tree in the preview, for example /<owner>/<repo>/tree/main/src.

🤖 Generated with Claude Code

Closes #4601

commented

The .tree-row and .tree-total rules are gone from the stylesheet and from the design doc. Since #4203, the repository tree listing draws its rows and its total line with §5's .row, .row-trail and .card-foot, so nothing used these four rules any more.

  • src/web/style/content.ts: the four rules for .tree-row and .tree-total are deleted.
  • docs/DESIGN.md: both names are removed from the style/content.ts class list in §5d.
  • docs/design/baseline.json: not changed. It is already empty, so there is no count to lower.
  • test/tree-listing.test.ts: not changed. It already asserts that the tree page's markup contains neither name, which is the form the issue allows. Because of that, grep -rn under test/ still finds both names on that test's two absence assertions; under src/ it finds nothing.

The tree page should render the same as before, since only rules that no markup matched were removed. I did not check it in a browser. test/tree-listing.test.ts still passes, so the tree listing's rows, links, sizes and total are all still there.

bun scripts/design-lint.ts is clean, and bun test passes on test/design-lint.test.ts, test/tree-listing.test.ts and the other design tests (design-audit, design-map, og-designs, review-design).

To try it: open any repository's tree in the preview, for example /<owner>/<repo>/tree/main/src.

🤖 Generated with Claude Code

commented

The .tree-row and .tree-total rules are gone from the stylesheet and from the design doc. Since #4203, the repository tree listing draws its rows and its total line with §5's .row, .row-trail and .card-foot, so nothing used these four rules any more.

  • src/web/style/content.ts: the four rules for .tree-row and .tree-total are deleted.
  • docs/DESIGN.md: both names are removed from the style/content.ts class list in §5d.
  • docs/design/baseline.json: not changed. It is already empty, so there is no count to lower.
  • test/tree-listing.test.ts: not changed. It already asserts that the tree page's markup contains neither name, which is the form the issue allows. Because of that, grep -rn under test/ still finds both names on that test's two absence assertions; under src/ it finds nothing.

main has been merged in. The one conflict was that same §5d line in docs/DESIGN.md, because main had meanwhile dropped the .explore-* names from it. The resolution keeps main's line with .tree-row and .tree-total also removed. Against main, the diff is still just these two files (1 insertion, 5 deletions).

The tree page should render the same as before, since only rules that no markup matched were removed. I did not check it in a browser.

bun scripts/design-lint.ts is clean after the merge. bun test passes on test/design-lint.test.ts, test/tree-listing.test.ts, test/design-audit.test.ts and test/design-map.test.ts.

To try it: open any repository's tree in the preview, for example /<owner>/<repo>/tree/main/src.

🤖 Generated with Claude Code

Approved

Pure dead-CSS removal: no markup in src/ emits .tree-row or .tree-total (only the rules themselves matched), the preview answers 200, and the doc list matches the stylesheet. No visual change expected; DESIGN.md is kept in step. Two things next: (1) look at /<owner>/<repo>/tree/main/src on the 360px phone once to confirm the .row and .card-foot spacing is what you want, since the builder did not check a browser; (2) keep sweeping the remaining unused names left in the §5d content.ts list the same way.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs