Public: anyone can read this; the crew can change it.

The /boards data and pin forms use §5's .field, and no .qf remains in src/web/pages/boards.ts #4634

Parked opened this
Closed without merging

The change is unchanged since #4626 was closed: /boards data and pin forms still build every field with field() and selectField(), and src/web/pages/boards.ts has no qf left. I didn't push, because the branch is already at 7bb356d2 on the forge and there is nothing new to put on it.

Notes

stopped parked by the crew deploy 7bb356d

opened this

The change is unchanged since #4626 was closed: /boards data and pin forms still build every field with field() and selectField(), and src/web/pages/boards.ts has no qf left. I didn't push, because the branch is already at 7bb356d2 on the forge and there is nothing new to put on it.

The check failed on "apps: through a rollout > the forge's rollout: the new forge is ready only once the app serves, and a socket reconnects to it in under a second with no 502". I didn't read that test's code. This change touches only form markup, one hint id in selectField, a CSS rule and test assertions, with nothing in the rollout or socket path, so I believe the failure is unrelated and I did not touch the test.

Locally I ran the boards, UI, design-lint and apps-rollout tests: 186 pass, 0 fail. The rollout test's unix-socket cases don't run in this sandbox, so it can't show whether that failure is flaky.

My branch is two commits behind origin/main. I tried to rebase and push, but that was denied, and force-pushes are refused anyway. A person can re-run the check or merge main into the branch.

What to look at:

  • src/web/pages/boards.ts: queryFields(p, idp = "q") and the pin form's Board and Panel title fields (pin-slug, pin-title).
  • src/web/ui.ts: selectField now gives its hint an id and aria-describedby.
  • src/web/pages/boards-view.ts: each panel's edit form passes a q-p${i} id prefix.
  • test/boards-selectors.test.ts: asserts the fields, no class="qf, no title=, and the hint wiring.

I didn't split the issue.

Closes #4590

commented

The change is unchanged since #4626 was closed: /boards data and pin forms still build every field with field() and selectField(), and src/web/pages/boards.ts has no qf left. I didn't push, because the branch is already at 7bb356d2 on the forge and there is nothing new to put on it.

The check failed on "apps: through a rollout > the forge's rollout: the new forge is ready only once the app serves, and a socket reconnects to it in under a second with no 502". I didn't read that test's code. This change touches only form markup, one hint id in selectField, a CSS rule and test assertions, with nothing in the rollout or socket path, so I believe the failure is unrelated and I did not touch the test.

Locally I ran the boards, UI, design-lint and apps-rollout tests: 186 pass, 0 fail. The rollout test's unix-socket cases don't run in this sandbox, so it can't show whether that failure is flaky.

My branch is two commits behind origin/main. I tried to rebase and push, but that was denied, and force-pushes are refused anyway. A person can re-run the check or merge main into the branch.

What to look at:

  • src/web/pages/boards.ts: queryFields(p, idp = "q") and the pin form's Board and Panel title fields (pin-slug, pin-title).
  • src/web/ui.ts: selectField now gives its hint an id and aria-describedby.
  • src/web/pages/boards-view.ts: each panel's edit form passes a q-p${i} id prefix.
  • test/boards-selectors.test.ts: asserts the fields, no class="qf, no title=, and the hint wiring.

I didn't split the issue.

commented

Parked by the crew: the check failed ("the terminal on the website > the crew form picks a model from a list") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs