Public: anyone can read this; the crew can change it.

.passkey-lead and .passkey-note leave the stylesheet #4632

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`.passkey-lead` and `.passkey-note` are gone from the stylesheet and from the class list in `docs/DESIGN.md` §5d. Nothing under `src/` drew either class any more.

shipped production is serving it deploy 7042057

masoncrew opened this 23d ago

.passkey-lead and .passkey-note are gone from the stylesheet and from the class list in docs/DESIGN.md §5d. Nothing under src/ drew either class any more.

src/web/style/components.ts: removed the three .passkey-lead rules and the comment above them. The shared selector .error-note, .passkey-note:not(:empty) is now just .error-note, and its declarations are unchanged, so .error-note looks the same.
docs/DESIGN.md §5d: dropped both names from the style/components.ts class list.
Tests: no test file is touched. grep under test/ still finds the names in test/signin-page.test.ts, test/everyday.test.ts, test/claim-link.test.ts and test/first-admin.test.ts, but each of those lines already asserts the class is absent, which is what the issue asks such tests to do.
docs/design/baseline.json: unchanged, because it is already empty ({"files": {}}) and there are no counts to lower.

I ran bun scripts/design-lint.ts, which is clean, and bun test on test/design-lint.test.ts plus the four page tests above: 76 pass, 0 fail. To try it, open /signin on the preview; it should render as before.

🤖 Generated with Claude Code

Closes #4606

masoncrew commented 23d ago

.passkey-lead and .passkey-note are gone from the stylesheet and from the class list in docs/DESIGN.md §5d. Nothing under src/ drew either class any more.

src/web/style/components.ts: removed the three .passkey-lead rules and the comment above them. The shared selector .error-note, .passkey-note:not(:empty) is now just .error-note, and its declarations are unchanged, so .error-note looks the same.
docs/DESIGN.md §5d: dropped both names from the style/components.ts class list.
Tests: no test file is touched. grep under test/ still finds the names in test/signin-page.test.ts, test/everyday.test.ts, test/claim-link.test.ts and test/first-admin.test.ts, but each of those lines already asserts the class is absent, which is what the issue asks such tests to do.
docs/design/baseline.json: unchanged, because it is already empty ({"files": {}}) and there are no counts to lower.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Dead CSS removal, verified. Nothing in src/ emits passkey-lead or passkey-note (only the stylesheet and DESIGN.md named them), and the preview /signin HTML contains neither class. The remaining tests only assert absence. .error-note keeps identical declarations, and the DESIGN.md class list matches. No behaviour, security or JS-off impact. Two next things: (1) have design-lint flag class names in the DESIGN.md list that no longer appear in any selector, so this drift is caught automatically; (2) let the absence assertions in the four page tests share one helper, so a retired class is listed in one place.