Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:uxo2i7ava1 is past its budget: trevato/forge: "a subscription's standing > (unnamed)" failed on 3 pulls in the last hour — the lane's red, not theirs;… #4549
Check · Review · Land · Live done — Landed and live in production.
The `a subscription's standing` setup hook no longer hashes a password, so its pass or fail doesn't depend on how loaded the check machine is. I haven't seen it fail under load, so this is my diagnosis of the red.
shipped production is serving it deploy 68efd9d
The a subscription's standing setup hook no longer hashes a password, so its pass or fail doesn't depend on how loaded the check machine is. I haven't seen it fail under load, so this is my diagnosis of the red.
The hook made the seed user with an argon2 hash (64 MiB, one core), which is the part that stretches under load. The test never signs in, so test/standing.test.ts now creates the user without a password. That is allowed, because password is optional in createUser. The assertions are unchanged. The earlier 60 s hook timeout is also unchanged. It sits at the --timeout 60000 the forge's test run already uses, so it didn't help.
I ran test/standing.test.ts and its 8 tests pass. The type check wouldn't run here because bun install hadn't been run, so the types for bun were missing. The edit only removes one line from a test call. The full check runs on the forge.
I didn't touch any other test that hashes a password in its setup.
To try it, run bun test test/standing.test.ts.
Test-only change. createUser accepts no password (empty hash, src/core/users.ts), nothing in standing.test.ts signs in, and the 8 tests pass here. It removes the argon2 cost from the hook, which is the load-sensitive part, so it serves the stability priority. No product code, security surface, dependency or doc is touched.
Two things I would do next: (1) find the other test setups that hash a password they never use and drop it the same way; (2) if standing still goes red under load, look at what else the hook does (createRepo) before raising the timeout again. The new comment says why the password is absent, which is enough.
The
a subscription's standingsetup hook no longer hashes a password, so its pass or fail doesn't depend on how loaded the check machine is. I haven't seen it fail under load, so this is my diagnosis of the red.The hook made the seed user with an argon2 hash (64 MiB, one core), which is the part that stretches under load. The test never signs in, so
test/standing.test.tsnow creates the user without a password. That is allowed, becausepasswordis optional increateUser. The assertions are unchanged. The earlier 60 s hook timeout is also unchanged. It sits at the--timeout 60000the forge's test run already uses, so it didn't help.I ran
test/standing.test.tsand its 8 tests pass. The type check wouldn't run here becausebun installhadn't been run, so the types forbunwere missing. The edit only removes one line from a test call. The full check runs on the forge.I didn't touch any other test that hashes a password in its setup.
To try it, run
bun test test/standing.test.ts.Closes #4548