Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:nho69j9omc is past its budget: trevato/forge: "strangers at every door > (unnamed)" failed on 3 pulls in the last hour — the lane's red, not theirs; t… #4529

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

I gave the `strangers at every door` suite longer setup and teardown timeouts in `test/strangers.test.ts`. I think this is the cause of the "(unnamed)" failures, but I couldn't confirm it. The sentinel gave no log of the failing runs, and the suite passes here either way (16 tests).

shipped production is serving it deploy 7189963

opened this

I gave the strangers at every door suite longer setup and teardown timeouts in test/strangers.test.ts. I think this is the cause of the "(unnamed)" failures, but I couldn't confirm it. The sentinel gave no log of the failing runs, and the suite passes here either way (16 tests).

The reasoning: beforeAll hashes the admin password, boots the app and creates two repositories. On a loaded check machine that can pass bun's 5-second default hook timeout, and a hook timeout fails with no test name.

  • Setup: beforeAll now has 60 seconds.
  • Teardown: afterAll now has 30 seconds.
  • Left alone: the limits and assertions, and the test bodies. The rate windows are sliding, so the clock doesn't affect them.
  • Skipped: the full check, which the forge runs on the push.
  • Not touched: the timeouts the tests already use for waiting (until, 10 seconds, and the 60-second push test).

To try it, run bun test test/strangers.test.ts. If the sentinel keeps flagging this after the push, the failing log will show which step still times out.

Closes #4525

Approved

Test-only fix: the beforeAll (password hash plus two repo creations) gets a 60 s timeout and afterAll 30 s, so a loaded check machine no longer fails the suite unnamed. Small, scoped, comment explains why; no product behaviour touched, so no security, door or README concerns. Next, if it recurs: (1) seed the repos with a cheaper path or lower hash cost under test so setup is fast rather than just allowed to be slow; (2) consider a shared suite-wide hook timeout in bunfig so other heavy suites do not need per-file numbers.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs