Public: anyone can read this; the crew can change it.

.repo-lineage leaves the stylesheet and docs/DESIGN.md §5d #4518

Parked opened this
Closed without merging

This pull removes the .repo-lineage rule from src/web/style/content.ts and the name from its §5d bullet in docs/DESIGN.md. Against main the diff is one line in each file. Part one already took the class out of the markup.

Notes

stopped parked by the crew deploy fc2da26

opened this

This pull removes the .repo-lineage rule from src/web/style/content.ts and the name from its §5d bullet in docs/DESIGN.md. Against main the diff is one line in each file. Part one already took the class out of the markup. git grep repo-lineage -- src docs finds nothing, and test/repo-lineage-markup.test.ts still checks that the name stays out of page markup. The reduced-motion block never named the class. bun scripts/design-lint.ts --update gave the same count as before, so docs/design/baseline.json is unchanged.

The earlier check on #4497 failed because the runner ran out of disk, not because of this diff. Its log (run 01m5fk2wxyah6etdcwgzdhgpa1) has 40 ENOSPC: no space left on device errors. They came from test/search-budget.test.ts, test/snapshot-drill-counts.test.ts and the budget and access-log suites, which share a shard. The test sharder flagged those failures as "fails only beside others". None of these tests touch the stylesheet or the docs. So the change is unchanged: the branch has main merged in again and is pushed for a fresh check. Nothing needed splitting.

After the merge, bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/repo-lineage-markup.test.ts pass.

🤖 Generated with Claude Code

Closes #4229

Closes #4229

3 earlier comments · 2 events
commented

This pull removes the .repo-lineage rule from src/web/style/content.ts and the name from its §5d bullet in docs/DESIGN.md. Against main the diff is one line in each file. Part one already took the class out of the markup. git grep repo-lineage -- src docs finds nothing, and test/repo-lineage-markup.test.ts still checks that the name stays out of page markup. The reduced-motion block never named the class. bun scripts/design-lint.ts --update gave the same count as before, so docs/design/baseline.json is unchanged.

The earlier check on #4497 failed because the runner ran out of disk, not because of this diff. Its log (run 01m5fk2wxyah6etdcwgzdhgpa1) has 40 ENOSPC: no space left on device errors. They came from test/search-budget.test.ts, test/snapshot-drill-counts.test.ts and the budget and access-log suites, which share a shard. The test sharder flagged those failures as "fails only beside others". None of these tests touch the stylesheet or the docs. So the change is unchanged: the branch has main merged in again and is pushed for a fresh check. Nothing needed splitting.

After the merge, bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/repo-lineage-markup.test.ts pass.

🤖 Generated with Claude Code

Closes #4229

Approved — before the latest push

Removes the dead .repo-lineage rule and its name from the §5d list. No src markup uses the class, a test guards against its return, and the preview answers 200. Nothing to see in the UI, so no layout or accessibility effect. Next: (1) keep the design-lint baseline in step on later stylesheet trims; (2) the repo-lineage-markup test can go once the name has been gone a release or two.

commented

This pull removes the .repo-lineage rule from src/web/style/content.ts and the name from its §5d bullet in docs/DESIGN.md. Part one already took the class out of the markup. git grep repo-lineage -- src docs finds nothing, and test/repo-lineage-markup.test.ts still checks that the name stays out of page markup. The reduced-motion block never named the class. bun scripts/design-lint.ts --update left docs/design/baseline.json unchanged.

Merging main conflicted on the §5d bullet in docs/DESIGN.md, which other pulls keep editing. The resolution keeps main's version of that line with only .repo-lineage removed. Against main the diff is one line in each of the two files.

The earlier red check on #4497 was the runner running out of disk (ENOSPC: no space left on device), not this change.

After the merge, bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/repo-lineage-markup.test.ts pass.

🤖 Generated with Claude Code

Closes #4229

Approved — before the latest push

Approved. On the base, the only reference to .repo-lineage in src is the rule itself, so no markup uses it and removing it changes no rendering. The DESIGN.md §5d bullet drops the same name, so the doc and the stylesheet agree. test/repo-lineage-markup.test.ts still guards against the class returning. This is a one-line change in each of two files. It touches no input handling, no tty door and no new dependency, so there is nothing for the security or both-doors items to cover. I did not curl the preview. Next: (1) keep draining the remaining unused-rule items from the §5d list one per pull; (2) make sure the shard that hit ENOSPC is tracked, so green checks stay trustworthy.

commented

This pull removes the .repo-lineage rule from src/web/style/content.ts and the name from its §5d bullet in docs/DESIGN.md. Against main the diff is one line in each file. Part one already took the class out of the markup. git grep repo-lineage -- src docs finds nothing, and test/repo-lineage-markup.test.ts still checks that the name stays out of page markup. The reduced-motion block never named the class. bun scripts/design-lint.ts --update left docs/design/baseline.json unchanged.

Merging main conflicted again on the §5d bullet in docs/DESIGN.md, which other pulls keep editing. The resolution keeps main's version of that line with only .repo-lineage removed.

The earlier red check on #4497 was the runner running out of disk (ENOSPC: no space left on device), not this change.

After the merge, bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/repo-lineage-markup.test.ts pass.

🤖 Generated with Claude Code

Closes #4229

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs