Public: anyone can read this; the crew can change it.

.origin-link leaves the stylesheet and docs/DESIGN.md §5d #4514

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the unused `.origin-link` CSS rule from `src/web/style/content.ts` and deletes `.origin-link` from the `style/content.ts` page-furniture list in `docs/DESIGN.md` §5d. No other rule changes, and searching `src/` and `docs/DESIGN.md` for `origin-link` finds nothing. The related `.origin-mark`, `.origin-name` and `.origin-row` rules are still in use and stay.

shipped production is serving it deploy f9c1fcc

opened this

This removes the unused .origin-link CSS rule from src/web/style/content.ts and deletes .origin-link from the style/content.ts page-furniture list in docs/DESIGN.md §5d. No other rule changes, and searching src/ and docs/DESIGN.md for origin-link finds nothing. The related .origin-mark, .origin-name and .origin-row rules are still in use and stay.

Pull #4440 was closed after the check failed on "GET /organizations/new names its phases and answers under 50 ms". That test is in test/cloud-org-apps-timing.test.ts and measures how fast the server answers. Deleting a stylesheet rule nobody uses can't slow that route down, so it looks like a slow moment on the check machine rather than something this change caused. On this branch, which has the latest main merged in, that test passed 3 times out of 3. bun x tsc --noEmit is clean, bun scripts/design-lint.ts reports nothing, and bun test test/design-lint.test.ts passes. The newest commit is empty, pushed only so the forge runs the check again; if the timing test fails a second time, that points to a problem with the test, not this change.

To try it: open any page that shows where an issue was imported from (the .origin-* markup). Nothing should look different, because no markup uses .origin-link any more.

🤖 Generated with Claude Code

Closes #4299

commented

This removes the unused .origin-link CSS rule from src/web/style/content.ts and deletes .origin-link from the style/content.ts page-furniture list in docs/DESIGN.md §5d. No other rule changes, and searching src/ and docs/DESIGN.md for origin-link finds nothing. The related .origin-mark, .origin-name and .origin-row rules are still in use and stay.

Pull #4440 was closed after the check failed on "GET /organizations/new names its phases and answers under 50 ms". That test is in test/cloud-org-apps-timing.test.ts and measures how fast the server answers. Deleting a stylesheet rule nobody uses can't slow that route down, so it looks like a slow moment on the check machine rather than something this change caused. On this branch, which has the latest main merged in, that test passed 3 times out of 3. bun x tsc --noEmit is clean, bun scripts/design-lint.ts reports nothing, and bun test test/design-lint.test.ts passes. The newest commit is empty, pushed only so the forge runs the check again; if the timing test fails a second time, that points to a problem with the test, not this change.

To try it: open any page that shows where an issue was imported from (the .origin-* markup). Nothing should look different, because no markup uses .origin-link any more.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .origin-link rule and its DESIGN.md §5d entry. Nothing in src/ emits the class, and test/web-origins.test.ts and test/web-origin-link.test.ts assert it is absent from rendered pages. The preview answers 200. This is a pure deletion, so it adds no behaviour that needs a test, no new surface and no dependency. It is design-lint clean per the description. Two things to do next: (1) keep pruning other unused classes from the §5d lists the same way, one small pull at a time; (2) the timing test on /organizations/new looks flaky on the check machine, so give it a looser bound or a retry.

commented

This removes the .origin-link style. No markup uses it any more, so it goes from src/web/style/content.ts and from the style/content.ts page-furniture list in docs/DESIGN.md §5d. No other rule changes, so no page should look different.

The latest main is now merged in. The only conflict was the long class-list line in §5d that both sides edited. I resolved it by taking main's version of that line and removing only .origin-link, so the classes main added or removed there stay as main has them. Against main, the diff is the same two small edits as before.

After the merge, searching src/ and docs/DESIGN.md for origin-link finds nothing, bun x tsc --noEmit is clean, bun scripts/design-lint.ts reports nothing, and bun test test/design-lint.test.ts passes.

Pull #4440 failed on the /organizations/new timing test. Deleting an unused style can't slow that page down, and the test passed every time I ran it on this branch, so it looks like a slow moment on the check machine rather than something this change caused.

To try it: open a page that shows where an issue was imported from. It should look exactly as before.

🤖 Generated with Claude Code

Approved

Removes the dead .origin-link rule and its name in DESIGN.md §5d. The only remaining references to origin-link are tests asserting it is absent from rendered markup (test/web-origin-link.test.ts, test/web-origins.test.ts), so nothing styled by it is left. Preview answers 200 and the diff is minimal and in-scope. Two things I would do next: (1) keep the §5d list and content.ts in step with the design-lint check so removals like this are caught automatically; (2) look at the flaky /organizations/new timing test in test/cloud-org-apps-timing.test.ts, which failed #4440 unrelated to styling.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs