Public: anyone can read this; the crew can change it.

.map-counts, .map-pillars, .map-tools leave the stylesheet and docs/DESIGN.md §5d #4499

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the leftover `.map-counts` and `.map-tools` styles, now that part one took both classes out of the markup.

shipped production is serving it deploy 2e641a3

opened this

This removes the leftover .map-counts and .map-tools styles, now that part one took both classes out of the markup.

  • src/web/pages/map.ts: removed from the style block:

- the .map-tools rule; - the .map-counts block, which had nine rules under the "line under a drawing" heading, along with the heading itself; - the #lanes .row-meta .map-counts override.

The singular .map-tool is still used for the zoom buttons, so it stays. The reduced-motion block never named any of these classes, so it is unchanged.

  • docs/DESIGN.md §5d: .map-counts and .map-tools are gone from the pages/map.ts bullet.
  • .map-pillars: there was no rule or §5d entry for it. git grep finds only the id="map-pillars" section in map.ts:1065, which is a different selector and stays. The tests in test/map.test.ts and test/pillars.test.ts that check these classes are absent from the page still pass, unchanged.
  • docs/design/baseline.json: running bun scripts/design-lint.ts --update left the count where it was, so there is nothing to commit.

bun x tsc --noEmit passes, as do bun test on test/design-lint.test.ts, test/map.test.ts and test/pillars.test.ts. The branch is rebased on main, and the design-lint test passes again after the rebase. To try it, open a repository's /map on the preview: the drawing, its zoom buttons and the lanes should look the same as on production.

🤖 Generated with Claude Code

Closes #4239

commented

This removes the leftover .map-counts and .map-tools styles, now that part one took both classes out of the markup.

  • src/web/pages/map.ts: removed from the style block:

- the .map-tools rule; - the .map-counts block, which had nine rules under the "line under a drawing" heading, along with the heading itself; - the #lanes .row-meta .map-counts override.

The singular .map-tool is still used for the zoom buttons, so it stays. The reduced-motion block never named any of these classes, so it is unchanged.

  • docs/DESIGN.md §5d: .map-counts and .map-tools are gone from the pages/map.ts bullet.
  • .map-pillars: there was no rule or §5d entry for it. git grep finds only the id="map-pillars" section in map.ts:1065, which is a different selector and stays. The tests in test/map.test.ts and test/pillars.test.ts that check these classes are absent from the page still pass, unchanged.
  • docs/design/baseline.json: running bun scripts/design-lint.ts --update left the count where it was, so there is nothing to commit.

bun x tsc --noEmit passes, as do bun test on test/design-lint.test.ts, test/map.test.ts and test/pillars.test.ts. The branch is rebased on main, and the design-lint test passes again after the rebase. To try it, open a repository's /map on the preview: the drawing, its zoom buttons and the lanes should look the same as on production.

🤖 Generated with Claude Code

Approved

Pure deletion of dead CSS: no src markup uses .map-counts, .map-tools or .map-pillars as a class (only id=map-pillars, which stays), .map-tool for zoom stays, and the §5d bullet matches. Preview answers 200. Two things next: (1) keep draining the remaining leftover classes in the §5d list the same way; (2) add a test that fails if a removed class name reappears in mapCss, so it cannot drift back.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs