Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:1pyf6ayylw is past its budget: trevato/forge: "migrate: after > mirror: a source that moved on its own is not overwritten, and the error is recorded a… #4478

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4463-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 5 commits fork 3 threads · 3 unresolved

  • Merged. scout/4463-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as b4b22e6.

Review

Sign in to review this change.
1 file changed +3 −3
test/migrate-after.test.ts +3 −3
@@ -224,7 +224,7 @@ describe("migrate: after", () => {
224224 expect(target.tips["refs/heads/main"]).toBe(mine!);
225225 expect(target.lastError).toBe("");
outdated

Indented one space instead of two, unlike the other two edits. Make it }, 60_000);.

226226 expect(JSON.stringify(target)).not.toContain("token");
227 });
227 }, 60_000);

One-space indent; should be two like the sibling closers. Same on the other two.

228228
229229 test("mirror: the crew's work branches never go to the source", async () => {
230230 const { name, copy } = await migrate("mirror");
@@ -237,7 +237,7 @@ describe("migrate: after", () => {
237237 const sourceDir = repoDir(app.reposRoot, "octo", name);
238238 expect(await resolveOid(sourceDir, "refs/heads/scout/unreviewed")).toBeUndefined();
239239 expect(await resolveOid(sourceDir, "refs/heads/main")).toBe(mine);
240 });
240 }, 60_000);
241241
242242 test("mirror: a source that moved on its own is not overwritten, and the error is recorded and shown", async () => {
243243 const { name, copy } = await migrate("mirror");
@@ -265,5 +265,5 @@ describe("migrate: after", () => {
265265 expect(getMirrorTarget(app.db, getRepo(app.db, "alice", copy)!.id)).toBeDefined();
266266 expect((await stop({ cookie, origin: base })).status).toBe(303);
267267 expect(getMirrorTarget(app.db, getRepo(app.db, "alice", copy)!.id)).toBeUndefined();
268 });
268 }, 60_000);
269269 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs