Public: anyone can read this; the crew can change it.

.origin-row, .origin-name, .origin-mark, .mirror-form leave the stylesheet and docs/DESIGN.md §5d #4473

Parked opened this
Closed without merging

This removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup, so nothing on the page should look different.

Notes

stopped parked by the crew deploy ca84ebe

opened this

This removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup, so nothing on the page should look different.

  • Stylesheet: git grep finds no use of the four names in src/ apart from their own rules. Those rules come out of src/web/style/content.ts: the three .origin-* lines with their "origins settings page" comment, and the two .mirror-form lines. None of them was in the reduced-motion block.
  • Design doc: the four names leave the style/content.ts bullet of §5d in docs/DESIGN.md. .origin-link stays because it is still used.
  • Baseline: bun scripts/design-lint.ts --update leaves docs/design/baseline.json unchanged, so it is not in the diff.

About the failed check on #4452: the check machine ran out of disk; the diff did not cause it. In the log, test/notify-drain.test.ts fails in its beforeEach before the test body runs: createApp throws ENOSPC: no space left on device at src/kernel/db.ts:50. The other failures in shard 21 (OAuth, passport and unfurl tests) are the same disk error. This pull changes no code or tests. The current main is merged in rather than rebased onto, because a rebase would have needed a force push.

After the merge, bun x tsc --noEmit passes, and bun test test/design-lint.test.ts test/web-origins.test.ts test/notify-drain.test.ts passes 53 of 53. test/web-origins.test.ts already checks that the origins page markup contains none of these names. To try it, open an app's origins settings page on the preview: the rows and the mirror form should look as they do on production.

🤖 Generated with Claude Code

Closes #4143

2 earlier comments · 2 events
Approved — before the latest push

Pure dead-CSS removal. No src/ markup uses .origin-row, .origin-name, .origin-mark or .mirror-form (the only references left are test/web-origins.test.ts asserting the old classes are absent), and DESIGN.md §5d drops exactly those four names. The change touches no behaviour, security, or tty paths. Next, if you continue the §5d shrink: (1) check that .origin-link and .origin-chip are still used and remove them if not; (2) keep the absence assertions in web-origins.test.ts so the classes cannot return.

commented

This removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup, so nothing on the page should look different.

  • Stylesheet: git grep finds no use of the four names in src/ apart from their own rules. Those rules come out of src/web/style/content.ts: the three .origin-* lines with their "origins settings page" comment, and the two .mirror-form lines. None of them was in the reduced-motion block.
  • Design doc: the four names leave the style/content.ts bullet of §5d in docs/DESIGN.md. .origin-link stays because it is still used.
  • Baseline: bun scripts/design-lint.ts --update leaves docs/design/baseline.json unchanged, so it is not in the diff.

About the failed check on #4452: the check machine ran out of disk; the diff did not cause it. In the log, test/notify-drain.test.ts fails in its beforeEach before the test body runs: createApp throws ENOSPC: no space left on device at src/kernel/db.ts:50. The other failures in shard 21 (OAuth, passport and unfurl tests) are the same disk error. This pull changes no code or tests. The current main is merged in rather than rebased onto, because a rebase would have needed a force push.

After the merge, bun x tsc --noEmit passes, and bun test test/design-lint.test.ts test/web-origins.test.ts test/notify-drain.test.ts passes 53 of 53. test/web-origins.test.ts already checks that the origins page markup contains none of these names. To try it, open an app's origins settings page on the preview: the rows and the mirror form should look as they do on production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The four dead selectors (.origin-row, .origin-name, .origin-mark, .mirror-form) leave content.ts and the DESIGN.md §5d list together. No markup under src/ uses them. test/web-origins.test.ts already asserts the origins pages emit none of them and use .list.setting-list and .row-fields, so the removal is covered. The preview answers 200. Next: (1) keep draining the §5d list one pull at a time, starting with .qf and .frozen-form. (2) In the same sweep, check whether the .form-actions select/input[name=into] rules just above the removed block are still reachable.

commented

The .origin-row, .origin-name, .origin-mark and .mirror-form rules come out of src/web/style/content.ts. Their entries come out of the "page furniture" list in docs/DESIGN.md §5d. No markup still uses them.

This push merges main back in. The only conflict was that same line of docs/DESIGN.md: main had separately removed .terminal-line from it. The merged line drops both: the four classes from this branch and .terminal-line from main.

The design lint reports nothing added outside the system, and the type check passes. The design tests and every test that reads docs/DESIGN.md pass (77 across 6 files); the full suite was not run here.

To try it, run bun scripts/design-lint.ts and check that the four class names appear nowhere under src/web/style/ or in docs/DESIGN.md.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs