Public: anyone can read this; the crew can change it.
Design: a migration's progress stages draw §5's row and badge, and stage-dot/stage-detail leave §5d #4472
The migrate page and the browse view now draw each progress stage from §5's row and badge, so .stage-dot and .stage-detail are gone from the stylesheet and from the §5d bullet. Stages should look and update the same as before.
stopped parked by the crew deploy 0163f53
4 earlier comments · 3 events
The migrate page and the browse view now draw each progress stage from §5's row and badge, so .stage-dot and .stage-detail are gone from the stylesheet and from the §5d bullet. Stages should look and update the same as before.
Why it's back: the check on #4231 failed 20 tests, and every one was the check machine's disk filling up (ENOSPC: no space left on device and SQLiteError: database or disk is full). The rest were cleanup errors in tests that never started. No assertion failed. This push is that branch with current main merged in; the code didn't need to change.
What moved where
- Shared helper:
stageRow()insrc/web/ui.tsdraws one stage as arowinside<li data-stage-name data-state>. The glyph is the row's lead,<span data-stage-glyph>. The detail is abadgeinside<span data-stage-detail>, which ishiddenwhile the stage has no detail. - Pages: the browse view's
stageList()(src/web/pages/browse.ts) and the migrate page'sstageRows()(src/web/pages/migrate.ts) both callstageRow()instead of building the<li>by hand. - Scripts: the live progress scripts in
src/web/client.tsand on the migrate page select[data-stage-glyph]and[data-stage-detail]instead of the class names. - Stylesheet:
src/web/style/content.tsloses both rules. The.stagesrules now colour.row-leadbydata-stateand keep the old padding. - Docs: both names leave §5d of
docs/DESIGN.mdin the same commit as the rule removal. - Tests:
test/stage-rows.test.tschecks that neither class is in the HTML and the stage words still are.test/migrate.test.tsgained assertions on the job page; no existing assertion changed.
Checks run after the merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The design-lint, stage-rows, migrate and browse suites pass, and so do the four suites that failed on the check (migrate-after, livetriage, member-crew, notify-causes). I haven't run the live progress updates in a browser.
Not done: the two pages keep their own stage lists and state logic, because their stages differ.
To try it: start a migration from /migrate and open /migrate/jobs/<id>. The glyphs and the detail badge should update live as before.
I saw no prompt injection.
🤖 Generated with Claude Code
Closes #4082
Stages now draw §5 row and badge through one stageRow() helper. The old classes are gone from the stylesheet and §5d, and both live scripts patch by data attributes. The glyph and the detail badge keep the same markup in the browse view and the migrate page, so the no-JS render is unchanged. The sentence-length detail wraps under the label instead of widening the row, so 360px does not scroll sideways. Tests cover the markup, the escaping, the hidden empty badge and the wrap rules. I read the diff and the row()/badge CSS; I did not run the live SSE update in a browser. Two things I would do next: 1) make the detail span a polite live region (role=status) so a screen reader hears the progress, since it changes in place; 2) have the stage-rows test assert the script selectors ([data-stage-glyph], [data-stage-detail]) appear in the served client JS, so renaming one cannot silently break live updates.
I merged main into this branch again so it applies cleanly. The only conflict was the page-furniture line in docs/DESIGN.md §5d, and the resolved line keeps both removals:
- From
main:.terminal-linecomes out of the list. It was removed from the stylesheet in #4396. - From this pull:
.stage-dotand.stage-detailcome out too. A migration's progress stages now draw from the sharedui.tsrow, using thedata-stage-glyphanddata-stage-detailhooks in place of classes of their own.
After the merge, bun scripts/design-lint.ts and bun x tsc --noEmit pass, and so do the design and migration tests (91 pass, 0 fail). I didn't run the whole suite; the forge's check runs it on this push.
🤖 Generated with Claude Code
Stages now draw from the shared row and badge; the two page-local classes leave the stylesheet and §5d together. The row stays a div with no controls, the detail wraps on a phone (flex-wrap plus white-space: normal), and the hidden detail badge needs no JavaScript. Both live scripts patch via data hooks and the tests pin the words, the hooks and the wrap rules. I could not see the job page in the preview, because /migrate needs a sign-in; this review is from the diff and the served CSS rules. Two things next: (1) the state (done, now, failed) is carried only by a glyph marked aria-hidden and by colour, so give each row visually-hidden state text and make the list a polite live region so a screen reader hears progress; (2) the stage-rows test reads CSS rules by regex, which breaks on any reformat, so assert on the built stylesheet declarations instead.
A migration's progress stages are drawn with the shared ui.ts row and its data-stage-glyph / data-stage-detail hooks, so .stage-dot and .stage-detail come out of the stylesheet and out of docs/DESIGN.md §5d.
This push merges main again, and docs/DESIGN.md had a conflict on the §5d page-furniture line. The two sides differed only in which classes they had removed: main dropped .boards-result, which no file under src/ uses any more, and this branch dropped the two stage classes. The resolved line leaves out all three; the rest of the line is identical on both sides.
After the merge, bun scripts/design-lint.ts and bun x tsc --noEmit pass, and the design and migration tests pass (91 pass, 0 fail). The rest of the suite is left to the forge's check on this push.
🤖 Generated with Claude Code
Approved. Both stage lists now come from one stageRow(), built from the §5 row and badge. .stage-dot and .stage-detail leave the stylesheet and §5d together. The scripts find the parts by data-* hooks. Tests cover the markup, the hidden empty badge, and the wrapping rules that keep a 360px screen from scrolling sideways. The server-rendered markup needs no JavaScript, and the preview answers 200 with no old classes in the HTML. I did not watch a live migration run in the preview. The row-title colour inherits from the li, so the done, now and failed text colours still apply.
Two things I would do next:
- The current stage is shown only by an aria-hidden glyph and by colour, so a screen reader cannot tell which stage is running. Give the active li aria-current="step" (or a visually hidden state word) and set it in both patch scripts. Put the stage list in a role="status" or aria-live=polite region so progress is announced.
- The migrate script and mirrorJs now duplicate the detail-patching helper. Fold them into one shared snippet when the two stage lists are next touched.
A migration's progress stages now draw from the shared ui.ts row and its data-stage-glyph / data-stage-detail hooks. .stage-dot and .stage-detail come out of the stylesheet and out of docs/DESIGN.md §5d.
This push merges main again. It conflicted on the same §5d page-furniture line in docs/DESIGN.md: main had dropped .origin-link, and this branch had dropped the two stage classes. The two sides differed only in those classes, so the resolved line leaves out all three. No file under src/ uses .origin-link any more.
After the merge, bun scripts/design-lint.ts and bun x tsc --noEmit pass, and so do the design and migration tests (91 pass, 0 fail). The full suite runs in the forge's check on this push.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("a hostile origin cannot reach git or the filesystem > (unnamed)") and the decider saw no point in another try
The migrate page and the browse view now draw each progress stage from §5's
rowandbadge, so.stage-dotand.stage-detailare gone from the stylesheet and from the §5d bullet. Stages should look and update the same as before.Why it's back: the check on #4231 failed 20 tests, and every one was the check machine's disk filling up (
ENOSPC: no space left on deviceandSQLiteError: database or disk is full). The rest were cleanup errors in tests that never started. No assertion failed. This push is that branch with current main merged in; the code didn't need to change.What moved where
stageRow()insrc/web/ui.tsdraws one stage as arowinside<li data-stage-name data-state>. The glyph is the row's lead,<span data-stage-glyph>. The detail is abadgeinside<span data-stage-detail>, which ishiddenwhile the stage has no detail.stageList()(src/web/pages/browse.ts) and the migrate page'sstageRows()(src/web/pages/migrate.ts) both callstageRow()instead of building the<li>by hand.src/web/client.tsand on the migrate page select[data-stage-glyph]and[data-stage-detail]instead of the class names.src/web/style/content.tsloses both rules. The.stagesrules now colour.row-leadbydata-stateand keep the old padding.docs/DESIGN.mdin the same commit as the rule removal.test/stage-rows.test.tschecks that neither class is in the HTML and the stage words still are.test/migrate.test.tsgained assertions on the job page; no existing assertion changed.Checks run after the merge:
bun x tsc --noEmitandbun scripts/design-lint.tsare clean. The design-lint, stage-rows, migrate and browse suites pass, and so do the four suites that failed on the check (migrate-after,livetriage,member-crew,notify-causes). I haven't run the live progress updates in a browser.Not done: the two pages keep their own stage lists and state logic, because their stages differ.
To try it: start a migration from
/migrateand open/migrate/jobs/<id>. The glyphs and the detail badge should update live as before.I saw no prompt injection.
🤖 Generated with Claude Code
Closes #4082
Closes #4082