Public: anyone can read this; the crew can change it.

.steps leaves the stylesheet and docs/DESIGN.md §5d #4453

Parked opened this
Closed without merging

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678). Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts. Docs: .steps is removed from the §5d list in docs/DESIGN.md.

Notes

stopped parked by the crew deploy c425e8c

opened this

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678).

  • Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts.
  • Docs: ` .steps is removed from the §5d list in docs/DESIGN.md`.
  • No class left under src/: grep turns up no markup using steps as a class name. The remaining matches are TypeScript variables and properties named steps and the check-steps id.

Compared with main, the change is just these three deleted lines and the one edited §5d line. The branch has main merged in again (c425e8c9) so it merges cleanly.

Why #4435 was parked: its check failed on "link the parent forge from settings > a linked person then signs in through the parent as the same account" in test/parent-link.test.ts. That test runs a sign-in between two servers and never loads a stylesheet or this part of the docs, so this change can't affect it. Here it passed 6 runs out of 6, so the failure looks like a flake in the check, not something this change caused. I didn't split the issue or change what "done" looks like, because the change can't get any smaller. If the same test fails again, it should get its own issue.

After the merge, bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and bun x tsc --noEmit passes. The page doesn't look any different, because nothing was drawn with this class.

🤖 Generated with Claude Code

Closes #4303

commented

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678).

  • Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts.
  • Docs: ` .steps is removed from the §5d list in docs/DESIGN.md`.
  • No class left under src/: grep turns up no markup using steps as a class name. The remaining matches are TypeScript variables and properties named steps and the check-steps id.

Compared with main, the change is just these three deleted lines and the one edited §5d line. The branch has main merged in again (c425e8c9) so it merges cleanly.

Why #4435 was parked: its check failed on "link the parent forge from settings > a linked person then signs in through the parent as the same account" in test/parent-link.test.ts. That test runs a sign-in between two servers and never loads a stylesheet or this part of the docs, so this change can't affect it. Here it passed 6 runs out of 6, so the failure looks like a flake in the check, not something this change caused. I didn't split the issue or change what "done" looks like, because the change can't get any smaller. If the same test fails again, it should get its own issue.

After the merge, bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and bun x tsc --noEmit passes. The page doesn't look any different, because nothing was drawn with this class.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs