Public: anyone can read this; the crew can change it.
.origin-row, .origin-name, .origin-mark, .mirror-form leave the stylesheet and docs/DESIGN.md §5d #4452
Removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.
stopped parked by the crew deploy a189a57
Removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.
- Stylesheet:
git grepfinds no use of the four names left insrc/apart from their own rules. Those rules come out ofsrc/web/style/content.ts: the three.origin-*lines with their "origins settings page" comment, and the two.mirror-formlines. None of them was in the reduced-motion block. - Design doc: the four names leave the
style/content.tsbullet of §5d indocs/DESIGN.md..origin-linkstays because it is still used. - Baseline: I ran
bun scripts/design-lint.ts --updateanddocs/design/baseline.jsoncame out unchanged, so it is not in the diff. - Tests:
test/web-origins.test.tsalready checks that the origins page markup contains none of these names, and it still passes. I did not change it.
The branch is rebased on the current main. bun x tsc --noEmit passes. bun test test/design-lint.test.ts test/web-origins.test.ts passed 45 of 45 before the rebase, and test/design-lint.test.ts ran again after it with no failures. To try it, open an app's origins settings page on the preview: rows and the mirror form should look as they do on production.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("the drain page > a drain started the way main.ts starts it, with the notifier stopped beside it, is still paged") and the decider saw no point in another try
Removes the last of the origin settings page's own classes (
.origin-row,.origin-name,.origin-mark,.mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.git grepfinds no use of the four names left insrc/apart from their own rules. Those rules come out ofsrc/web/style/content.ts: the three.origin-*lines with their "origins settings page" comment, and the two.mirror-formlines. None of them was in the reduced-motion block.style/content.tsbullet of §5d indocs/DESIGN.md..origin-linkstays because it is still used.bun scripts/design-lint.ts --updateanddocs/design/baseline.jsoncame out unchanged, so it is not in the diff.test/web-origins.test.tsalready checks that the origins page markup contains none of these names, and it still passes. I did not change it.The branch is rebased on the current
main.bun x tsc --noEmitpasses.bun test test/design-lint.test.ts test/web-origins.test.tspassed 45 of 45 before the rebase, andtest/design-lint.test.tsran again after it with no failures. To try it, open an app's origins settings page on the preview: rows and the mirror form should look as they do on production.🤖 Generated with Claude Code
Closes #4143