Public: anyone can read this; the crew can change it.

.origin-row, .origin-name, .origin-mark, .mirror-form leave the stylesheet and docs/DESIGN.md §5d #4452

Parked opened this
Closed without merging

Removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.

Notes

stopped parked by the crew deploy a189a57

opened this

Removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.

  • Stylesheet: git grep finds no use of the four names left in src/ apart from their own rules. Those rules come out of src/web/style/content.ts: the three .origin-* lines with their "origins settings page" comment, and the two .mirror-form lines. None of them was in the reduced-motion block.
  • Design doc: the four names leave the style/content.ts bullet of §5d in docs/DESIGN.md. .origin-link stays because it is still used.
  • Baseline: I ran bun scripts/design-lint.ts --update and docs/design/baseline.json came out unchanged, so it is not in the diff.
  • Tests: test/web-origins.test.ts already checks that the origins page markup contains none of these names, and it still passes. I did not change it.

The branch is rebased on the current main. bun x tsc --noEmit passes. bun test test/design-lint.test.ts test/web-origins.test.ts passed 45 of 45 before the rebase, and test/design-lint.test.ts ran again after it with no failures. To try it, open an app's origins settings page on the preview: rows and the mirror form should look as they do on production.

🤖 Generated with Claude Code

Closes #4143

commented

Removes the last of the origin settings page's own classes (.origin-row, .origin-name, .origin-mark, .mirror-form) from the stylesheet and from the design doc. Part one (#3943) already took them out of the markup. Nothing on the page should look different.

  • Stylesheet: git grep finds no use of the four names left in src/ apart from their own rules. Those rules come out of src/web/style/content.ts: the three .origin-* lines with their "origins settings page" comment, and the two .mirror-form lines. None of them was in the reduced-motion block.
  • Design doc: the four names leave the style/content.ts bullet of §5d in docs/DESIGN.md. .origin-link stays because it is still used.
  • Baseline: I ran bun scripts/design-lint.ts --update and docs/design/baseline.json came out unchanged, so it is not in the diff.
  • Tests: test/web-origins.test.ts already checks that the origins page markup contains none of these names, and it still passes. I did not change it.

The branch is rebased on the current main. bun x tsc --noEmit passes. bun test test/design-lint.test.ts test/web-origins.test.ts passed 45 of 45 before the rebase, and test/design-lint.test.ts ran again after it with no failures. To try it, open an app's origins settings page on the preview: rows and the mirror form should look as they do on production.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("the drain page > a drain started the way main.ts starts it, with the notifier stopped beside it, is still paged") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs