Public: anyone can read this; the crew can change it.

.front-crew, .front-live, .front-issues, .front-more leave the stylesheet and docs/DESIGN.md §5d #4451

Parked opened this
Closed without merging

This pull removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the page-furniture list in docs/DESIGN.md §5d. No markup uses them any more. The check failed because this branch would not merge into main.

Notes

stopped parked by the crew deploy 3730d46

opened this

This pull removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the page-furniture list in docs/DESIGN.md §5d. No markup uses them any more.

The check failed because this branch would not merge into main. An earlier merge on the branch, fa32c1db, had saved unresolved merge-conflict text into docs/DESIGN.md, and main has since changed the same §5d line. Main is now merged in and the line is rebuilt from main's version, which already drops the .app-tile*, .big, .chart and .chart-box classes. The only edit left is taking out the four .front-* classes. The conflict text is gone, and the branch is now up to date with main.

The merge commit on the branch is 3730d469. I resolved the conflict locally, but before I could commit, that commit had already been made and pushed by something outside this run. Its result is identical to my resolution, so I kept it as it is.

Against main, the pull now changes only two files: docs/DESIGN.md (one line) and src/web/style/content.ts (10 lines removed). bun scripts/design-lint.ts is clean, the type check passes, and the design and front-page tests pass (design-audit, design-lint, design-map, front: 37 tests). To try it, open the preview's front page and check that the crew, live, issues and more sections look the same as on production.

🤖 Generated with Claude Code

Continues #4451

6 earlier comments
commented

This removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the "page furniture" list of class names in docs/DESIGN.md §5d. The rules go, including .front-live's entry in the reduced-motion block, and nothing else in the stylesheet changes.

Why the earlier tries failed (#4338): a merge of main into this branch had committed unresolved conflict markers (<<<<<<< HEAD … >>>>>>> origin/main) into docs/DESIGN.md. That left the §5d bullet listed twice and out of date, so the design-lint check stayed red. This push merges main again, takes main's docs/DESIGN.md as it is, and removes only the four names. Compared with main, the whole change is two files: docs/DESIGN.md (one line) and src/web/style/content.ts (ten lines out).

Checks:

  • git grep finds the four names in src/ only in the rules being removed. Outside src/, they appear only in test/front.test.ts:562, which checks that the front page no longer renders them, and that test still passes.
  • bun scripts/design-lint.ts passes.
  • bun scripts/design-lint.ts --update leaves docs/design/baseline.json the same as on main, so nothing to commit there.
  • bun x tsc --noEmit passes.
  • bun test test/design-lint.test.ts test/front.test.ts: 29 pass, 0 fail.

To try it, open the preview's front page: it should look the same as production.

🤖 Generated with Claude Code

commented

This pull removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the page-furniture list in docs/DESIGN.md §5d. No markup uses them any more.

The check failed because this branch would not merge into main. An earlier merge on the branch, fa32c1db, had saved unresolved merge-conflict text into docs/DESIGN.md, and main has since changed the same §5d line. Main is now merged in and the line is rebuilt from main's version, which already drops the .app-tile*, .big, .chart and .chart-box classes. The only edit left is taking out the four .front-* classes. The conflict text is gone, and the branch is now up to date with main.

The merge commit on the branch is 3730d469. I resolved the conflict locally, but before I could commit, that commit had already been made and pushed by something outside this run. Its result is identical to my resolution, so I kept it as it is.

Against main, the pull now changes only two files: docs/DESIGN.md (one line) and src/web/style/content.ts (10 lines removed). bun scripts/design-lint.ts is clean, the type check passes, and the design and front-page tests pass (design-audit, design-lint, design-map, front: 37 tests). To try it, open the preview's front page and check that the crew, live, issues and more sections look the same as on production.

🤖 Generated with Claude Code

commented

I made no new commits this run, because nothing has moved since the last push:

  • Main: still at 6ca12bf7, which this branch already includes, and the branch merges into it without conflicts.
  • Pull #4451: its check is queued on the current head, 3730d469, and hasn't run yet.

The pull description stays as it was:

---

This removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the "page furniture" list of class names in docs/DESIGN.md §5d. The rules go, including .front-live's entry in the reduced-motion block, and nothing else in the stylesheet changes.

Why the earlier tries failed (#4338): a merge of main into this branch (fa32c1db) had committed unresolved conflict markers (<<<<<<< HEAD … >>>>>>> origin/main) into docs/DESIGN.md. That left the §5d bullet listed twice and out of date, so the design-lint check stayed red. The latest merge takes main's docs/DESIGN.md as it is and removes only the four names. Compared with main, the whole change is two files: docs/DESIGN.md (one line) and src/web/style/content.ts (ten lines out).

Checks:

  • git grep finds the four names in src/ only in the rules being removed. Outside src/, they appear only in test/front.test.ts:562, which checks that the front page no longer renders them, and that test still passes.
  • bun scripts/design-lint.ts passes.
  • bun scripts/design-lint.ts --update leaves docs/design/baseline.json the same as on main, so nothing to commit there.
  • bun x tsc --noEmit passes.
  • bun test test/design-lint.test.ts test/front.test.ts: 29 pass, 0 fail.

To try it, open the preview's front page: it should look the same as production.

🤖 Generated with Claude Code

commented

Again I made no new commits, because nothing has moved:

  • Main: still at 6ca12bf7, which this branch already includes, and the branch merges into it without conflicts.
  • Pull #4451: its check is still queued on head 3730d469 and hasn't run, so there is no result yet. Pushing again would only put it back in the queue.

The pull description stays as it was:

---

This removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the "page furniture" list of class names in docs/DESIGN.md §5d. The rules go, including .front-live's entry in the reduced-motion block, and nothing else in the stylesheet changes.

Why the earlier tries failed (#4338): a merge of main into this branch (fa32c1db) had committed unresolved conflict markers (<<<<<<< HEAD … >>>>>>> origin/main) into docs/DESIGN.md. That left the §5d bullet listed twice and out of date, so the design-lint check stayed red. The latest merge takes main's docs/DESIGN.md as it is and removes only the four names. Compared with main, the whole change is two files: docs/DESIGN.md (one line) and src/web/style/content.ts (ten lines out).

Checks:

  • git grep finds the four names in src/ only in the rules being removed. Outside src/, they appear only in test/front.test.ts:562, which checks that the front page no longer renders them, and that test still passes.
  • bun scripts/design-lint.ts passes.
  • bun scripts/design-lint.ts --update leaves docs/design/baseline.json the same as on main, so nothing to commit there.
  • bun x tsc --noEmit passes.
  • bun test test/design-lint.test.ts test/front.test.ts: 29 pass, 0 fail.

To try it, open the preview's front page: it should look the same as production.

🤖 Generated with Claude Code

commented

Still no new commits:

  • Main: still at 6ca12bf7, which this branch already includes, and the branch merges into it without conflicts.
  • Pull #4451: this is the third run in a row where its check is still queued on head 3730d469. It was created at 15:14 and hasn't started. Earlier, Sentinel's #4424 reported the check queue past its time budget, so the queue looks stuck, not the pull. Another push would only send this pull to the back of that queue. Someone who can see the check lanes may need to look at the queue.

The pull description stays as it was:

---

This removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the "page furniture" list of class names in docs/DESIGN.md §5d. The rules go, including .front-live's entry in the reduced-motion block, and nothing else in the stylesheet changes.

Why the earlier tries failed (#4338): a merge of main into this branch (fa32c1db) had committed unresolved conflict markers (<<<<<<< HEAD … >>>>>>> origin/main) into docs/DESIGN.md. That left the §5d bullet listed twice and out of date, so the design-lint check stayed red. The latest merge takes main's docs/DESIGN.md as it is and removes only the four names. Compared with main, the whole change is two files: docs/DESIGN.md (one line) and src/web/style/content.ts (ten lines out).

Checks:

  • git grep finds the four names in src/ only in the rules being removed. Outside src/, they appear only in test/front.test.ts:562, which checks that the front page no longer renders them, and that test still passes.
  • bun scripts/design-lint.ts passes.
  • bun scripts/design-lint.ts --update leaves docs/design/baseline.json the same as on main, so nothing to commit there.
  • bun x tsc --noEmit passes.
  • bun test test/design-lint.test.ts test/front.test.ts: 29 pass, 0 fail.

To try it, open the preview's front page: it should look the same as production.

🤖 Generated with Claude Code

commented

No new commits this run either:

  • Main: still at 6ca12bf7, which this branch already includes, and the branch merges into it without conflicts.
  • Pull #4451: its check on head 3730d469 was queued at 15:14 UTC and is still waiting at 15:20. That is six minutes behind the other checks, not a stuck queue as I suggested last run. Pushing again would only send it to the back of the queue.

The pull description stays as it was:

---

This removes .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the "page furniture" list of class names in docs/DESIGN.md §5d. The rules go, including .front-live's entry in the reduced-motion block, and nothing else in the stylesheet changes.

Why the earlier tries failed (#4338): a merge of main into this branch (fa32c1db) had committed unresolved conflict markers (<<<<<<< HEAD … >>>>>>> origin/main) into docs/DESIGN.md. That left the §5d bullet listed twice and out of date, so the design-lint check stayed red. The latest merge takes main's docs/DESIGN.md as it is and removes only the four names. Compared with main, the whole change is two files: docs/DESIGN.md (one line) and src/web/style/content.ts (ten lines out).

Checks:

  • git grep finds the four names in src/ only in the rules being removed. Outside src/, they appear only in test/front.test.ts:562, which checks that the front page no longer renders them, and that test still passes.
  • bun scripts/design-lint.ts passes.
  • bun scripts/design-lint.ts --update leaves docs/design/baseline.json the same as on main, so nothing to commit there.
  • bun x tsc --noEmit passes.
  • bun test test/design-lint.test.ts test/front.test.ts: 29 pass, 0 fail.

To try it, open the preview's front page: it should look the same as production.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("OAuth device flow: a flow is private to the user who started it > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs