Public: anyone can read this; the crew can change it.

.live-toggle leaves the stylesheet and docs/DESIGN.md §5d #4446

Parked opened this
Closed without merging

The .live-toggle rules are gone from src/web/style/content.ts, and the name is gone from the style/content.ts, search results bullet in docs/DESIGN.md §5d. Nothing in src/ used the class any more.

Notes

stopped parked by the crew deploy 0d6e6de

opened this

The .live-toggle rules are gone from src/web/style/content.ts, and the name is gone from the style/content.ts, search results bullet in docs/DESIGN.md §5d. Nothing in src/ used the class any more. The search page's liveToggle (src/web/pages/search.ts:428) is just a variable name: the live line it draws uses §5's row small muted classes, and the existing test in test/web-code.test.ts checks that live-toggle never appears on the page. There was no reduced-motion rule for the class.

bun scripts/design-lint.ts --update left the count where it was, so docs/design/baseline.json has no diff and is not part of this pull.

The check on #4430 failed 15 of 5456 tests. Every failure was in the setup or teardown of three suites that have nothing to do with CSS: test/origins-reconnect.test.ts, test/own-session.test.ts and test/planner-closes-pull.test.ts. All three pass here, test/origins-reconnect.test.ts four times in a row. So those failures are probably the check machine's, not this change's, and I left the code as it was.

This push merges current main into the branch, because a rebase would have needed a force push. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/design-lint.test.ts pass after the merge.

To try it, search while signed in: the "Origins are searched from the cache" line should look the same as before.

🤖 Generated with Claude Code

Closes #4196

commented

The .live-toggle rules are gone from src/web/style/content.ts, and the name is gone from the style/content.ts, search results bullet in docs/DESIGN.md §5d. Nothing in src/ used the class any more. The search page's liveToggle (src/web/pages/search.ts:428) is just a variable name: the live line it draws uses §5's row small muted classes, and the existing test in test/web-code.test.ts checks that live-toggle never appears on the page. There was no reduced-motion rule for the class.

bun scripts/design-lint.ts --update left the count where it was, so docs/design/baseline.json has no diff and is not part of this pull.

The check on #4430 failed 15 of 5456 tests. Every failure was in the setup or teardown of three suites that have nothing to do with CSS: test/origins-reconnect.test.ts, test/own-session.test.ts and test/planner-closes-pull.test.ts. All three pass here, test/origins-reconnect.test.ts four times in a row. So those failures are probably the check machine's, not this change's, and I left the code as it was.

This push merges current main into the branch, because a rebase would have needed a force push. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/design-lint.test.ts pass after the merge.

To try it, search while signed in: the "Origins are searched from the cache" line should look the same as before.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("migrate: after > mirror: the crew's work branches never go to the source") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs