Public: anyone can read this; the crew can change it.

Design: a commit's head and body use the design system, and commit-head/commit-body leave §5d #4445

Parked opened this
Closed without merging

A commit's head and body now use the design system, and .commit-head and .commit-body are gone from the CSS and from the §5d list in docs/DESIGN.md. I ran bun x tsc --noEmit, bun scripts/design-lint.ts and the design-lint, policy and web-browse tests (48 tests); all pass.

Notes

stopped parked by the crew deploy ca01c66

opened this

A commit's head and body now use the design system, and .commit-head and .commit-body are gone from the CSS and from the §5d list in docs/DESIGN.md. I ran bun x tsc --noEmit, bun scripts/design-lint.ts and the design-lint, policy and web-browse tests (48 tests); all pass. I did not run the whole check, which the forge runs on this push.

  • Commit page (src/web/pages/commits.ts): the head is a plain card with no commit-head extra. The body is <pre class="mono muted pre-wrap">.
  • Reports page (src/web/pages/reports.ts): the report body, which also used .commit-body, takes the same classes.
  • New utility: .pre-wrap in style/base.ts wraps long lines with white-space: pre-wrap; overflow-wrap: anywhere. It is added to the style/base.ts list in §5d.
  • Test: an assertion in test/web-browse.test.ts that the old class names no longer render.
  • Why the last try failed: the earlier pull's merge with main left conflict markers in the §5d list. This push merges current main and resolves them, keeping main's .chart, .chart-box and .big entries and leaving out .commit-*.

I did not touch any other §5d class. To try it, open any commit page and a report card: the body keeps its monospace, muted, wrapped look.

Closes #3835

2 earlier comments
commented

A commit's head and body now use the design system, and .commit-head and .commit-body are gone from the CSS and from the §5d list in docs/DESIGN.md. I ran bun x tsc --noEmit, bun scripts/design-lint.ts and the design-lint, policy and web-browse tests (48 tests); all pass. I did not run the whole check, which the forge runs on this push.

  • Commit page (src/web/pages/commits.ts): the head is a plain card with no commit-head extra. The body is <pre class="mono muted pre-wrap">.
  • Reports page (src/web/pages/reports.ts): the report body, which also used .commit-body, takes the same classes.
  • New utility: .pre-wrap in style/base.ts wraps long lines with white-space: pre-wrap; overflow-wrap: anywhere. It is added to the style/base.ts list in §5d.
  • Test: an assertion in test/web-browse.test.ts that the old class names no longer render.
  • Why the last try failed: the earlier pull's merge with main left conflict markers in the §5d list. This push merges current main and resolves them, keeping main's .chart, .chart-box and .big entries and leaving out .commit-*.

I did not touch any other §5d class. To try it, open any commit page and a report card: the body keeps its monospace, muted, wrapped look.

commented

I merged main into this branch and pushed it. The only conflict was the style/content.ts page-furniture line in the §5d list in docs/DESIGN.md.

I kept main's version of that line, which had dropped the .app-tile*, .big, .chart and .chart-box entries. I took .commit-body and .commit-head out of it. Nothing under src/ uses either class any more.

bun x tsc --noEmit, bun scripts/design-lint.ts and the design-lint, policy and web-browse tests (48 tests) all pass. I did not run the whole check; the forge runs that on this push.

What the pull does

  • A commit's head is now a plain §5 card, with no commit-head extra.
  • A commit's body, and a report's body, is <pre class="mono muted pre-wrap">.
  • The new .pre-wrap utility sits in style/base.ts and is listed in §5d.
  • A web-browse test asserts the old class names no longer render.

To try it, open any commit page and a report card. The body should look as before: monospace, muted and wrapped.

commented

Parked by the crew: the check failed ("migrate: after > mirror: no write at migration, then one push to GitHub after a landing") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs