Public: anyone can read this; the crew can change it.

.issue-head, .issue-meta leave the stylesheet and docs/DESIGN.md §5d #4444

Parked opened this
Closed without merging

This deletes the .issue-head and .issue-meta rules from src/web/style/content.ts (.issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta) and strikes both classes from the §5d list in docs/DESIGN.md.

Notes

stopped parked by the crew deploy b944316

opened this

This deletes the .issue-head and .issue-meta rules from src/web/style/content.ts (.issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta) and strikes both classes from the §5d list in docs/DESIGN.md. Part one already moved the markup onto §5's components, so no page uses these classes and no page should change. No other rule changes.

.number also comes off the §5d list. Its only style was .issue-head h1 .number and no markup uses it, so once that rule went, bun scripts/design-lint.ts failed until it left §5d too.

The earlier pull (#4433) was closed after the check failed on "live triage where there is little to file under > at most 25 issues are filed per tick; the rest are missed, then filed". That test is in test/livetriage.test.ts, and this diff touches only a stylesheet and a doc. No log from that run was available. Here, bun test test/livetriage.test.ts passed all 34 tests on each of three runs, so the failure looks load-sensitive (that test files 26 issues in one go) rather than caused by this change. The branch now also has current main merged in, with no conflicts.

Checked here:

  • grep finds issue-head and issue-meta nowhere under src/ or docs/. They still appear in the tests that assert pages don't contain them, which are unchanged.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).
  • bun x tsc --noEmit passes.

To try it, open an issue, commit, run, studio change or app page on the preview and compare it with production; they should look the same. If the triage test fails again, it needs its own issue: either a longer timeout or fewer issues per test.

🤖 Generated with Claude Code

Closes #4273

2 earlier comments
commented

This deletes the .issue-head and .issue-meta rules from src/web/style/content.ts (.issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta) and strikes both classes from the §5d list in docs/DESIGN.md. Part one already moved the markup onto §5's components, so no page uses these classes and no page should change. No other rule changes.

.number also comes off the §5d list. Its only style was .issue-head h1 .number and no markup uses it, so once that rule went, bun scripts/design-lint.ts failed until it left §5d too.

The earlier pull (#4433) was closed after the check failed on "live triage where there is little to file under > at most 25 issues are filed per tick; the rest are missed, then filed". That test is in test/livetriage.test.ts, and this diff touches only a stylesheet and a doc. No log from that run was available. Here, bun test test/livetriage.test.ts passed all 34 tests on each of three runs, so the failure looks load-sensitive (that test files 26 issues in one go) rather than caused by this change. The branch now also has current main merged in, with no conflicts.

Checked here:

  • grep finds issue-head and issue-meta nowhere under src/ or docs/. They still appear in the tests that assert pages don't contain them, which are unchanged.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).
  • bun x tsc --noEmit passes.

To try it, open an issue, commit, run, studio change or app page on the preview and compare it with production; they should look the same. If the triage test fails again, it needs its own issue: either a longer timeout or fewer issues per test.

🤖 Generated with Claude Code

commented

This deletes the .issue-head and .issue-meta rules from src/web/style/content.ts (.issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta) and strikes both classes from the §5d list in docs/DESIGN.md. Part one already moved the markup onto §5's components, so no page uses these classes and no page should change. No other rule changes. The whole diff against main is those 8 deleted lines and one edited line in docs/DESIGN.md.

.number also comes off the §5d list. Its only style was .issue-head h1 .number and no markup uses it, so once that rule went, bun scripts/design-lint.ts failed until it left §5d too.

main has been merged in again. The only conflict was the §5d class-list line in docs/DESIGN.md: the resolution keeps main's current list and strikes only .issue-head, .issue-meta and .number. After the merge:

  • grep finds those three names nowhere under src/ or docs/, apart from the tests that assert pages don't contain them, which are unchanged.
  • bun scripts/design-lint.ts is clean.
  • bun test test/design-lint.test.ts passes (15 tests).
  • bun x tsc --noEmit passes.

The earlier attempt (#4433) failed only on test/livetriage.test.ts ("at most 25 issues are filed per tick"), which this change doesn't touch. That test passed here on three runs before the previous push, and #4444 then came back green.

To try it, open an issue, commit, run, studio change or app page on the preview and compare it with production; they should look the same.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("a frozen mirror is said, and reconnected in one click > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs