Public: anyone can read this; the crew can change it.

.backups-drill, .backups-error, .backups-now, .backups-restore leave the stylesheet and docs/DESIGN.md §5d #4443

Parked opened this
Closed without merging

This pull removes the four .backups- rules that nothing uses any more. .backups-now and .backups-drill came out of the main rules in src/web/style/content.ts, and .backups-error and .backups-restore came out of the block near the chart series colours.

Notes

stopped parked by the crew deploy 91be5b3

opened this

This pull removes the four .backups-* rules that nothing uses any more. .backups-now and .backups-drill came out of the main rules in src/web/style/content.ts, and .backups-error and .backups-restore came out of the block near the chart series colours. The four names also leave the "page furniture" bullet in docs/DESIGN.md §5d. No markup changes, so the pages render the same.

  • Nothing still uses them: searching src/, test/ and docs/ finds no class attribute or rule for any of the four. The only mention left is in test/snapshot-outcome.test.ts:105, which checks that the snapshot page does not contain backups-error, so it still holds.
  • Design baseline: running bun scripts/design-lint.ts --update left docs/design/baseline.json unchanged (the count stayed equal), so it isn't part of this pull.
  • Why the last try failed: #4350 failed on "a frozen mirror is said, and reconnected in one click" in test/origins-reconnect.test.ts. That test reads none of the removed classes or the stylesheet. With main merged in, the whole file passed 4 runs out of 4 here, so the earlier failure looks flaky and unrelated to this change. If it fails again on this push, the problem is in that test, not this change.
  • Checks run: bun x tsc --noEmit is clean, and bun test test/design-lint.test.ts test/snapshot-outcome.test.ts passes.

To try it, open /settings/backups on the preview; it should look the same as production.

🤖 Generated with Claude Code

Closes #4131

2 earlier comments
commented

This pull removes the four .backups-* rules that nothing uses any more. .backups-now and .backups-drill came out of the main rules in src/web/style/content.ts, and .backups-error and .backups-restore came out of the block near the chart series colours. The four names also leave the "page furniture" bullet in docs/DESIGN.md §5d. No markup changes, so the pages render the same.

  • Nothing still uses them: searching src/, test/ and docs/ finds no class attribute or rule for any of the four. The only mention left is in test/snapshot-outcome.test.ts:105, which checks that the snapshot page does not contain backups-error, so it still holds.
  • Design baseline: running bun scripts/design-lint.ts --update left docs/design/baseline.json unchanged (the count stayed equal), so it isn't part of this pull.
  • Why the last try failed: #4350 failed on "a frozen mirror is said, and reconnected in one click" in test/origins-reconnect.test.ts. That test reads none of the removed classes or the stylesheet. With main merged in, the whole file passed 4 runs out of 4 here, so the earlier failure looks flaky and unrelated to this change. If it fails again on this push, the problem is in that test, not this change.
  • Checks run: bun x tsc --noEmit is clean, and bun test test/design-lint.test.ts test/snapshot-outcome.test.ts passes.

To try it, open /settings/backups on the preview; it should look the same as production.

🤖 Generated with Claude Code

commented

This pull removes the four .backups-* rules that nothing uses any more: .backups-drill, .backups-error, .backups-now and .backups-restore. Their CSS comes out of src/web/style/content.ts, and the four names leave the "page furniture" bullet in docs/DESIGN.md §5d. No markup changes, so the pages render the same.

  • Nothing still uses them: searching src/ and docs/ finds none of the four names. The only mention left is test/snapshot-outcome.test.ts:105, which checks that the page does not contain backups-error, so it still holds.
  • Merge with main: docs/DESIGN.md conflicted on that §5d bullet. The merge keeps main's version of the bullet and takes out only the four names, so this pull's whole diff against main is one changed line in docs/DESIGN.md and four deleted lines in content.ts.
  • Design baseline: bun scripts/design-lint.ts --update left docs/design/baseline.json unchanged (the count stayed equal), so it isn't part of this pull.
  • Checks run: bun x tsc --noEmit is clean, and bun test test/design-lint.test.ts test/snapshot-outcome.test.ts passes. These were run after the merge with main.
  • The earlier failure: #4350 failed on "a frozen mirror is said, and reconnected in one click" in test/origins-reconnect.test.ts. That test doesn't read the stylesheet or any of these classes, and it passed 4 runs out of 4 here before this merge. It looks flaky and unrelated to this change.

To try it, open /settings/backups on the preview; it should look the same as production.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("migrate: after > mirror: no write at migration, then one push to GitHub after a landing") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs