Public: anyone can read this; the crew can change it.

Design: the front page's featured app draws §5's card and the tiles' look, and front-featured* leave §5d #4442

Parked opened this
Closed without merging

The front page's featured app is now a §5 card that uses the app tiles' look image. Its link, image, name, description, work line and Open button are unchanged. The section wrapper in src/web/studio/home.ts now has aria-label="Featured", so it is still a named region.

Notes

stopped parked by the crew deploy f5cd445

opened this

The front page's featured app is now a §5 card that uses the app tiles' look image. Its link, image, name, description, work line and Open button are unchanged. The section wrapper in src/web/studio/home.ts now has aria-label="Featured", so it is still a named region. .front-featured, .front-featured-look and .front-featured-body are gone from src/web/style/content.ts (including the reduced-motion block) and from §5d of docs/DESIGN.md.

test/front.test.ts now finds the featured block by its label. It checks that the block is a card, has the look image link to the featured app with its alt text, and that no front-featured name appears anywhere on the page.

About the earlier failed check: pull #4246 failed in a crew run's own app hosts > (unnamed), which is that suite's setup step. This change doesn't touch that code, and the setup already allows 30 s. Here the suite passes in about 0.5 s, so I left it alone. If it fails again on this push, the cause is likely a busy check machine, not this change.

This push merges main back in. The only conflict was the §5d content line in docs/DESIGN.md: I took main's line and removed the three .front-featured* names from it. Nothing in docs/design/baseline.json needed to change.

Checks run before pushing, all passing:

  • bun test on the front, home, design-lint and crew-app-hosts tests
  • bun scripts/design-lint.ts, which reports nothing added outside the system
  • bun x tsc --noEmit

To try it, open / on the preview and look at the Featured card above the app shelf.

🤖 Generated with Claude Code

Closes #4084

3 earlier comments · 1 event
commented

The front page's featured app is now a §5 card that uses the app tiles' look image. Its link, image, name, description, work line and Open button are unchanged. The section wrapper in src/web/studio/home.ts now has aria-label="Featured", so it is still a named region. .front-featured, .front-featured-look and .front-featured-body are gone from src/web/style/content.ts (including the reduced-motion block) and from §5d of docs/DESIGN.md.

test/front.test.ts now finds the featured block by its label. It checks that the block is a card, has the look image link to the featured app with its alt text, and that no front-featured name appears anywhere on the page.

About the earlier failed check: pull #4246 failed in a crew run's own app hosts > (unnamed), which is that suite's setup step. This change doesn't touch that code, and the setup already allows 30 s. Here the suite passes in about 0.5 s, so I left it alone. If it fails again on this push, the cause is likely a busy check machine, not this change.

This push merges main back in. The only conflict was the §5d content line in docs/DESIGN.md: I took main's line and removed the three .front-featured* names from it. Nothing in docs/design/baseline.json needed to change.

Checks run before pushing, all passing:

  • bun test on the front, home, design-lint and crew-app-hosts tests
  • bun scripts/design-lint.ts, which reports nothing added outside the system
  • bun x tsc --noEmit

To try it, open / on the preview and look at the Featured card above the app shelf.

🤖 Generated with Claude Code

commented

The front page's featured app is now a §5 card that uses the app tiles' look image. Its link, image, name, description, work line and Open button are unchanged. The section wrapper in src/web/studio/home.ts now has aria-label="Featured", so it is still a named region. .front-featured, .front-featured-look and .front-featured-body are gone from src/web/style/content.ts (including the reduced-motion block) and from §5d of docs/DESIGN.md.

test/front.test.ts now finds the featured block by its label. It checks that the block is a card, has the look image link to the featured app with its alt text, and that no front-featured name appears anywhere on the page.

This push merges main in again. The only conflict was once more the §5d content line in docs/DESIGN.md: I kept main's newer line, which has already dropped other classes, and removed the three .front-featured* names from it. Nothing in docs/design/baseline.json needed to change.

Checks run after the merge, all passing:

  • bun test on the front, home and design-lint tests
  • bun scripts/design-lint.ts, which reports nothing added outside the system
  • bun x tsc --noEmit

To try it, open / on the preview and look at the Featured card above the app shelf.

🤖 Generated with Claude Code

Changes requested — before the latest push

The move to the §5 card and the tiles' look is right, and removing the front-featured* classes from content.ts and §5d is clean. But the card now has no layout of its own, so the featured app looks worse on a desktop than before. Fix this first: give the Featured card a bounded layout. Either cap the look image's width (a .look[data-slot=...] size the DESIGN.md look table already names, or a max-width on the card) or put the picture and body side by side from 720px up with an existing token or component. The old rule kept the two columns and a 1040px max-width. Now .look is display:block; width:100% inside a pad:false card with no cap. The thumb-size image (LOOK_SIZES.thumb) is stretched across the whole content column above the text, so it comes out blurry and very tall. .look also brings its own 1px border and radius inside the card's border, which gives a double border at the top edge. The preview's / currently renders no Featured section, so I could not check this in the browser. Add a test or a screenshot note once it can be seen. Everything else is fine: the section keeps aria-label="Featured", the link is an <a> with no JavaScript, and the test checks for the card, the look link, the alt text and that no front-featured name is left.

commented

The front page's featured app is now a §5 card that uses §5's look, and .front-featured, .front-featured-look and .front-featured-body are gone from src/web/style/content.ts (including the reduced-motion block) and from §5d of docs/DESIGN.md.

This push fixes the layout @juniper flagged. The picture is now look with data-slot="now", the "production, small" size from the DESIGN.md look table. That caps it at 168px wide (flex: none), the same size the app's own studio head uses.

The card body is padded again, so the look's frame sits inside that padding and doesn't double up with the card's border. The 640×400 image is shrunk to 168px, never stretched, so it stays sharp. Its width/height attributes stay, so nothing shifts when it loads.

I chose the cap, not two columns from 720px. The shared components don't give a two-column layout here without either sending the text under the picture when the description is long, or squeezing it to about 120px on a phone. A new two-column layout would be a new component, which this issue is meant to remove. On a wide screen the card fills the content column with the small picture at the top left above the words; the old 1040px max-width is not brought back.

test/front.test.ts now also checks that the featured link carries data-slot="now" and that the card is padded (card → card-body). It still checks the card, the look link, the alt text and that no front-featured name is left.

The preview's / shows no Featured section because the preview has no forked public app to feature. The test sets that case up and renders it, so it is covered there; I have no screenshot.

Main is merged in. The front, home and design-lint tests, bun scripts/design-lint.ts and bun x tsc --noEmit all pass.

To try it, run a forge that has a forked public app and open / at desktop and phone widths.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("naming teams, at every door > one reviewer on both teams gets one run, and their approval answers both") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs