Public: anyone can read this; the crew can change it.

.map-empty, .map-list leave the map's stylesheet and docs/DESIGN.md §5d #4439

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

Removes `.map-empty` and `.map-list` from the map page's CSS and from docs/DESIGN.md §5d. Part one already took them out of the markup, so this part deletes the CSS rules that styled them.

shipped production is serving it deploy fc82d1a

masoncrew opened this 23d ago

Removes .map-empty and .map-list from the map page's CSS and from docs/DESIGN.md §5d. Part one already took them out of the markup, so this part deletes the CSS rules that styled them.

src/web/pages/map.ts: deleted the five .map-list rules and the .map-empty rule. The shared selector #lanes details > .map-canvas, #lanes details > .map-empty is now just #lanes details > .map-canvas, with the same declarations. No other rule changed. .map-ask stays under its "beside the drawing" heading.
docs/DESIGN.md §5d: removed the two classes from the pages/map.ts entry.

grep finds neither class anywhere under src/ or docs/. Two kinds of test mention them, and both are unchanged: the tests in test/map.test.ts and test/pillars.test.ts that check pages don't use the classes, and test/map.test.ts:514, which checks that the output doesn't contain map-empty. Before pushing I ran bun x tsc --noEmit and bun scripts/design-lint.ts, both clean, and bun test test/design-lint.test.ts test/map.test.ts, which passed (27 tests). I didn't run test/pillars.test.ts locally.

To try it, open /map on the preview. An empty lane and the lanes list should look the same as on production, because nothing renders these classes any more.

🤖 Generated with Claude Code

Closes #4298

masoncrew commented 23d ago

Removes .map-empty and .map-list from the map page's CSS and from docs/DESIGN.md §5d. Part one already took them out of the markup, so this part deletes the CSS rules that styled them.

src/web/pages/map.ts: deleted the five .map-list rules and the .map-empty rule. The shared selector #lanes details > .map-canvas, #lanes details > .map-empty is now just #lanes details > .map-canvas, with the same declarations. No other rule changed. .map-ask stays under its "beside the drawing" heading.
docs/DESIGN.md §5d: removed the two classes from the pages/map.ts entry.

To try it, open /map on the preview. An empty lane and the lanes list should look the same as on production, because nothing renders these classes any more.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Pure deletion. In src/ and docs/ the only places that mention .map-list or .map-empty are the CSS rules this removes and the §5d entry, so no markup uses them. The shared #lanes selector keeps the same declarations for .map-canvas. /map on the preview answers 303, which I took to be the sign-in redirect; I could not view it signed in, so I judged the page from the source. Next: (1) check test/pillars.test.ts in CI, since it was not run locally; (2) keep shrinking the §5d map list the same way, starting with the unused .map-who-* and .map-tool* classes if the markup no longer needs them.