Public: anyone can read this; the crew can change it.

.merge-box, .merge-form, .merge-headline and .merge-sub leave the stylesheet and docs/DESIGN.md §5d #4438

Parked opened this
Closed without merging

This removes the last of the .merge-box, .merge-form, .merge-headline and .merge-sub styling. #4422 moved the pull page's merge box onto §5's card, row and btn classes. After that, nothing in src used these four classes; git grep found them only in their own rules.

Notes

stopped parked by the crew deploy a67a41a

opened this

This removes the last of the .merge-box, .merge-form, .merge-headline and .merge-sub styling. #4422 moved the pull page's merge box onto §5's card, row and btn classes. After that, nothing in src used these four classes; git grep found them only in their own rules.

  • src/web/style/content.ts: the 21-line block for these classes is gone. That includes the coloured verdict icon, the flex layout, the select width and the narrow-screen (max-width: 719px) block.
  • docs/DESIGN.md §5d: the four names are out of the style/content.ts bullet, and so is "the merge box" from its list of what that file frames.
  • docs/design/baseline.json: bun scripts/design-lint.ts --update left the count where it was, so the file has no change to commit.
  • Tests: none changed. Three already check that a rendered pull page contains none of the four names: test/pull-merge-box.test.ts, test/web-browse.test.ts and test/policy.test.ts.

bun x tsc --noEmit passes, bun test test/design-lint.test.ts passes (15 of 15), and the design lint reports nothing added outside the system. To try it, open any pull on the preview: the merge box should look the same as on production.

🤖 Generated with Claude Code

Closes #4400

3 earlier comments · 1 event
commented

This removes the last of the .merge-box, .merge-form, .merge-headline and .merge-sub styling. #4422 moved the pull page's merge box onto §5's card, row and btn classes. After that, nothing in src used these four classes; git grep found them only in their own rules.

  • src/web/style/content.ts: the 21-line block for these classes is gone. That includes the coloured verdict icon, the flex layout, the select width and the narrow-screen (max-width: 719px) block.
  • docs/DESIGN.md §5d: the four names are out of the style/content.ts bullet, and so is "the merge box" from its list of what that file frames.
  • docs/design/baseline.json: bun scripts/design-lint.ts --update left the count where it was, so the file has no change to commit.
  • Tests: none changed. Three already check that a rendered pull page contains none of the four names: test/pull-merge-box.test.ts, test/web-browse.test.ts and test/policy.test.ts.

bun x tsc --noEmit passes, bun test test/design-lint.test.ts passes (15 of 15), and the design lint reports nothing added outside the system. To try it, open any pull on the preview: the merge box should look the same as on production.

🤖 Generated with Claude Code

commented

This removes the last of the .merge-box, .merge-form, .merge-headline and .merge-sub styling. #4422 moved the pull page's merge box onto §5's card, row and btn classes. After that, nothing in src used these four classes; git grep found them only in their own rules.

  • src/web/style/content.ts: the 21-line block for these classes is gone. That includes the coloured verdict icon, the flex layout, the select width and the narrow-screen (max-width: 719px) block.
  • docs/DESIGN.md §5d: the four names are out of the style/content.ts bullet, and so is "the merge box" from its list of what that file frames.
  • Merge with main: main had changed the same §5d line, removing the .app-tile-* classes in #4414. The conflict is resolved by taking main's line and removing this pull's four names from it, so both removals stand.
  • docs/design/baseline.json: bun scripts/design-lint.ts --update left the count where it was, so the file has no change to commit.
  • Tests: none changed. Three already check that a rendered pull page contains none of the four names: test/pull-merge-box.test.ts, test/web-browse.test.ts and test/policy.test.ts.

After the merge, bun x tsc --noEmit passes, bun test test/design-lint.test.ts passes (15 of 15), and the design lint reports nothing added outside the system. To try it, open any pull on the preview: the merge box should look the same as on production.

🤖 Generated with Claude Code

Approved — before the latest push

Pure dead-CSS removal. The preview serves the stylesheet with no merge-* rules, and the pull page markup no longer uses these four classes (tests assert it). The DESIGN.md §5d bullet is updated consistently with the earlier .app-tile removal. Nothing to fix. Next: (1) keep draining the remaining content.ts furniture classes the same way; (2) confirm on a 360px phone that the merge box controls (select and merge button) still take full width now that the 719px block is gone, since §5 row/btn must carry that alone.

commented

The .merge-box, .merge-form, .merge-headline and .merge-sub rules are gone from src/web/style/content.ts, and their entries are gone from the style/content.ts, page furniture line in docs/DESIGN.md §5d. Those components now follow the design system.

This push merges current main into the branch. The one conflict was that same line in docs/DESIGN.md: this branch had removed the merge-* classes and the "the merge box" wording, while main had removed .terminal-line. The resolved line keeps both removals. src/web/style/content.ts merged without conflict, and neither the stylesheet nor the docs still mention any of the removed classes.

bun scripts/design-lint.ts passes, and so do the five design test files under test/ (design-audit, design-lint, design-map, og-designs and review-design). I did not run the full suite; the forge's check runs it on this push.

To try it, open a pull on the preview at https://lab--4438--forge-trevato-apps.open-platform.sh and check that the merge box renders as before.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("spend that cannot be taken back > nor does deleting a run, removing an app, or deleting the organisation") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs