Public: anyone can read this; the crew can change it.

.steps leaves the stylesheet and docs/DESIGN.md §5d #4435

Parked opened this
Closed without merging

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678). Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts. Docs: .steps is removed from the §5d list in docs/DESIGN.md, so §5d only gets shorter.

Notes

stopped parked by the crew deploy 986270f

opened this

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678).

  • Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts.
  • Docs: ` .steps is removed from the §5d list in docs/DESIGN.md`, so §5d only gets shorter.
  • No class left under src/: grep turns up no markup using steps as a class name. The remaining matches are TypeScript variables and properties named steps (for example candidate.steps) and the check-steps id. None of those is a class.

bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and bun x tsc --noEmit passes. The page doesn't look any different, because nothing was drawn with this class.

🤖 Generated with Claude Code

Closes #4303

2 earlier comments
commented

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678).

  • Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts.
  • Docs: ` .steps is removed from the §5d list in docs/DESIGN.md`, so §5d only gets shorter.
  • No class left under src/: grep turns up no markup using steps as a class name. The remaining matches are TypeScript variables and properties named steps (for example candidate.steps) and the check-steps id. None of those is a class.

bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and bun x tsc --noEmit passes. The page doesn't look any different, because nothing was drawn with this class.

🤖 Generated with Claude Code

commented

This removes the .steps class, which nothing in the markup uses any more, as part two of the design audit (#2678).

  • Stylesheet: the .steps and .steps li + li rules are deleted from src/web/style/content.ts.
  • Docs: ` .steps is removed from the §5d list in docs/DESIGN.md`, so §5d only gets shorter.
  • Merge with main: main had also changed the §5d line, which caused the conflict. I took main's version of the line and removed only ` .steps from it. Compared with main, this pull now changes just those two lines in docs/DESIGN.md` and the two deleted rules.
  • No class left under src/: grep turns up no markup using steps as a class name. The remaining matches are TypeScript variables and properties named steps (for example candidate.steps) and the check-steps id. None of those is a class.

After the merge, bun scripts/design-lint.ts is clean, bun test test/design-lint.test.ts passes (15 tests), and bun x tsc --noEmit passes. The page doesn't look any different, because nothing was drawn with this class.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("link the parent forge from settings > a linked person then signs in through the parent as the same account") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs